Re: [ovs-dev] [PATCH net-next v12 7/9] openvswitch: add Ethernet push and pop actions

2016-10-21 Thread Jiri Benc
On Thu, 20 Oct 2016 21:22:21 -0700, Pravin Shelar wrote: > The eth pop substracts ETH_HLEN but here the length is set. I think it > should be consistent with respect to eth-pop. Agreed. Will use skb_reset_mac_len in both, that better reflects what's going on. Thanks, Jiri

Re: [ovs-dev] [PATCH net-next v12 7/9] openvswitch: add Ethernet push and pop actions

2016-10-20 Thread Pravin Shelar
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > It's not allowed to push Ethernet header in front of another Ethernet > header. > > It's not allowed to pop Ethernet header if there's a vlan tag. This > preserves the invariant that L3 packet never has a vlan tag. > > Based on

[ovs-dev] [PATCH net-next v12 7/9] openvswitch: add Ethernet push and pop actions

2016-10-17 Thread Jiri Benc
It's not allowed to push Ethernet header in front of another Ethernet header. It's not allowed to pop Ethernet header if there's a vlan tag. This preserves the invariant that L3 packet never has a vlan tag. Based on previous versions by Lorand Jakab and Simon Horman. Signed-off-by: Lorand Jakab