Re: [ovs-dev] [PATCH] datapath: gre: Reset fix_segment pointer.
On Fri, May 1, 2015 at 2:41 PM, Jesse Gross wrote: > On Fri, May 1, 2015 at 12:40 PM, Pravin B Shelar wrote: >> For kernel version 3.12 to 3.18, GRE uses compat code to >> transmit packets which used fix_segment to segment packets. >> but ovs_gso_cb->fix_segment is not initialized for GRE tunnels. >> Following patches fixes it by resetting fix_segment. >> >> Signed-off-by: Pravin B Shelar > > On 3.16 I get the following: > WARNING: "rpl_gre_handle_offloads" > [/home/jesse/openvswitch/datapath/linux/vport-gre.ko] undefined! > > I think this is because the whole gre.c file is wrapped in a < 3.12 > block. The function is also copied as a static inline. right, I should I tested with new kernel. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH] datapath: gre: Reset fix_segment pointer.
On Fri, May 1, 2015 at 12:40 PM, Pravin B Shelar wrote: > For kernel version 3.12 to 3.18, GRE uses compat code to > transmit packets which used fix_segment to segment packets. > but ovs_gso_cb->fix_segment is not initialized for GRE tunnels. > Following patches fixes it by resetting fix_segment. > > Signed-off-by: Pravin B Shelar On 3.16 I get the following: WARNING: "rpl_gre_handle_offloads" [/home/jesse/openvswitch/datapath/linux/vport-gre.ko] undefined! I think this is because the whole gre.c file is wrapped in a < 3.12 block. The function is also copied as a static inline. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev