Re: [ovs-dev] [PATCH 0/4] Fix upgrade problems related to AutoAttach

2015-03-31 Thread Ben Pfaff
On Tue, Mar 31, 2015 at 04:39:47PM -0700, Alex Wang wrote:
> On Tue, Mar 31, 2015 at 4:12 PM, Ben Pfaff  wrote:
> 
> > On Tue, Mar 31, 2015 at 02:16:07PM -0700, Alex Wang wrote:
> > > Somehow I could not find the 4th patch,
> > >
> > > ovsdb-server: Correct malformed error replies to certain JSON-RPC
> > requests.
> > >
> > > Just want to give an Ack,
> > >
> > > Acked-by: Alex Wang 
> >
> > I can resend patches 3 and 4, or just patch 4, if you like.  Let me
> > know if you want another copy.
> >
> 
> I'm fine, I reviewed using your github branch~, did not try rebase to
> master,
> but i'm happy with these patches,
> 
> Acked-by: Alex Wang 

Thanks for the acks.  I pushed both of these to master.

I am not sure whether I should backport these.
___
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev


Re: [ovs-dev] [PATCH 0/4] Fix upgrade problems related to AutoAttach

2015-03-31 Thread Alex Wang
On Tue, Mar 31, 2015 at 4:12 PM, Ben Pfaff  wrote:

> On Tue, Mar 31, 2015 at 02:16:07PM -0700, Alex Wang wrote:
> > Somehow I could not find the 4th patch,
> >
> > ovsdb-server: Correct malformed error replies to certain JSON-RPC
> requests.
> >
> > Just want to give an Ack,
> >
> > Acked-by: Alex Wang 
>
> I can resend patches 3 and 4, or just patch 4, if you like.  Let me
> know if you want another copy.
>

I'm fine, I reviewed using your github branch~, did not try rebase to
master,
but i'm happy with these patches,

Acked-by: Alex Wang 
___
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev


Re: [ovs-dev] [PATCH 0/4] Fix upgrade problems related to AutoAttach

2015-03-31 Thread Ben Pfaff
On Tue, Mar 31, 2015 at 02:16:07PM -0700, Alex Wang wrote:
> Somehow I could not find the 4th patch,
> 
> ovsdb-server: Correct malformed error replies to certain JSON-RPC requests.
> 
> Just want to give an Ack,
> 
> Acked-by: Alex Wang 

I can resend patches 3 and 4, or just patch 4, if you like.  Let me
know if you want another copy.
___
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev


Re: [ovs-dev] [PATCH 0/4] Fix upgrade problems related to AutoAttach

2015-03-31 Thread Alex Wang
Somehow I could not find the 4th patch,

ovsdb-server: Correct malformed error replies to certain JSON-RPC requests.

Just want to give an Ack,

Acked-by: Alex Wang 

On Thu, Mar 19, 2015 at 11:52 PM, Ben Pfaff  wrote:

> The first two commits fix fairly serious upgrade problems specifically
> related to the new auto-attach feature.  The third commit is less critical;
> it fixes a similar upgrade bug in ovs-vswitchd specifically.  The fourth
> fixes a long-standing bug in ovsdb-server that I've known about for a few
> weeks.  It's not important but I'd like to get it fixed anyway.
>
> Ben Pfaff (4):
>   ovs-vsctl: Create AutoAttach records on demand, for backward
> compatibility.
>   ovs-vsctl: Only monitor AutoAttach columns when useful.
>   ovsdb-idl: Tolerate missing tables and columns.
>   ovsdb-server: Correct malformed error replies to certain JSON-RPC
> requests.
>
>  lib/ovsdb-idl.c  | 207
> +--
>  lib/ovsdb-parser.c   |  16 ++--
>  lib/ovsdb-parser.h   |   5 +-
>  ovsdb/jsonrpc-server.c   |  26 +++---
>  ovsdb/ovsdb-server.1.in  |  29 ++-
>  tests/automake.mk|   2 +-
>  tests/idltest2.ovsschema |  85 +++
>  tests/ovsdb-idl.at   |  75 +
>  tests/ovsdb-server.at|   2 +-
>  utilities/ovs-vsctl.c|  13 ++-
>  10 files changed, 407 insertions(+), 53 deletions(-)
>  create mode 100644 tests/idltest2.ovsschema
>
> --
> 2.1.3
>
> ___
> dev mailing list
> [email protected]
> http://openvswitch.org/mailman/listinfo/dev
>
___
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev