Re: [ovs-dev] [PATCH 1/2] ofproto: Remove double reporting from bundles.

2016-09-15 Thread Jarno Rajahalme

> On Sep 15, 2016, at 2:35 PM, Jarno Rajahalme  wrote:
> 
>> 
>> On Sep 14, 2016, at 8:55 PM, Ben Pfaff  wrote:
>> 
>> On Wed, Sep 14, 2016 at 07:25:34PM -0700, Jarno Rajahalme wrote:
>>> Patch b0d38b2f17 unified flow mod reporting in ofproto for both
>>> stand-alone flow mods and bundle flow mods, but left bundle-specific
>>> reporting to the bundle removal code.  This patch fixes this by
>>> removing the bundle-specific reporting of flow mods.
>>> 
>>> Found by inspection.
>>> 
>>> Fixes: b0d38b2f17 ("ofproto: Report flow mods also from bundles.")
>>> Signed-off-by: Jarno Rajahalme 
>> 
>> Nice.
>> 
>> Should this be covered by a test?
>> 
> 
> Pushed to master with a test change to cover this. Will push to branch-2.6 
> soon.
> 
> Thanks for the review!
> 
>  Jarno
> 
>> Acked-by: Ben Pfaff mailto:b...@ovn.org>>

Both patches backported to branch-2.6.

  Jarno

___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev


Re: [ovs-dev] [PATCH 1/2] ofproto: Remove double reporting from bundles.

2016-09-15 Thread Jarno Rajahalme

> On Sep 14, 2016, at 8:55 PM, Ben Pfaff  wrote:
> 
> On Wed, Sep 14, 2016 at 07:25:34PM -0700, Jarno Rajahalme wrote:
>> Patch b0d38b2f17 unified flow mod reporting in ofproto for both
>> stand-alone flow mods and bundle flow mods, but left bundle-specific
>> reporting to the bundle removal code.  This patch fixes this by
>> removing the bundle-specific reporting of flow mods.
>> 
>> Found by inspection.
>> 
>> Fixes: b0d38b2f17 ("ofproto: Report flow mods also from bundles.")
>> Signed-off-by: Jarno Rajahalme 
> 
> Nice.
> 
> Should this be covered by a test?
> 

Pushed to master with a test change to cover this. Will push to branch-2.6 soon.

Thanks for the review!

  Jarno

> Acked-by: Ben Pfaff 

___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev


Re: [ovs-dev] [PATCH 1/2] ofproto: Remove double reporting from bundles.

2016-09-14 Thread Ben Pfaff
On Wed, Sep 14, 2016 at 07:25:34PM -0700, Jarno Rajahalme wrote:
> Patch b0d38b2f17 unified flow mod reporting in ofproto for both
> stand-alone flow mods and bundle flow mods, but left bundle-specific
> reporting to the bundle removal code.  This patch fixes this by
> removing the bundle-specific reporting of flow mods.
> 
> Found by inspection.
> 
> Fixes: b0d38b2f17 ("ofproto: Report flow mods also from bundles.")
> Signed-off-by: Jarno Rajahalme 

Nice.

Should this be covered by a test?

Acked-by: Ben Pfaff 
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev