Re: [ovs-dev] [PATCH 2/5] bridge: Initialize dscp for mgmt connections.
On Wed, May 28, 2014 at 09:20:18AM -0700, Gurucharan Shetty wrote: > On Tue, May 27, 2014 at 5:04 PM, Ben Pfaff wrote: > > On Mon, May 19, 2014 at 12:52:23PM -0700, Gurucharan Shetty wrote: > >> Without it, garbage values make it to set_dscp function > >> in Windows. > >> > >> Signed-off-by: Gurucharan Shetty > > > > Ouch. Seems like an obvious bugfix, please backport. > > I back-ported it till branch 2.0. (I haven't seen Linux unit tests > fail anytime with garbage dscp value greater than 63, so for whatever > reason it is unlikely to be a problem.) Thanks. (Even if it doesn't cause failures, maybe it causes Linux to send these garbage dscp values on the wire.) ___ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH 2/5] bridge: Initialize dscp for mgmt connections.
On Tue, May 27, 2014 at 5:04 PM, Ben Pfaff wrote: > On Mon, May 19, 2014 at 12:52:23PM -0700, Gurucharan Shetty wrote: >> Without it, garbage values make it to set_dscp function >> in Windows. >> >> Signed-off-by: Gurucharan Shetty > > Ouch. Seems like an obvious bugfix, please backport. I back-ported it till branch 2.0. (I haven't seen Linux unit tests fail anytime with garbage dscp value greater than 63, so for whatever reason it is unlikely to be a problem.) > > Acked-by: Ben Pfaff ___ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH 2/5] bridge: Initialize dscp for mgmt connections.
On Mon, May 19, 2014 at 12:52:23PM -0700, Gurucharan Shetty wrote: > Without it, garbage values make it to set_dscp function > in Windows. > > Signed-off-by: Gurucharan Shetty Ouch. Seems like an obvious bugfix, please backport. Acked-by: Ben Pfaff ___ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
