Re: [ovs-dev] [PATCH v2] datapath: STT: Fix nf-hook softlockup.
On Wed, Jan 13, 2016 at 6:11 PM, Joe Stringer wrote: > On 13 January 2016 at 16:42, Pravin B Shelar wrote: >> nf-hook is not unregistered on STT device delete, But when >> second time it was created it nf-hook is again registered. >> which causes following softlockup. >> Following patch fixes it by registering nf-hook only on very >> first stt device. >> >> ---8<--- >> >> BUG: soft lockup - CPU#1 stuck for 22s! [ovs-vswitchd:11293] >> RIP: 0010:[] [] nf_ip_hook+0xf8/0x180 >> [openvswitch] >> Stack: >> >> [] ? ip_rcv_finish+0x350/0x350 >> [] nf_iterate+0x9a/0xb0 >> [] ? ip_rcv_finish+0x350/0x350 >> [] nf_hook_slow+0x7c/0x120 >> [] ? ip_rcv_finish+0x350/0x350 >> [] ip_local_deliver+0x73/0x80 >> [] ip_rcv_finish+0x7d/0x350 >> [] ip_rcv+0x298/0x3d0 >> [] __netif_receive_skb_core+0x696/0x880 >> [] __netif_receive_skb+0x18/0x60 >> [] process_backlog+0xae/0x180 >> [] net_rx_action+0x152/0x270 >> [] __do_softirq+0xec/0x300 >> [] do_softirq_own_stack+0x1c/0x30 >> >> Fixes: fee43fa2 ("datapath: Fix deadlock on STT device destroy.") >> Signed-off-by: Pravin B Shelar > > Seems to be working well. > > Tested-by: Joe Stringer I pushed the patch to master and branch 2.5. Thanks. > ___ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH v2] datapath: STT: Fix nf-hook softlockup.
On 13 January 2016 at 18:11, Joe Stringer wrote: > On 13 January 2016 at 16:42, Pravin B Shelar wrote: >> nf-hook is not unregistered on STT device delete, But when >> second time it was created it nf-hook is again registered. >> which causes following softlockup. >> Following patch fixes it by registering nf-hook only on very >> first stt device. >> >> ---8<--- >> >> BUG: soft lockup - CPU#1 stuck for 22s! [ovs-vswitchd:11293] >> RIP: 0010:[] [] nf_ip_hook+0xf8/0x180 >> [openvswitch] >> Stack: >> >> [] ? ip_rcv_finish+0x350/0x350 >> [] nf_iterate+0x9a/0xb0 >> [] ? ip_rcv_finish+0x350/0x350 >> [] nf_hook_slow+0x7c/0x120 >> [] ? ip_rcv_finish+0x350/0x350 >> [] ip_local_deliver+0x73/0x80 >> [] ip_rcv_finish+0x7d/0x350 >> [] ip_rcv+0x298/0x3d0 >> [] __netif_receive_skb_core+0x696/0x880 >> [] __netif_receive_skb+0x18/0x60 >> [] process_backlog+0xae/0x180 >> [] net_rx_action+0x152/0x270 >> [] __do_softirq+0xec/0x300 >> [] do_softirq_own_stack+0x1c/0x30 >> >> Fixes: fee43fa2 ("datapath: Fix deadlock on STT device destroy.") >> Signed-off-by: Pravin B Shelar FYI I merged this already to bumblebee. I'll follow up if there is anything else related. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH v2] datapath: STT: Fix nf-hook softlockup.
On 13 January 2016 at 16:42, Pravin B Shelar wrote: > nf-hook is not unregistered on STT device delete, But when > second time it was created it nf-hook is again registered. > which causes following softlockup. > Following patch fixes it by registering nf-hook only on very > first stt device. > > ---8<--- > > BUG: soft lockup - CPU#1 stuck for 22s! [ovs-vswitchd:11293] > RIP: 0010:[] [] nf_ip_hook+0xf8/0x180 > [openvswitch] > Stack: > > [] ? ip_rcv_finish+0x350/0x350 > [] nf_iterate+0x9a/0xb0 > [] ? ip_rcv_finish+0x350/0x350 > [] nf_hook_slow+0x7c/0x120 > [] ? ip_rcv_finish+0x350/0x350 > [] ip_local_deliver+0x73/0x80 > [] ip_rcv_finish+0x7d/0x350 > [] ip_rcv+0x298/0x3d0 > [] __netif_receive_skb_core+0x696/0x880 > [] __netif_receive_skb+0x18/0x60 > [] process_backlog+0xae/0x180 > [] net_rx_action+0x152/0x270 > [] __do_softirq+0xec/0x300 > [] do_softirq_own_stack+0x1c/0x30 > > Fixes: fee43fa2 ("datapath: Fix deadlock on STT device destroy.") > Signed-off-by: Pravin B Shelar Seems to be working well. Tested-by: Joe Stringer ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH v2] datapath: STT: Fix nf-hook softlockup.
On 13 January 2016 at 16:42, Pravin B Shelar wrote: > nf-hook is not unregistered on STT device delete, But when > second time it was created it nf-hook is again registered. > which causes following softlockup. > Following patch fixes it by registering nf-hook only on very > first stt device. > > ---8<--- > > BUG: soft lockup - CPU#1 stuck for 22s! [ovs-vswitchd:11293] > RIP: 0010:[] [] nf_ip_hook+0xf8/0x180 > [openvswitch] > Stack: > > [] ? ip_rcv_finish+0x350/0x350 > [] nf_iterate+0x9a/0xb0 > [] ? ip_rcv_finish+0x350/0x350 > [] nf_hook_slow+0x7c/0x120 > [] ? ip_rcv_finish+0x350/0x350 > [] ip_local_deliver+0x73/0x80 > [] ip_rcv_finish+0x7d/0x350 > [] ip_rcv+0x298/0x3d0 > [] __netif_receive_skb_core+0x696/0x880 > [] __netif_receive_skb+0x18/0x60 > [] process_backlog+0xae/0x180 > [] net_rx_action+0x152/0x270 > [] __do_softirq+0xec/0x300 > [] do_softirq_own_stack+0x1c/0x30 > > Fixes: fee43fa2 ("datapath: Fix deadlock on STT device destroy.") > Signed-off-by: Pravin B Shelar Thanks for the fix. Looks good. I will run some tests over the next hour. I got the following warning when applying the patch: warning: 1 line adds whitespace errors. VMware-BZ: #1585144 ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev