Re: [ovs-dev] [PATCH v2] datapath-windows: Remove the external/internal port only if it is removed on the Hyper-V switch
On Tue, Jun 23, 2015 at 08:16:41PM +, Nithin Raju wrote: > > On Jun 23, 2015, at 12:42 PM, Ben Pfaff wrote: > > > > On Thu, Jun 18, 2015 at 09:05:32PM +, Nithin Raju wrote: > >>> On Jun 18, 2015, at 1:57 PM, Alin Serdean > >>> wrote: > >>> > >>> I have no issue with it if it is tested. > >>> > >>> Yes Nithin you are right we agreed that you will work on it but it was in > >>> the backlog for some time and it is a show stopper because it also > >>> fixes(https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitch_ovs-2Dissues_issues_62&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pNHQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=mGRgSLlhBsu9jwYpHagt2xLxS1GSklQgTGXxMSuEL-g&s=YIhRLJ49Q4cetS_HYw_jccyA5VQFWGMPvnX6bq7yGKY&e= > >>> ). > >> > >> I’ll send out my fix today. I ran into a crash while testing > >> creation/deletion of vxlan port. Debugging that right now. > >> > >> Thanks for your understanding. > > > > Does this mean that you're working on a different fix? Or is this patch > > one that should be applied? > > hi Ben, > Alin, Sorin and I agreed that we’ll use my patch that I send out (later) here: > http://openvswitch.org/pipermail/dev/2015-June/056579.html > > Alin found some issues with the patch while validating it, and I am working > with him offline to get the patch validated. Once I get an ACK from him > offline, I’ll post a new revision of the patch. > > As of now, we don’t have any “datapath-windows” patches pending to be > committed. Thanks for the update! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH v2] datapath-windows: Remove the external/internal port only if it is removed on the Hyper-V switch
> On Jun 23, 2015, at 12:42 PM, Ben Pfaff wrote: > > On Thu, Jun 18, 2015 at 09:05:32PM +, Nithin Raju wrote: >>> On Jun 18, 2015, at 1:57 PM, Alin Serdean >>> wrote: >>> >>> I have no issue with it if it is tested. >>> >>> Yes Nithin you are right we agreed that you will work on it but it was in >>> the backlog for some time and it is a show stopper because it also >>> fixes(https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitch_ovs-2Dissues_issues_62&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pNHQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=mGRgSLlhBsu9jwYpHagt2xLxS1GSklQgTGXxMSuEL-g&s=YIhRLJ49Q4cetS_HYw_jccyA5VQFWGMPvnX6bq7yGKY&e= >>> ). >> >> I’ll send out my fix today. I ran into a crash while testing >> creation/deletion of vxlan port. Debugging that right now. >> >> Thanks for your understanding. > > Does this mean that you're working on a different fix? Or is this patch > one that should be applied? hi Ben, Alin, Sorin and I agreed that we’ll use my patch that I send out (later) here: http://openvswitch.org/pipermail/dev/2015-June/056579.html Alin found some issues with the patch while validating it, and I am working with him offline to get the patch validated. Once I get an ACK from him offline, I’ll post a new revision of the patch. As of now, we don’t have any “datapath-windows” patches pending to be committed. thanks, -- Nithin ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH v2] datapath-windows: Remove the external/internal port only if it is removed on the Hyper-V switch
On Thu, Jun 18, 2015 at 09:05:32PM +, Nithin Raju wrote: > > On Jun 18, 2015, at 1:57 PM, Alin Serdean > > wrote: > > > > I have no issue with it if it is tested. > > > > Yes Nithin you are right we agreed that you will work on it but it was in > > the backlog for some time and it is a show stopper because it also > > fixes(https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitch_ovs-2Dissues_issues_62&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pNHQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=mGRgSLlhBsu9jwYpHagt2xLxS1GSklQgTGXxMSuEL-g&s=YIhRLJ49Q4cetS_HYw_jccyA5VQFWGMPvnX6bq7yGKY&e= > > ). > > I’ll send out my fix today. I ran into a crash while testing > creation/deletion of vxlan port. Debugging that right now. > > Thanks for your understanding. Does this mean that you're working on a different fix? Or is this patch one that should be applied? Thanks, Ben. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH v2] datapath-windows: Remove the external/internal port only if it is removed on the Hyper-V switch
> On Jun 18, 2015, at 1:57 PM, Alin Serdean > wrote: > > I have no issue with it if it is tested. > > Yes Nithin you are right we agreed that you will work on it but it was in the > backlog for some time and it is a show stopper because it also > fixes(https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitch_ovs-2Dissues_issues_62&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pNHQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=mGRgSLlhBsu9jwYpHagt2xLxS1GSklQgTGXxMSuEL-g&s=YIhRLJ49Q4cetS_HYw_jccyA5VQFWGMPvnX6bq7yGKY&e= > ). I’ll send out my fix today. I ran into a crash while testing creation/deletion of vxlan port. Debugging that right now. Thanks for your understanding. -- Nithin ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH v2] datapath-windows: Remove the external/internal port only if it is removed on the Hyper-V switch
I have no issue with it if it is tested. Yes Nithin you are right we agreed that you will work on it but it was in the backlog for some time and it is a show stopper because it also fixes(https://github.com/openvswitch/ovs-issues/issues/62). Alin. -Mesaj original- De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju Trimis: Thursday, June 18, 2015 11:29 PM Către: Sorin Vinturis Cc: dev@openvswitch.org Subiect: Re: [ovs-dev] [PATCH v2] datapath-windows: Remove the external/internal port only if it is removed on the Hyper-V switch Sorin/Alin, I worked on a patch for this issue, and I am testing it today. I’ve also refactored some of the code in Vport.c. Would it be ok if I send out my patch instead of this? IIRC, we had agreed that VMware folks would work on this issue. thanks, -- Nithin ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH v2] datapath-windows: Remove the external/internal port only if it is removed on the Hyper-V switch
Sorin/Alin, I worked on a patch for this issue, and I am testing it today. I’ve also refactored some of the code in Vport.c. Would it be ok if I send out my patch instead of this? IIRC, we had agreed that VMware folks would work on this issue. thanks, -- Nithin ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev