Re: [ovs-dev] [PATCH v2] netdev-dpdk: Add new 'dpdkvhostuserclient' port type
Hi I am on vaction until next week so didn’t see this till now. Thanks for appling the patch to master and the 2.6 branch. I will rebase my openstack patches next week when I get back and resubmit for ocata. Regards Sean. From: Daniele Di Proietto [mailto:diproiet...@ovn.org] Sent: Monday, September 19, 2016 10:11 PM To: Mooney, Sean K Cc: Loftus, Ciara ; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v2] netdev-dpdk: Add new 'dpdkvhostuserclient' port type Apologies for the delay, applied to master and branch-2.6 Thanks, Daniele 2016-09-15 6:53 GMT-07:00 Mooney, Sean K mailto:sean.k.moo...@intel.com>>: Hi I just wanted to follow up on the status of this patch. Without this patch support for vhost user reconnect will be blocked in openstack. At this point It is now too late to include support for this feature in the newton release In q4 but I would like to enable it early in the Openstack Ocata cycle if possible. Will this be in ovs 2.6? Regard sean > -Original Message- > From: Mooney, Sean K > Sent: Saturday, August 20, 2016 12:22 AM > To: Loftus, Ciara mailto:ciara.lof...@intel.com>>; > dev@openvswitch.org<mailto:dev@openvswitch.org> > Cc: diproiet...@vmware.com<mailto:diproiet...@vmware.com>; Mooney, Sean K > mailto:sean.k.moo...@intel.com>> > Subject: RE: [PATCH v2] netdev-dpdk: Add new 'dpdkvhostuserclient' port > type > > Hi I have updated my openstack changes > https://review.openstack.org/#/c/344997/ (neutron) > https://review.openstack.org/#/c/357555/ (os-vif) > https://review.openstack.org/#/c/334048/ (nova) to work with this > change and tested it with the v1 patch. > As far as I can tell the only change in v2 is in the install.dpdk- > advanced and Commit message but I can retest with v2 also if desired. > > Time permitting assuming this change is accepted I will also submit a > patch to networking-ovn And networking-odl Next week to complete > enabling the feature in each of the Main ovs compatible neutron > backends. > > > -Original Message- > > From: Loftus, Ciara > > Sent: Friday, August 19, 2016 10:23 AM > > To: dev@openvswitch.org<mailto:dev@openvswitch.org> > > Cc: diproiet...@vmware.com<mailto:diproiet...@vmware.com>; Mooney, Sean K > > mailto:sean.k.moo...@intel.com>>; > > Loftus, Ciara mailto:ciara.lof...@intel.com>> > > Subject: [PATCH v2] netdev-dpdk: Add new 'dpdkvhostuserclient' port > > type > > > > The 'dpdkvhostuser' port type no longer supports both server and > > client mode. Instead, 'dpdkvhostuser' ports are always 'server' mode > > and 'dpdkvhostuserclient' ports are always 'client' mode. > > > > Suggested-by: Daniele Di Proietto > > mailto:diproiet...@vmware.com>> > > Signed-off-by: Ciara Loftus > > mailto:ciara.lof...@intel.com>> > > --- > > INSTALL.DPDK-ADVANCED.md<http://INSTALL.DPDK-ADVANCED.md> | 102 > > +++ > > NEWS | 1 + > > lib/netdev-dpdk.c| 176 ++--- > -- > > > > vswitchd/vswitch.xml | 8 +-- > > 4 files changed, 159 insertions(+), 128 deletions(-) > > > > diff --git a/INSTALL.DPDK-ADVANCED.md<http://INSTALL.DPDK-ADVANCED.md> > > b/INSTALL.DPDK-ADVANCED.md<http://INSTALL.DPDK-ADVANCED.md> > index > > 857c805..d7b9873 100755 > > --- a/INSTALL.DPDK-ADVANCED.md<http://INSTALL.DPDK-ADVANCED.md> > > +++ b/INSTALL.DPDK-ADVANCED.md<http://INSTALL.DPDK-ADVANCED.md> > > @@ -461,6 +461,21 @@ For users wanting to do packet forwarding using > > kernel stack below are the steps > > ``` > > > > ## 6. Vhost Walkthrough > > + > > +Two types of vHost User ports are available in OVS: > > + > > +1. vhost-user (dpdkvhostuser ports) > > + > > +2. vhost-user-client (dpdkvhostuserclient ports) > > + > > +vHost User uses a client-server model. The server > > +creates/manages/destroys the vHost User sockets, and the client > > +connects to the server. Depending on which port type you use, > > +dpdkvhostuser or dpdkvhostuserclient, a different configuration of > > +the > > client-server model is used. > > + > > +For vhost-user ports, OVS DPDK acts as the server and QEMU the > client. > > +For vhost-user-client ports, OVS DPDK acts as the client and QEMU > the > > server. > > + > > ### 6.1 vhost-user > > > >- Prerequisites: > > @@ -570,49 +585,6 @@ For users wanting to do packet forwarding using > > kernel stack below are
Re: [ovs-dev] [PATCH v2] netdev-dpdk: Add new 'dpdkvhostuserclient' port type
Apologies for the delay, applied to master and branch-2.6 Thanks, Daniele 2016-09-15 6:53 GMT-07:00 Mooney, Sean K : > Hi I just wanted to follow up on the status of this patch. > > Without this patch support for vhost user reconnect will be blocked in > openstack. > > At this point It is now too late to include support for this feature in > the newton release > In q4 but I would like to enable it early in the Openstack Ocata cycle if > possible. > > Will this be in ovs 2.6? > Regard > sean > > > > -Original Message- > > From: Mooney, Sean K > > Sent: Saturday, August 20, 2016 12:22 AM > > To: Loftus, Ciara ; dev@openvswitch.org > > Cc: diproiet...@vmware.com; Mooney, Sean K > > Subject: RE: [PATCH v2] netdev-dpdk: Add new 'dpdkvhostuserclient' port > > type > > > > Hi I have updated my openstack changes > > https://review.openstack.org/#/c/344997/ (neutron) > > https://review.openstack.org/#/c/357555/ (os-vif) > > https://review.openstack.org/#/c/334048/ (nova) to work with this > > change and tested it with the v1 patch. > > As far as I can tell the only change in v2 is in the install.dpdk- > > advanced and Commit message but I can retest with v2 also if desired. > > > > Time permitting assuming this change is accepted I will also submit a > > patch to networking-ovn And networking-odl Next week to complete > > enabling the feature in each of the Main ovs compatible neutron > > backends. > > > > > -Original Message- > > > From: Loftus, Ciara > > > Sent: Friday, August 19, 2016 10:23 AM > > > To: dev@openvswitch.org > > > Cc: diproiet...@vmware.com; Mooney, Sean K ; > > > Loftus, Ciara > > > Subject: [PATCH v2] netdev-dpdk: Add new 'dpdkvhostuserclient' port > > > type > > > > > > The 'dpdkvhostuser' port type no longer supports both server and > > > client mode. Instead, 'dpdkvhostuser' ports are always 'server' mode > > > and 'dpdkvhostuserclient' ports are always 'client' mode. > > > > > > Suggested-by: Daniele Di Proietto > > > Signed-off-by: Ciara Loftus > > > --- > > > INSTALL.DPDK-ADVANCED.md | 102 +++ > > > NEWS | 1 + > > > lib/netdev-dpdk.c| 176 ++--- > > -- > > > > > > vswitchd/vswitch.xml | 8 +-- > > > 4 files changed, 159 insertions(+), 128 deletions(-) > > > > > > diff --git a/INSTALL.DPDK-ADVANCED.md b/INSTALL.DPDK-ADVANCED.md > > index > > > 857c805..d7b9873 100755 > > > --- a/INSTALL.DPDK-ADVANCED.md > > > +++ b/INSTALL.DPDK-ADVANCED.md > > > @@ -461,6 +461,21 @@ For users wanting to do packet forwarding using > > > kernel stack below are the steps > > > ``` > > > > > > ## 6. Vhost Walkthrough > > > + > > > +Two types of vHost User ports are available in OVS: > > > + > > > +1. vhost-user (dpdkvhostuser ports) > > > + > > > +2. vhost-user-client (dpdkvhostuserclient ports) > > > + > > > +vHost User uses a client-server model. The server > > > +creates/manages/destroys the vHost User sockets, and the client > > > +connects to the server. Depending on which port type you use, > > > +dpdkvhostuser or dpdkvhostuserclient, a different configuration of > > > +the > > > client-server model is used. > > > + > > > +For vhost-user ports, OVS DPDK acts as the server and QEMU the > > client. > > > +For vhost-user-client ports, OVS DPDK acts as the client and QEMU > > the > > > server. > > > + > > > ### 6.1 vhost-user > > > > > >- Prerequisites: > > > @@ -570,49 +585,6 @@ For users wanting to do packet forwarding using > > > kernel stack below are the steps > > > where `-L`: Changes the numbers of channels of the specified > > > network device > > > and `combined`: Changes the number of multi-purpose channels. > > > > > > -4. OVS vHost client-mode & vHost reconnect (OPTIONAL) > > > - > > > - By default, OVS DPDK acts as the vHost socket server for > > > dpdkvhostuser > > > - ports and QEMU acts as the vHost client. This means OVS > > creates > > > and > > > - manages the vHost socket and QEMU is the client which > > connects > > > to the > > > - vHost server (OVS). In QEMU v2.7 the option is available for > > > QEMU to act > > > - as the vHost server meaning the roles can be reversed and OVS > > > can become > > > - the vHost client. To enable client mode for a given > > > dpdkvhostuserport, > > > - one must specify a valid 'vhost-server-path' like so: > > > - > > > - ``` > > > - ovs-vsctl set Interface dpdkvhostuser0 options:vhost-server- > > > path=/path/to/socket > > > - ``` > > > - > > > - Setting this value automatically switches the port to client > > > mode (from > > > - OVS' perspective). 'vhost-server-path' reflects the full path > > > of the > > > - socket that has been or will be created by QEMU for the given > > > vHost User > > > - port. Once a path is specified, the port will remain in > > > 'client' mode > > > - for the remainder of it's l
Re: [ovs-dev] [PATCH v2] netdev-dpdk: Add new 'dpdkvhostuserclient' port type
Hi I just wanted to follow up on the status of this patch. Without this patch support for vhost user reconnect will be blocked in openstack. At this point It is now too late to include support for this feature in the newton release In q4 but I would like to enable it early in the Openstack Ocata cycle if possible. Will this be in ovs 2.6? Regard sean > -Original Message- > From: Mooney, Sean K > Sent: Saturday, August 20, 2016 12:22 AM > To: Loftus, Ciara ; dev@openvswitch.org > Cc: diproiet...@vmware.com; Mooney, Sean K > Subject: RE: [PATCH v2] netdev-dpdk: Add new 'dpdkvhostuserclient' port > type > > Hi I have updated my openstack changes > https://review.openstack.org/#/c/344997/ (neutron) > https://review.openstack.org/#/c/357555/ (os-vif) > https://review.openstack.org/#/c/334048/ (nova) to work with this > change and tested it with the v1 patch. > As far as I can tell the only change in v2 is in the install.dpdk- > advanced and Commit message but I can retest with v2 also if desired. > > Time permitting assuming this change is accepted I will also submit a > patch to networking-ovn And networking-odl Next week to complete > enabling the feature in each of the Main ovs compatible neutron > backends. > > > -Original Message- > > From: Loftus, Ciara > > Sent: Friday, August 19, 2016 10:23 AM > > To: dev@openvswitch.org > > Cc: diproiet...@vmware.com; Mooney, Sean K ; > > Loftus, Ciara > > Subject: [PATCH v2] netdev-dpdk: Add new 'dpdkvhostuserclient' port > > type > > > > The 'dpdkvhostuser' port type no longer supports both server and > > client mode. Instead, 'dpdkvhostuser' ports are always 'server' mode > > and 'dpdkvhostuserclient' ports are always 'client' mode. > > > > Suggested-by: Daniele Di Proietto > > Signed-off-by: Ciara Loftus > > --- > > INSTALL.DPDK-ADVANCED.md | 102 +++ > > NEWS | 1 + > > lib/netdev-dpdk.c| 176 ++--- > -- > > > > vswitchd/vswitch.xml | 8 +-- > > 4 files changed, 159 insertions(+), 128 deletions(-) > > > > diff --git a/INSTALL.DPDK-ADVANCED.md b/INSTALL.DPDK-ADVANCED.md > index > > 857c805..d7b9873 100755 > > --- a/INSTALL.DPDK-ADVANCED.md > > +++ b/INSTALL.DPDK-ADVANCED.md > > @@ -461,6 +461,21 @@ For users wanting to do packet forwarding using > > kernel stack below are the steps > > ``` > > > > ## 6. Vhost Walkthrough > > + > > +Two types of vHost User ports are available in OVS: > > + > > +1. vhost-user (dpdkvhostuser ports) > > + > > +2. vhost-user-client (dpdkvhostuserclient ports) > > + > > +vHost User uses a client-server model. The server > > +creates/manages/destroys the vHost User sockets, and the client > > +connects to the server. Depending on which port type you use, > > +dpdkvhostuser or dpdkvhostuserclient, a different configuration of > > +the > > client-server model is used. > > + > > +For vhost-user ports, OVS DPDK acts as the server and QEMU the > client. > > +For vhost-user-client ports, OVS DPDK acts as the client and QEMU > the > > server. > > + > > ### 6.1 vhost-user > > > >- Prerequisites: > > @@ -570,49 +585,6 @@ For users wanting to do packet forwarding using > > kernel stack below are the steps > > where `-L`: Changes the numbers of channels of the specified > > network device > > and `combined`: Changes the number of multi-purpose channels. > > > > -4. OVS vHost client-mode & vHost reconnect (OPTIONAL) > > - > > - By default, OVS DPDK acts as the vHost socket server for > > dpdkvhostuser > > - ports and QEMU acts as the vHost client. This means OVS > creates > > and > > - manages the vHost socket and QEMU is the client which > connects > > to the > > - vHost server (OVS). In QEMU v2.7 the option is available for > > QEMU to act > > - as the vHost server meaning the roles can be reversed and OVS > > can become > > - the vHost client. To enable client mode for a given > > dpdkvhostuserport, > > - one must specify a valid 'vhost-server-path' like so: > > - > > - ``` > > - ovs-vsctl set Interface dpdkvhostuser0 options:vhost-server- > > path=/path/to/socket > > - ``` > > - > > - Setting this value automatically switches the port to client > > mode (from > > - OVS' perspective). 'vhost-server-path' reflects the full path > > of the > > - socket that has been or will be created by QEMU for the given > > vHost User > > - port. Once a path is specified, the port will remain in > > 'client' mode > > - for the remainder of it's lifetime ie. it cannot be reverted > > back to > > - server mode. > > - > > - One must append ',server' to the 'chardev' arguments on the > > QEMU command > > - line, to instruct QEMU to use vHost server mode for a given > > interface, > > - like so: > > - > > - > > - -chardev socket,id=char0,path=/path/to/socket,server > > -
Re: [ovs-dev] [PATCH v2] netdev-dpdk: Add new 'dpdkvhostuserclient' port type
Hi I have updated my openstack changes https://review.openstack.org/#/c/344997/ (neutron) https://review.openstack.org/#/c/357555/ (os-vif) https://review.openstack.org/#/c/334048/ (nova) to work with this change and tested it with the v1 patch. As far as I can tell the only change in v2 is in the install.dpdk-advanced and Commit message but I can retest with v2 also if desired. Time permitting assuming this change is accepted I will also submit a patch to networking-ovn And networking-odl Next week to complete enabling the feature in each of the Main ovs compatible neutron backends. > -Original Message- > From: Loftus, Ciara > Sent: Friday, August 19, 2016 10:23 AM > To: dev@openvswitch.org > Cc: diproiet...@vmware.com; Mooney, Sean K ; > Loftus, Ciara > Subject: [PATCH v2] netdev-dpdk: Add new 'dpdkvhostuserclient' port > type > > The 'dpdkvhostuser' port type no longer supports both server and client > mode. Instead, 'dpdkvhostuser' ports are always 'server' mode and > 'dpdkvhostuserclient' ports are always 'client' mode. > > Suggested-by: Daniele Di Proietto > Signed-off-by: Ciara Loftus > --- > INSTALL.DPDK-ADVANCED.md | 102 +++ > NEWS | 1 + > lib/netdev-dpdk.c| 176 ++- > > vswitchd/vswitch.xml | 8 +-- > 4 files changed, 159 insertions(+), 128 deletions(-) > > diff --git a/INSTALL.DPDK-ADVANCED.md b/INSTALL.DPDK-ADVANCED.md index > 857c805..d7b9873 100755 > --- a/INSTALL.DPDK-ADVANCED.md > +++ b/INSTALL.DPDK-ADVANCED.md > @@ -461,6 +461,21 @@ For users wanting to do packet forwarding using > kernel stack below are the steps > ``` > > ## 6. Vhost Walkthrough > + > +Two types of vHost User ports are available in OVS: > + > +1. vhost-user (dpdkvhostuser ports) > + > +2. vhost-user-client (dpdkvhostuserclient ports) > + > +vHost User uses a client-server model. The server > +creates/manages/destroys the vHost User sockets, and the client > +connects to the server. Depending on which port type you use, > +dpdkvhostuser or dpdkvhostuserclient, a different configuration of the > client-server model is used. > + > +For vhost-user ports, OVS DPDK acts as the server and QEMU the client. > +For vhost-user-client ports, OVS DPDK acts as the client and QEMU the > server. > + > ### 6.1 vhost-user > >- Prerequisites: > @@ -570,49 +585,6 @@ For users wanting to do packet forwarding using > kernel stack below are the steps > where `-L`: Changes the numbers of channels of the specified > network device > and `combined`: Changes the number of multi-purpose channels. > > -4. OVS vHost client-mode & vHost reconnect (OPTIONAL) > - > - By default, OVS DPDK acts as the vHost socket server for > dpdkvhostuser > - ports and QEMU acts as the vHost client. This means OVS creates > and > - manages the vHost socket and QEMU is the client which connects > to the > - vHost server (OVS). In QEMU v2.7 the option is available for > QEMU to act > - as the vHost server meaning the roles can be reversed and OVS > can become > - the vHost client. To enable client mode for a given > dpdkvhostuserport, > - one must specify a valid 'vhost-server-path' like so: > - > - ``` > - ovs-vsctl set Interface dpdkvhostuser0 options:vhost-server- > path=/path/to/socket > - ``` > - > - Setting this value automatically switches the port to client > mode (from > - OVS' perspective). 'vhost-server-path' reflects the full path > of the > - socket that has been or will be created by QEMU for the given > vHost User > - port. Once a path is specified, the port will remain in > 'client' mode > - for the remainder of it's lifetime ie. it cannot be reverted > back to > - server mode. > - > - One must append ',server' to the 'chardev' arguments on the > QEMU command > - line, to instruct QEMU to use vHost server mode for a given > interface, > - like so: > - > - > - -chardev socket,id=char0,path=/path/to/socket,server > - > - > - If the corresponding dpdkvhostuser port has not yet been > configured in > - OVS with vhost-server-path=/path/to/socket, QEMU will print a > log > - similar to the following: > - > - `QEMU waiting for connection on: > disconnected:unix:/path/to/socket,server` > - > - QEMU will wait until the port is created sucessfully in OVS to > boot the > - VM. > - > - One benefit of using this mode is the ability for vHost ports > to > - 'reconnect' in event of the switch crashing or being brought > down. Once > - it is brought back up, the vHost ports will reconnect > automatically and > - normal service will resume. > - >- VM Configuration with libvirt > > * change the user/group, access control policty and restart > libvirtd. > @@ -657,7 +629,49 @@ For users wanting to do packet
