Re: [ovs-dev] [PATCH v2 2/2] utilities: ovs-ctl: Handle start up errors
On Mon, Sep 12, 2016 at 10:07:57AM +0100, Markos Chandras wrote: > Make sure we take the return values into consideration so we can > break early in case of failures. This makes the ovs-ctl helper more > accurate in reporting the real status of its managing processes. > > Cc: Aaron Conole > Signed-off-by: Markos Chandras Thanks for the patches. I applied these to master. I did not backport them to any release branches because I am nervous about possibly unexpected effects in corner cases. However, if this fixes some specific problem you were seeing with 2.6, let me know and I'll backport them to branch-2.6. Thanks, Ben. ___ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH v2 2/2] utilities: ovs-ctl: Handle start up errors
Markos Chandras writes: > Make sure we take the return values into consideration so we can > break early in case of failures. This makes the ovs-ctl helper more > accurate in reporting the real status of its managing processes. > > Cc: Aaron Conole > Signed-off-by: Markos Chandras I like this change. I haven't tested all the corner-cases with it, but it's on my agenda - basically what happens during restart case when one of the inner spawns causes failure. I have tested some with it, and like that it indicates status results properly. I think you will need to add something for the restart case, but that can be a follow on patch. Acked-by: Aaron Conole ___ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
