Re: [ovs-dev] [PATCH v4 0/7] system-traffic: add 802.1ad test cases
On 18 October 2016 at 05:31, Eric Garverwrote: > On Mon, Oct 17, 2016 at 05:17:44PM -0700, Joe Stringer wrote: >> On 23 September 2016 at 12:16, Eric Garver wrote: >> > This series adds 802.1ad test cases for the check-* make targets. It is >> > meant as a counterpart to the 802.1ad work currently going on and being >> > discussed on the dev list. >> > >> > User space support for 802.1ad is being worked on by Xiao Liang (based >> > on Thomas F Herbert's work). Kernel support is already present in >> > upstream net-next tree. >> > >> > Tested with v5 of Xiao's 802.1ad patch series. >> > Tested with; recent (4.8.0-rc4+) net-next kernel, upstream 4.7.3, and >> > upstream 3.19.8. >> > Tested with v1 of Eric Garver's "netdev-linux: double tagged packets >> > should use 0x88a8" patch. >> >> Hi Eric, thanks for submitting the series. >> > > Joe, > Thanks for reviewing! > >> Patches 1-3 look good to go now, with one minor exception (I can roll >> it inline and push if you're happy; see patch #2). >> > > Sounds good to me. Alternatively, I can split this series and resubmit > patches 1-3 if you prefer. It's alright, dropping one piece is easy enough. I pushed the first three patches, with that change. I believe I got it right, but if you see something strange on master then please let me know. >> Patches 4-7 won't have any effect until the implementation is added, >> so I suggest that in future these patches be posted with the >> implementation as a single series. > > That's fine. I'll resubmit after 802.1ad is added. OK, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH v4 0/7] system-traffic: add 802.1ad test cases
On Mon, Oct 17, 2016 at 05:17:44PM -0700, Joe Stringer wrote: > On 23 September 2016 at 12:16, Eric Garverwrote: > > This series adds 802.1ad test cases for the check-* make targets. It is > > meant as a counterpart to the 802.1ad work currently going on and being > > discussed on the dev list. > > > > User space support for 802.1ad is being worked on by Xiao Liang (based > > on Thomas F Herbert's work). Kernel support is already present in > > upstream net-next tree. > > > > Tested with v5 of Xiao's 802.1ad patch series. > > Tested with; recent (4.8.0-rc4+) net-next kernel, upstream 4.7.3, and > > upstream 3.19.8. > > Tested with v1 of Eric Garver's "netdev-linux: double tagged packets > > should use 0x88a8" patch. > > Hi Eric, thanks for submitting the series. > Joe, Thanks for reviewing! > Patches 1-3 look good to go now, with one minor exception (I can roll > it inline and push if you're happy; see patch #2). > Sounds good to me. Alternatively, I can split this series and resubmit patches 1-3 if you prefer. > Patches 4-7 won't have any effect until the implementation is added, > so I suggest that in future these patches be posted with the > implementation as a single series. That's fine. I'll resubmit after 802.1ad is added. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH v4 0/7] system-traffic: add 802.1ad test cases
On 23 September 2016 at 12:16, Eric Garverwrote: > This series adds 802.1ad test cases for the check-* make targets. It is > meant as a counterpart to the 802.1ad work currently going on and being > discussed on the dev list. > > User space support for 802.1ad is being worked on by Xiao Liang (based > on Thomas F Herbert's work). Kernel support is already present in > upstream net-next tree. > > Tested with v5 of Xiao's 802.1ad patch series. > Tested with; recent (4.8.0-rc4+) net-next kernel, upstream 4.7.3, and > upstream 3.19.8. > Tested with v1 of Eric Garver's "netdev-linux: double tagged packets > should use 0x88a8" patch. Hi Eric, thanks for submitting the series. Patches 1-3 look good to go now, with one minor exception (I can roll it inline and push if you're happy; see patch #2). Patches 4-7 won't have any effect until the implementation is added, so I suggest that in future these patches be posted with the implementation as a single series. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev