Re: [ovs-dev] OVS LLVM scan results
On Sun, Apr 26, 2015 at 02:35:38AM +0800, Kevin Lo wrote: > On Fri, Apr 17, 2015 at 10:49:07AM -0700, Ben Pfaff wrote: > > > > On Sat, Apr 18, 2015 at 01:44:00AM +0800, Kevin Lo wrote: > > > On Thu, Apr 16, 2015 at 08:53:15AM -0700, Ben Pfaff wrote: > > > > > > > > On Thu, Apr 16, 2015 at 10:47:13AM +0800, Kevin Lo wrote: > > > > > On Wed, Apr 15, 2015 at 07:38:51AM -0700, Ben Pfaff wrote: > > > > > > > > > > > > On Wed, Apr 15, 2015 at 10:35:44PM +0800, Kevin Lo wrote: > > > > > > > For those that are interested, I've run the LLVM scan-build tool > > > > > > > to > > > > > > > perform static analysis of the OVS code on FreeBSD and make the > > > > > > > results availalble at > > > > > > > http://people.freebsd.org/~kevlo/ovs-scan/scan-build-2015-04-15/ > > > > > > > > > > > > Thanks! I ran this once or twice years ago, but I haven't kept up. > > > > > > > > > > It seems to me that there are bugs that need to be fixed. > > > > > For example: > > > > > https://people.freebsd.org/~kevlo/ovs-scan/scan-build-2015-04-15/report-050910.html#EndPath > > > > > > > > Yes, it just takes a while to individually review the reports. I sent > > > > out one fix just now: > > > > http://openvswitch.org/pipermail/dev/2015-April/054070.html > > > > > > > > > > You fixed over 10 bugs :-) Please see: > > > https://people.freebsd.org/~kevlo/ovs-scan/scan-build-2015-04-18/ > > > > Thanks. > > > > It looks like 4 of my patches haven't been reviewed yet, so after they > > get reviews a few more of the reports should go away. > > Nice. Cleaner code is better code. Mostly. > I ran scan-build again and it found a minor bug: > https://people.freebsd.org/~kevlo/ovs-scan/scan-build-2015-04-24/report-daad78.html#EndPath > > Don't know why the analyzer didn't catch it previously. Thanks, I sent out a fix for this one too: http://openvswitch.org/pipermail/dev/2015-April/054641.html ___ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] OVS LLVM scan results
On Fri, Apr 17, 2015 at 10:49:07AM -0700, Ben Pfaff wrote: > > On Sat, Apr 18, 2015 at 01:44:00AM +0800, Kevin Lo wrote: > > On Thu, Apr 16, 2015 at 08:53:15AM -0700, Ben Pfaff wrote: > > > > > > On Thu, Apr 16, 2015 at 10:47:13AM +0800, Kevin Lo wrote: > > > > On Wed, Apr 15, 2015 at 07:38:51AM -0700, Ben Pfaff wrote: > > > > > > > > > > On Wed, Apr 15, 2015 at 10:35:44PM +0800, Kevin Lo wrote: > > > > > > For those that are interested, I've run the LLVM scan-build tool to > > > > > > perform static analysis of the OVS code on FreeBSD and make the > > > > > > results availalble at > > > > > > http://people.freebsd.org/~kevlo/ovs-scan/scan-build-2015-04-15/ > > > > > > > > > > Thanks! I ran this once or twice years ago, but I haven't kept up. > > > > > > > > It seems to me that there are bugs that need to be fixed. > > > > For example: > > > > https://people.freebsd.org/~kevlo/ovs-scan/scan-build-2015-04-15/report-050910.html#EndPath > > > > > > Yes, it just takes a while to individually review the reports. I sent > > > out one fix just now: > > > http://openvswitch.org/pipermail/dev/2015-April/054070.html > > > > > > > You fixed over 10 bugs :-) Please see: > > https://people.freebsd.org/~kevlo/ovs-scan/scan-build-2015-04-18/ > > Thanks. > > It looks like 4 of my patches haven't been reviewed yet, so after they > get reviews a few more of the reports should go away. Nice. Cleaner code is better code. Mostly. I ran scan-build again and it found a minor bug: https://people.freebsd.org/~kevlo/ovs-scan/scan-build-2015-04-24/report-daad78.html#EndPath Don't know why the analyzer didn't catch it previously. > A lot of the reports are IMO false positives (I did look at every > report) but I'm happy to hear about it if anyone disagrees. Thanks. Kevin ___ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] OVS LLVM scan results
On Sat, Apr 18, 2015 at 01:44:00AM +0800, Kevin Lo wrote: > On Thu, Apr 16, 2015 at 08:53:15AM -0700, Ben Pfaff wrote: > > > > On Thu, Apr 16, 2015 at 10:47:13AM +0800, Kevin Lo wrote: > > > On Wed, Apr 15, 2015 at 07:38:51AM -0700, Ben Pfaff wrote: > > > > > > > > On Wed, Apr 15, 2015 at 10:35:44PM +0800, Kevin Lo wrote: > > > > > For those that are interested, I've run the LLVM scan-build tool to > > > > > perform static analysis of the OVS code on FreeBSD and make the > > > > > results availalble at > > > > > http://people.freebsd.org/~kevlo/ovs-scan/scan-build-2015-04-15/ > > > > > > > > Thanks! I ran this once or twice years ago, but I haven't kept up. > > > > > > It seems to me that there are bugs that need to be fixed. > > > For example: > > > https://people.freebsd.org/~kevlo/ovs-scan/scan-build-2015-04-15/report-050910.html#EndPath > > > > Yes, it just takes a while to individually review the reports. I sent > > out one fix just now: > > http://openvswitch.org/pipermail/dev/2015-April/054070.html > > > > You fixed over 10 bugs :-) Please see: > https://people.freebsd.org/~kevlo/ovs-scan/scan-build-2015-04-18/ Thanks. It looks like 4 of my patches haven't been reviewed yet, so after they get reviews a few more of the reports should go away. A lot of the reports are IMO false positives (I did look at every report) but I'm happy to hear about it if anyone disagrees. ___ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] OVS LLVM scan results
On Thu, Apr 16, 2015 at 08:53:15AM -0700, Ben Pfaff wrote: > > On Thu, Apr 16, 2015 at 10:47:13AM +0800, Kevin Lo wrote: > > On Wed, Apr 15, 2015 at 07:38:51AM -0700, Ben Pfaff wrote: > > > > > > On Wed, Apr 15, 2015 at 10:35:44PM +0800, Kevin Lo wrote: > > > > For those that are interested, I've run the LLVM scan-build tool to > > > > perform static analysis of the OVS code on FreeBSD and make the > > > > results availalble at > > > > http://people.freebsd.org/~kevlo/ovs-scan/scan-build-2015-04-15/ > > > > > > Thanks! I ran this once or twice years ago, but I haven't kept up. > > > > It seems to me that there are bugs that need to be fixed. > > For example: > > https://people.freebsd.org/~kevlo/ovs-scan/scan-build-2015-04-15/report-050910.html#EndPath > > Yes, it just takes a while to individually review the reports. I sent > out one fix just now: > http://openvswitch.org/pipermail/dev/2015-April/054070.html > You fixed over 10 bugs :-) Please see: https://people.freebsd.org/~kevlo/ovs-scan/scan-build-2015-04-18/ Kevin ___ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] OVS LLVM scan results
On Thu, Apr 16, 2015 at 08:53:15AM -0700, Ben Pfaff wrote: > On Thu, Apr 16, 2015 at 10:47:13AM +0800, Kevin Lo wrote: > > On Wed, Apr 15, 2015 at 07:38:51AM -0700, Ben Pfaff wrote: > > > > > > On Wed, Apr 15, 2015 at 10:35:44PM +0800, Kevin Lo wrote: > > > > For those that are interested, I've run the LLVM scan-build tool to > > > > perform static analysis of the OVS code on FreeBSD and make the > > > > results availalble at > > > > http://people.freebsd.org/~kevlo/ovs-scan/scan-build-2015-04-15/ > > > > > > Thanks! I ran this once or twice years ago, but I haven't kept up. > > > > It seems to me that there are bugs that need to be fixed. > > For example: > > https://people.freebsd.org/~kevlo/ovs-scan/scan-build-2015-04-15/report-050910.html#EndPath > > Yes, it just takes a while to individually review the reports. I sent > out one fix just now: > http://openvswitch.org/pipermail/dev/2015-April/054070.html I processed all the reports now. Thanks again. ___ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] OVS LLVM scan results
On Thu, Apr 16, 2015 at 10:47:13AM +0800, Kevin Lo wrote: > On Wed, Apr 15, 2015 at 07:38:51AM -0700, Ben Pfaff wrote: > > > > On Wed, Apr 15, 2015 at 10:35:44PM +0800, Kevin Lo wrote: > > > For those that are interested, I've run the LLVM scan-build tool to > > > perform static analysis of the OVS code on FreeBSD and make the > > > results availalble at > > > http://people.freebsd.org/~kevlo/ovs-scan/scan-build-2015-04-15/ > > > > Thanks! I ran this once or twice years ago, but I haven't kept up. > > It seems to me that there are bugs that need to be fixed. > For example: > https://people.freebsd.org/~kevlo/ovs-scan/scan-build-2015-04-15/report-050910.html#EndPath Yes, it just takes a while to individually review the reports. I sent out one fix just now: http://openvswitch.org/pipermail/dev/2015-April/054070.html ___ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] OVS LLVM scan results
On Wed, Apr 15, 2015 at 07:38:51AM -0700, Ben Pfaff wrote: > > On Wed, Apr 15, 2015 at 10:35:44PM +0800, Kevin Lo wrote: > > For those that are interested, I've run the LLVM scan-build tool to > > perform static analysis of the OVS code on FreeBSD and make the > > results availalble at > > http://people.freebsd.org/~kevlo/ovs-scan/scan-build-2015-04-15/ > > Thanks! I ran this once or twice years ago, but I haven't kept up. It seems to me that there are bugs that need to be fixed. For example: https://people.freebsd.org/~kevlo/ovs-scan/scan-build-2015-04-15/report-050910.html#EndPath Kevin ___ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] OVS LLVM scan results
On Wed, Apr 15, 2015 at 10:35:44PM +0800, Kevin Lo wrote: > For those that are interested, I've run the LLVM scan-build tool to > perform static analysis of the OVS code on FreeBSD and make the > results availalble at > http://people.freebsd.org/~kevlo/ovs-scan/scan-build-2015-04-15/ Thanks! I ran this once or twice years ago, but I haven't kept up. ___ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
