Re: [ovs-dev] Support for Linux kernels >= 3.12 with the out of tree kernel module
On Wed, Mar 19, 2014 at 7:06 PM, Jesse Gross wrote: > On Mon, Mar 10, 2014 at 12:32 PM, Pravin Shelar wrote: >> On Thu, Mar 6, 2014 at 1:57 PM, Kyle Mestery >> wrote: >>> On Thu, Feb 27, 2014 at 3:28 PM, Pravin Shelar wrote: On Thu, Feb 27, 2014 at 12:41 PM, Kyle Mestery wrote: > On Wed, Feb 26, 2014 at 5:07 PM, Pravin Shelar > wrote: >> >> On Wed, Feb 26, 2014 at 2:09 PM, Kyle Mestery >> >> wrote: >> > I see this patch [1] in patchwork now from Pravin via James Page. >> > I pulled this down and started to look at what it would take to get >> > this >> > also working with 3.13. It looks like the netlink interfaces changed >> > a >> > bit here. Is anyone working on this at the moment? If not, I'd like >> > to >> > take this on. Secondly, how are things like this handled in the >> > datapath >> > now. I'm hesitant to put a bunch of #ifdefs in the code there. >> > Guidance >> > appreciated. >> > >> I do not think anyone is working on 3.13 support. >> I have not looked at netlink changes but lets try to avoid #ifdef as >> much possible. We can add compat code to compat directory to handle >> any API change. >> > OK, agreed. > >> >> > Thanks, >> > Kyle >> > >> > [1] http://patchwork.openvswitch.org/patch/2972/ >> > >> >> If you or someone else review it, I can apply this patch. >> > I just updated patchwork to assign this one to myself, reviewing it now. > Is the workflow such that if I click "approve" in patchwork it will > automatically > merge the patch? Do I still need to send an email to the list with the > standard "Reviewed-by" or "Acked-by"? > yes, review is still done on mailing list. patchwork is to mostly used to track remaining reviews. >>> So, I don't have the original email to reply to here, but I've reviewed this >>> patch in patchwork here [1], and it looks fine to me. >>> >>> Reviewed-by: Kyle Mestery >>> >> Thanks. >> I pushed it to master. > > This patch updates the FAQ to say that the recently released 2.1 > supports Linux 3.12 but I'm not sure that the patch was applied to > that branch, right? No, It was not pushed to 2.1, I will update FAQ on master. ___ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] Support for Linux kernels >= 3.12 with the out of tree kernel module
On Mon, Mar 10, 2014 at 12:32 PM, Pravin Shelar wrote: > On Thu, Mar 6, 2014 at 1:57 PM, Kyle Mestery > wrote: >> On Thu, Feb 27, 2014 at 3:28 PM, Pravin Shelar wrote: >>> >>> On Thu, Feb 27, 2014 at 12:41 PM, Kyle Mestery >>> wrote: >>> > On Wed, Feb 26, 2014 at 5:07 PM, Pravin Shelar >>> > wrote: >>> >> >>> >> On Wed, Feb 26, 2014 at 2:09 PM, Kyle Mestery >>> >> >>> >> wrote: >>> >> > I see this patch [1] in patchwork now from Pravin via James Page. >>> >> > I pulled this down and started to look at what it would take to get >>> >> > this >>> >> > also working with 3.13. It looks like the netlink interfaces changed >>> >> > a >>> >> > bit here. Is anyone working on this at the moment? If not, I'd like >>> >> > to >>> >> > take this on. Secondly, how are things like this handled in the >>> >> > datapath >>> >> > now. I'm hesitant to put a bunch of #ifdefs in the code there. >>> >> > Guidance >>> >> > appreciated. >>> >> > >>> >> I do not think anyone is working on 3.13 support. >>> >> I have not looked at netlink changes but lets try to avoid #ifdef as >>> >> much possible. We can add compat code to compat directory to handle >>> >> any API change. >>> >> >>> > OK, agreed. >>> > >>> >> >>> >> > Thanks, >>> >> > Kyle >>> >> > >>> >> > [1] http://patchwork.openvswitch.org/patch/2972/ >>> >> > >>> >> >>> >> If you or someone else review it, I can apply this patch. >>> >> >>> > I just updated patchwork to assign this one to myself, reviewing it now. >>> > Is the workflow such that if I click "approve" in patchwork it will >>> > automatically >>> > merge the patch? Do I still need to send an email to the list with the >>> > standard "Reviewed-by" or "Acked-by"? >>> > >>> yes, review is still done on mailing list. patchwork is to mostly used >>> to track remaining reviews. >>> >> So, I don't have the original email to reply to here, but I've reviewed this >> patch in patchwork here [1], and it looks fine to me. >> >> Reviewed-by: Kyle Mestery >> > Thanks. > I pushed it to master. This patch updates the FAQ to say that the recently released 2.1 supports Linux 3.12 but I'm not sure that the patch was applied to that branch, right? ___ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] Support for Linux kernels >= 3.12 with the out of tree kernel module
On Thu, Mar 6, 2014 at 1:57 PM, Kyle Mestery wrote: > On Thu, Feb 27, 2014 at 3:28 PM, Pravin Shelar wrote: >> >> On Thu, Feb 27, 2014 at 12:41 PM, Kyle Mestery >> wrote: >> > On Wed, Feb 26, 2014 at 5:07 PM, Pravin Shelar >> > wrote: >> >> >> >> On Wed, Feb 26, 2014 at 2:09 PM, Kyle Mestery >> >> >> >> wrote: >> >> > I see this patch [1] in patchwork now from Pravin via James Page. >> >> > I pulled this down and started to look at what it would take to get >> >> > this >> >> > also working with 3.13. It looks like the netlink interfaces changed >> >> > a >> >> > bit here. Is anyone working on this at the moment? If not, I'd like >> >> > to >> >> > take this on. Secondly, how are things like this handled in the >> >> > datapath >> >> > now. I'm hesitant to put a bunch of #ifdefs in the code there. >> >> > Guidance >> >> > appreciated. >> >> > >> >> I do not think anyone is working on 3.13 support. >> >> I have not looked at netlink changes but lets try to avoid #ifdef as >> >> much possible. We can add compat code to compat directory to handle >> >> any API change. >> >> >> > OK, agreed. >> > >> >> >> >> > Thanks, >> >> > Kyle >> >> > >> >> > [1] http://patchwork.openvswitch.org/patch/2972/ >> >> > >> >> >> >> If you or someone else review it, I can apply this patch. >> >> >> > I just updated patchwork to assign this one to myself, reviewing it now. >> > Is the workflow such that if I click "approve" in patchwork it will >> > automatically >> > merge the patch? Do I still need to send an email to the list with the >> > standard "Reviewed-by" or "Acked-by"? >> > >> yes, review is still done on mailing list. patchwork is to mostly used >> to track remaining reviews. >> > So, I don't have the original email to reply to here, but I've reviewed this > patch in patchwork here [1], and it looks fine to me. > > Reviewed-by: Kyle Mestery > Thanks. I pushed it to master. > Pravin, once this goes in, I'll look into 3.13 support next if that's ok > with > you. > > Thanks, > Kyle > > [1] http://patchwork.openvswitch.org/patch/2972/ > >> >> >> >> >> >> >> >> > ___ >> >> > dev mailing list >> >> > [email protected] >> >> > http://openvswitch.org/mailman/listinfo/dev >> >> > >> > >> > > > ___ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] Support for Linux kernels >= 3.12 with the out of tree kernel module
On Thu, Feb 27, 2014 at 3:28 PM, Pravin Shelar wrote: > On Thu, Feb 27, 2014 at 12:41 PM, Kyle Mestery > wrote: > > On Wed, Feb 26, 2014 at 5:07 PM, Pravin Shelar > wrote: > >> > >> On Wed, Feb 26, 2014 at 2:09 PM, Kyle Mestery < > [email protected]> > >> wrote: > >> > I see this patch [1] in patchwork now from Pravin via James Page. > >> > I pulled this down and started to look at what it would take to get > this > >> > also working with 3.13. It looks like the netlink interfaces changed a > >> > bit here. Is anyone working on this at the moment? If not, I'd like to > >> > take this on. Secondly, how are things like this handled in the > datapath > >> > now. I'm hesitant to put a bunch of #ifdefs in the code there. > Guidance > >> > appreciated. > >> > > >> I do not think anyone is working on 3.13 support. > >> I have not looked at netlink changes but lets try to avoid #ifdef as > >> much possible. We can add compat code to compat directory to handle > >> any API change. > >> > > OK, agreed. > > > >> > >> > Thanks, > >> > Kyle > >> > > >> > [1] http://patchwork.openvswitch.org/patch/2972/ > >> > > >> > >> If you or someone else review it, I can apply this patch. > >> > > I just updated patchwork to assign this one to myself, reviewing it now. > > Is the workflow such that if I click "approve" in patchwork it will > > automatically > > merge the patch? Do I still need to send an email to the list with the > > standard "Reviewed-by" or "Acked-by"? > > > yes, review is still done on mailing list. patchwork is to mostly used > to track remaining reviews. > > So, I don't have the original email to reply to here, but I've reviewed this patch in patchwork here [1], and it looks fine to me. Reviewed-by: Kyle Mestery Pravin, once this goes in, I'll look into 3.13 support next if that's ok with you. Thanks, Kyle [1] http://patchwork.openvswitch.org/patch/2972/ > >> > >> > >> > ___ > >> > dev mailing list > >> > [email protected] > >> > http://openvswitch.org/mailman/listinfo/dev > >> > > > > > > ___ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] Support for Linux kernels >= 3.12 with the out of tree kernel module
On Thu, Feb 27, 2014 at 02:41:13PM -0600, Kyle Mestery wrote: > Is the workflow such that if I click "approve" in patchwork it will > automatically merge the patch? Do I still need to send an email to > the list with the standard "Reviewed-by" or "Acked-by"? Patchwork is just a tracking tool. It doesn't have a way to push anything to the repo. ___ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] Support for Linux kernels >= 3.12 with the out of tree kernel module
On Thu, Feb 27, 2014 at 12:41 PM, Kyle Mestery wrote: > On Wed, Feb 26, 2014 at 5:07 PM, Pravin Shelar wrote: >> >> On Wed, Feb 26, 2014 at 2:09 PM, Kyle Mestery >> wrote: >> > I see this patch [1] in patchwork now from Pravin via James Page. >> > I pulled this down and started to look at what it would take to get this >> > also working with 3.13. It looks like the netlink interfaces changed a >> > bit here. Is anyone working on this at the moment? If not, I'd like to >> > take this on. Secondly, how are things like this handled in the datapath >> > now. I'm hesitant to put a bunch of #ifdefs in the code there. Guidance >> > appreciated. >> > >> I do not think anyone is working on 3.13 support. >> I have not looked at netlink changes but lets try to avoid #ifdef as >> much possible. We can add compat code to compat directory to handle >> any API change. >> > OK, agreed. > >> >> > Thanks, >> > Kyle >> > >> > [1] http://patchwork.openvswitch.org/patch/2972/ >> > >> >> If you or someone else review it, I can apply this patch. >> > I just updated patchwork to assign this one to myself, reviewing it now. > Is the workflow such that if I click "approve" in patchwork it will > automatically > merge the patch? Do I still need to send an email to the list with the > standard "Reviewed-by" or "Acked-by"? > yes, review is still done on mailing list. patchwork is to mostly used to track remaining reviews. >> >> >> > ___ >> > dev mailing list >> > [email protected] >> > http://openvswitch.org/mailman/listinfo/dev >> > > > ___ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] Support for Linux kernels >= 3.12 with the out of tree kernel module
On Wed, Feb 26, 2014 at 5:07 PM, Pravin Shelar wrote: > On Wed, Feb 26, 2014 at 2:09 PM, Kyle Mestery > wrote: > > I see this patch [1] in patchwork now from Pravin via James Page. > > I pulled this down and started to look at what it would take to get this > > also working with 3.13. It looks like the netlink interfaces changed a > > bit here. Is anyone working on this at the moment? If not, I'd like to > > take this on. Secondly, how are things like this handled in the datapath > > now. I'm hesitant to put a bunch of #ifdefs in the code there. Guidance > > appreciated. > > > I do not think anyone is working on 3.13 support. > I have not looked at netlink changes but lets try to avoid #ifdef as > much possible. We can add compat code to compat directory to handle > any API change. > > OK, agreed. > > Thanks, > > Kyle > > > > [1] http://patchwork.openvswitch.org/patch/2972/ > > > > If you or someone else review it, I can apply this patch. > > I just updated patchwork to assign this one to myself, reviewing it now. Is the workflow such that if I click "approve" in patchwork it will automatically merge the patch? Do I still need to send an email to the list with the standard "Reviewed-by" or "Acked-by"? > > > ___ > > dev mailing list > > [email protected] > > http://openvswitch.org/mailman/listinfo/dev > > > ___ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] Support for Linux kernels >= 3.12 with the out of tree kernel module
On Wed, Feb 26, 2014 at 2:09 PM, Kyle Mestery wrote: > I see this patch [1] in patchwork now from Pravin via James Page. > I pulled this down and started to look at what it would take to get this > also working with 3.13. It looks like the netlink interfaces changed a > bit here. Is anyone working on this at the moment? If not, I'd like to > take this on. Secondly, how are things like this handled in the datapath > now. I'm hesitant to put a bunch of #ifdefs in the code there. Guidance > appreciated. > I do not think anyone is working on 3.13 support. I have not looked at netlink changes but lets try to avoid #ifdef as much possible. We can add compat code to compat directory to handle any API change. > Thanks, > Kyle > > [1] http://patchwork.openvswitch.org/patch/2972/ > If you or someone else review it, I can apply this patch. > ___ > dev mailing list > [email protected] > http://openvswitch.org/mailman/listinfo/dev > ___ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
