rabbah commented on a change in pull request #3: support large arguments
URL:
https://github.com/apache/incubator-openwhisk-runtime-docker/pull/3#discussion_r163620453
##########
File path: core/actionProxy/actionproxy.py
##########
@@ -127,18 +127,29 @@ def error(msg):
try:
input = json.dumps(args)
- p = subprocess.Popen(
- [self.binary, input],
- stdout=subprocess.PIPE,
- stderr=subprocess.PIPE,
- env=env)
+ if len(input) > 131071: # MAX_ARG_STRLEN (131071)
linux/binfmts.h
+ # pass argument via stdin
+ p = subprocess.Popen(
+ [self.binary],
+ stdin=subprocess.PIPE,
+ stdout=subprocess.PIPE,
+ stderr=subprocess.PIPE,
+ env=env)
+ else:
+ # pass argument via stdin and command parameter
Review comment:
I suggest that we _always_ do this. That is we migrate all actions to use
the `stdin` path instead of `argv[1]`. The code above will be a fail safe for
all existing actions which will only work up to 128K.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
