[GitHub] orc pull request #152: ORC-227: [C++] Fix docker failure due to ExternalProj...

2017-08-10 Thread majetideepak
Github user majetideepak commented on a diff in the pull request: https://github.com/apache/orc/pull/152#discussion_r132477368 --- Diff: c++/src/ByteRLE.cc --- @@ -26,9 +26,9 @@ namespace orc { - const size_t MINIMUM_REPEAT = 3; - const size_t

[GitHub] orc issue #149: ORC-224: Implement column writers of primitive types

2017-08-10 Thread majetideepak
Github user majetideepak commented on the issue: https://github.com/apache/orc/pull/149 @wgtmac I will take a look at this today/tomorrow. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] orc pull request #151: ORC-226 Support getWriterId in c++ reader interface

2017-08-10 Thread omalley
Github user omalley commented on a diff in the pull request: https://github.com/apache/orc/pull/151#discussion_r132571311 --- Diff: c++/include/orc/Reader.hh --- @@ -288,6 +288,17 @@ namespace orc { virtual uint64_t getCompressionSize() const = 0; /** +

[GitHub] orc pull request #150: ORC-225 Fixed handling longs in CsvReader

2017-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/orc/pull/150 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] orc pull request #151: ORC-226 Support getWriterId in c++ reader interface

2017-08-10 Thread xndai
Github user xndai commented on a diff in the pull request: https://github.com/apache/orc/pull/151#discussion_r132589551 --- Diff: c++/include/orc/Reader.hh --- @@ -288,6 +288,17 @@ namespace orc { virtual uint64_t getCompressionSize() const = 0; /** +

[GitHub] orc pull request #152: ORC-227: [C++] Fix docker failure due to ExternalProj...

2017-08-10 Thread xndai
Github user xndai commented on a diff in the pull request: https://github.com/apache/orc/pull/152#discussion_r132522783 --- Diff: c++/src/ByteRLE.cc --- @@ -26,9 +26,9 @@ namespace orc { - const size_t MINIMUM_REPEAT = 3; - const size_t MAXIMUM_REPEAT =

[GitHub] orc pull request #152: ORC-227: [C++] Fix docker failure due to ExternalProj...

2017-08-10 Thread xndai
Github user xndai commented on a diff in the pull request: https://github.com/apache/orc/pull/152#discussion_r132531200 --- Diff: c++/src/ByteRLE.cc --- @@ -26,9 +26,9 @@ namespace orc { - const size_t MINIMUM_REPEAT = 3; - const size_t MAXIMUM_REPEAT =

[GitHub] orc pull request #152: ORC-227: [C++] Fix docker failure due to ExternalProj...

2017-08-10 Thread majetideepak
Github user majetideepak commented on a diff in the pull request: https://github.com/apache/orc/pull/152#discussion_r132529457 --- Diff: c++/src/ByteRLE.cc --- @@ -26,9 +26,9 @@ namespace orc { - const size_t MINIMUM_REPEAT = 3; - const size_t