[GitHub] orc issue #252: ORC-345 Create and use a new Decimal64StatisticsImpl on the ...

Github user omalley commented on the issue: https://github.com/apache/orc/pull/252 Ok, I update this pull request: * I changed updateDecimal64 to take a value and scale. * I check for more overflows in Decimal64ColumnStatisticsImpl. * I added a test that tests the new code.

[GitHub] orc pull request #263: ORC-357: [C++] Use orc::InputStream in getTimezoneByF...

GitHub user rip-nsk opened a pull request: https://github.com/apache/orc/pull/263 ORC-357: [C++] Use orc::InputStream in getTimezoneByFilename You can merge this pull request into a Git repository by running: $ git pull https://github.com/rip-nsk/orc _ORC-357 Alternatively

[jira] [Created] (ORC-357) Use orc::InputStream in getTimezoneByFilename

rip.nsk created ORC-357: --- Summary: Use orc::InputStream in getTimezoneByFilename Key: ORC-357 URL: https://issues.apache.org/jira/browse/ORC-357 Project: ORC Issue Type: Improvement

[GitHub] orc pull request #263: ORC-357: [C++] Use orc::InputStream in getTimezoneByF...

Github user rip-nsk commented on a diff in the pull request: https://github.com/apache/orc/pull/263#discussion_r185577344 --- Diff: c++/src/Timezone.cc --- @@ -698,40 +694,15 @@ namespace orc { if (itr != timezoneCache.end()) { return *(itr->second).get();

[GitHub] orc issue #249: [ORC-341] Support time zone as a parameter for Java reader a...

Github user jcamachor commented on the issue: https://github.com/apache/orc/pull/249 I have been testing the patch from Hive and everything seems to be working as expected. I have rebased the patch and merge both commits. Also, I had to extend my changes to the newly created

[GitHub] orc issue #252: ORC-345 Create and use a new Decimal64StatisticsImpl on the ...

Github user omalley commented on the issue: https://github.com/apache/orc/pull/252 Ok, with this and ORC-344, the difference in writing small vs large decimals to a null file system is huge: Benchmark (precision) Mode Cnt Score Error Units

[GitHub] orc pull request #252: ORC-345 Create and use a new Decimal64StatisticsImpl ...

Github user prasanthj commented on a diff in the pull request: https://github.com/apache/orc/pull/252#discussion_r185673866 --- Diff: java/bench/src/java/org/apache/orc/bench/DecimalBench.java --- @@ -0,0 +1,270 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] orc pull request #252: ORC-345 Create and use a new Decimal64StatisticsImpl ...

Github user prasanthj commented on a diff in the pull request: https://github.com/apache/orc/pull/252#discussion_r185673722 --- Diff: java/bench/src/java/org/apache/orc/bench/DecimalBench.java --- @@ -0,0 +1,270 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] orc pull request #249: [ORC-341] Support time zone as a parameter for Java r...

Github user wgtmac commented on a diff in the pull request: https://github.com/apache/orc/pull/249#discussion_r185691194 --- Diff: java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java --- @@ -990,6 +1007,10 @@ public void nextVector(ColumnVector previousVector,

[GitHub] orc pull request #249: [ORC-341] Support time zone as a parameter for Java r...

Github user wgtmac commented on a diff in the pull request: https://github.com/apache/orc/pull/249#discussion_r185690848 --- Diff: java/core/src/java/org/apache/orc/impl/writer/TimestampTreeWriter.java --- @@ -54,9 +57,20 @@ public TimestampTreeWriter(int columnId, if

[GitHub] orc pull request #249: [ORC-341] Support time zone as a parameter for Java r...

Github user wgtmac commented on a diff in the pull request: https://github.com/apache/orc/pull/249#discussion_r185691649 --- Diff: java/core/src/java/org/apache/orc/impl/writer/TimestampTreeWriter.java --- @@ -28,7 +28,9 @@ import org.apache.orc.impl.SerializationUtils;