[GitHub] orc issue #273: ORC-343 Enable C++ writer to support RleV2

2018-06-03 Thread majetideepak
Github user majetideepak commented on the issue: https://github.com/apache/orc/pull/273 The PR looks overall good to me apart from a minor change requested. This is an important patch to align the C++ and Java implementations. Thanks again for working on this! ---

[GitHub] orc issue #275: ORC-371: [C++] Disable Libhdfspp build when Cyrus SASL is no...

2018-06-03 Thread majetideepak
Github user majetideepak commented on the issue: https://github.com/apache/orc/pull/275 Since there is some investigation needed here, I am going to merge this patch. We can enable `NO_SASL` build in a later patch. Right now, this is causing a build failure by default. ---

[GitHub] orc pull request #273: ORC-343 Enable C++ writer to support RleV2

2018-06-03 Thread majetideepak
Github user majetideepak commented on a diff in the pull request: https://github.com/apache/orc/pull/273#discussion_r192593861 --- Diff: c++/src/RLEv2.hh --- @@ -25,13 +25,89 @@ #include +#define MIN_REPEAT 3 +#define HIST_LEN 32 namespace orc {

[GitHub] orc pull request #275: ORC-371: [C++] Disable Libhdfspp build when Cyrus SAS...

2018-06-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/orc/pull/275 ---

[GitHub] orc pull request #277: ORC-372: Enable valgrind for C++ travis-ci tests

2018-06-03 Thread majetideepak
GitHub user majetideepak opened a pull request: https://github.com/apache/orc/pull/277 ORC-372: Enable valgrind for C++ travis-ci tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/majetideepak/orc ORC-372 Alternatively you

[GitHub] orc pull request #278: ORC-251: Extend InStream and OutStream to support enc...

2018-06-03 Thread omalley
GitHub user omalley opened a pull request: https://github.com/apache/orc/pull/278 ORC-251: Extend InStream and OutStream to support encryption. This patch: * Adds a method to Codec to get the CompressionKind. * Creates StreamOptions for both InStream and OutStream to gather

[GitHub] orc issue #277: ORC-372: Enable valgrind for C++ travis-ci tests

2018-06-03 Thread majetideepak
Github user majetideepak commented on the issue: https://github.com/apache/orc/pull/277 There are indeed valgrind failures. I will push a followup patch to fix these. ---

[jira] [Created] (ORC-374) Possible to reduce size of release tarballs?

2018-06-03 Thread Wes McKinney (JIRA)
Wes McKinney created ORC-374: Summary: Possible to reduce size of release tarballs? Key: ORC-374 URL: https://issues.apache.org/jira/browse/ORC-374 Project: ORC Issue Type: Improvement

[GitHub] orc pull request #273: ORC-343 Enable C++ writer to support RleV2

2018-06-03 Thread yuruiz
Github user yuruiz commented on a diff in the pull request: https://github.com/apache/orc/pull/273#discussion_r192614780 --- Diff: c++/src/RLEv2.hh --- @@ -25,13 +25,89 @@ #include +#define MIN_REPEAT 3 +#define HIST_LEN 32 namespace orc {