[GitHub] orc pull request #278: ORC-251: Extend InStream and OutStream to support enc...

2018-07-12 Thread prasanthj
Github user prasanthj commented on a diff in the pull request: https://github.com/apache/orc/pull/278#discussion_r202190526 --- Diff: java/core/src/java/org/apache/orc/impl/writer/StreamOptions.java --- @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] orc pull request #278: ORC-251: Extend InStream and OutStream to support enc...

2018-07-12 Thread prasanthj
Github user prasanthj commented on a diff in the pull request: https://github.com/apache/orc/pull/278#discussion_r202147519 --- Diff: java/core/src/java/org/apache/orc/impl/InStream.java --- @@ -55,112 +60,137 @@ public long getStreamLength() { @Override public abstrac

[GitHub] orc pull request #278: ORC-251: Extend InStream and OutStream to support enc...

2018-07-12 Thread prasanthj
Github user prasanthj commented on a diff in the pull request: https://github.com/apache/orc/pull/278#discussion_r202187998 --- Diff: java/core/src/java/org/apache/orc/impl/InStream.java --- @@ -173,33 +203,208 @@ private static ByteBuffer allocateBuffer(int size, boolean isDirect)

[GitHub] orc pull request #278: ORC-251: Extend InStream and OutStream to support enc...

2018-07-12 Thread prasanthj
Github user prasanthj commented on a diff in the pull request: https://github.com/apache/orc/pull/278#discussion_r202181381 --- Diff: java/core/src/java/org/apache/orc/impl/CryptoUtils.java --- @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] orc pull request #278: ORC-251: Extend InStream and OutStream to support enc...

2018-07-12 Thread prasanthj
Github user prasanthj commented on a diff in the pull request: https://github.com/apache/orc/pull/278#discussion_r202144150 --- Diff: java/core/src/java/org/apache/orc/impl/InStream.java --- @@ -55,112 +60,137 @@ public long getStreamLength() { @Override public abstrac

[GitHub] orc pull request #278: ORC-251: Extend InStream and OutStream to support enc...

2018-07-12 Thread prasanthj
Github user prasanthj commented on a diff in the pull request: https://github.com/apache/orc/pull/278#discussion_r202188844 --- Diff: java/core/src/java/org/apache/orc/impl/InStream.java --- @@ -173,33 +203,208 @@ private static ByteBuffer allocateBuffer(int size, boolean isDirect)

[GitHub] orc pull request #278: ORC-251: Extend InStream and OutStream to support enc...

2018-07-12 Thread prasanthj
Github user prasanthj commented on a diff in the pull request: https://github.com/apache/orc/pull/278#discussion_r202189630 --- Diff: java/core/src/java/org/apache/orc/impl/InStream.java --- @@ -401,84 +596,149 @@ private String rangeString() { @Override public Str

[GitHub] orc pull request #278: ORC-251: Extend InStream and OutStream to support enc...

2018-07-12 Thread prasanthj
Github user prasanthj commented on a diff in the pull request: https://github.com/apache/orc/pull/278#discussion_r202146043 --- Diff: java/core/src/java/org/apache/orc/impl/InStream.java --- @@ -55,112 +60,137 @@ public long getStreamLength() { @Override public abstrac