[GitHub] orc issue #299: ORC-203 - Update StringStatistics to trim long strings to 10...

2018-09-05 Thread moresandeep
Github user moresandeep commented on the issue: https://github.com/apache/orc/pull/299 @omalley I updated the PR with the suggested changes, updated the WriterVersion and put back README. ---

[GitHub] orc issue #301: ORC-395: Support ZSTD in C++ writer/reader

2018-09-05 Thread majetideepak
Github user majetideepak commented on the issue: https://github.com/apache/orc/pull/301 @wgtmac thanks for these changes! I will take a look at both patches by end of tomorrow. ---

[GitHub] orc pull request #301: ORC-395: Support ZSTD in C++ writer/reader

2018-09-05 Thread xndai
Github user xndai commented on a diff in the pull request: https://github.com/apache/orc/pull/301#discussion_r215486619 --- Diff: c++/src/Compression.cc --- @@ -899,6 +907,166 @@ DIAGNOSTIC_POP return static_cast(result); } + /** + * Block

[GitHub] orc pull request #301: ORC-395: Support ZSTD in C++ writer/reader

2018-09-05 Thread xndai
Github user xndai commented on a diff in the pull request: https://github.com/apache/orc/pull/301#discussion_r215486726 --- Diff: c++/src/Compression.cc --- @@ -899,6 +907,166 @@ DIAGNOSTIC_POP return static_cast(result); } + /** + * Block