Github user asfgit closed the pull request at:
https://github.com/apache/orc/pull/128
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r131818378
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,228 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor l
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r131780673
--- Diff: c++/src/Vector.cc ---
@@ -35,6 +35,7 @@ namespace orc {
hasNulls(false),
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r131780548
--- Diff: c++/include/orc/Common.hh ---
@@ -27,6 +27,30 @@
#include
namespace orc {
+
+ class FileVersion {
--- End diff --
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r131780411
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,228 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor l
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r131780432
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,228 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor l
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r131780343
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,228 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor l
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r131780372
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,228 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor l
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r131738738
--- Diff: c++/src/ColumnWriter.cc ---
@@ -0,0 +1,507 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor l
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r131718481
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,228 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r131738380
--- Diff: c++/include/orc/Common.hh ---
@@ -27,6 +27,30 @@
#include
namespace orc {
+
+ class FileVersion {
--- End diff --
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r131718185
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,228 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r131739382
--- Diff: c++/src/Vector.cc ---
@@ -35,6 +35,7 @@ namespace orc {
hasNulls(false),
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r131718678
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,228 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r131717175
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,228 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r128647874
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor l
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r128647821
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor l
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r128626549
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor l
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r128392669
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor l
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r127855671
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r127855265
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r127854823
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r127853962
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124720147
--- Diff: c++/src/ColumnWriter.cc ---
@@ -0,0 +1,507 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor lic
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124720134
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor l
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124719817
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor l
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124718827
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor l
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124718523
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor l
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124718336
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor l
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124718320
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor l
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124715175
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor l
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124676106
--- Diff: c++/src/ColumnWriter.cc ---
@@ -0,0 +1,507 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor lic
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124667097
--- Diff: c++/src/ColumnWriter.cc ---
@@ -0,0 +1,507 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor l
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124665356
--- Diff: c++/src/ColumnWriter.cc ---
@@ -0,0 +1,507 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor l
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124654988
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124655754
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124655227
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124657688
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124656638
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124658015
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124657014
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124655397
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r120799267
--- Diff: c++/src/Writer.cc ---
@@ -0,0 +1,659 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license a
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r120751420
--- Diff: c++/src/Writer.cc ---
@@ -0,0 +1,659 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license a
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r120745645
--- Diff: c++/src/Writer.cc ---
@@ -0,0 +1,659 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor li
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r120739743
--- Diff: c++/src/Writer.cc ---
@@ -0,0 +1,659 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license a
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r120728928
--- Diff: c++/src/Writer.cc ---
@@ -0,0 +1,659 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor li
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r120729334
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contri
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r120708078
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor l
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r120706989
--- Diff: c++/src/Writer.cc ---
@@ -0,0 +1,659 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license a
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r120704852
--- Diff: c++/src/ColumnWriter.cc ---
@@ -0,0 +1,507 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor lic
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r120701079
--- Diff: c++/src/ColumnWriter.cc ---
@@ -0,0 +1,507 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor lic
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r120699358
--- Diff: c++/include/orc/OrcFile.hh ---
@@ -119,6 +120,17 @@ namespace orc {
* @param path the name of the file in the local file system
*/
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r120483146
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contri
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r120476831
--- Diff: c++/src/Writer.cc ---
@@ -0,0 +1,659 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor li
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r119640657
--- Diff: c++/include/orc/OrcFile.hh ---
@@ -119,6 +120,17 @@ namespace orc {
* @param path the name of the file in the local file system
*/
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r120458444
--- Diff: c++/src/ColumnWriter.cc ---
@@ -0,0 +1,507 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r119641608
--- Diff: c++/src/ColumnWriter.cc ---
@@ -0,0 +1,507 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r120458268
--- Diff: c++/src/ColumnWriter.cc ---
@@ -0,0 +1,507 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r120483772
--- Diff: c++/src/ColumnWriter.cc ---
@@ -0,0 +1,507 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
GitHub user xndai opened a pull request:
https://github.com/apache/orc/pull/128
ORC-178 Implement Basic C++ Writer and Writer Option
1. Add basic Writer and WriterOption
2. Add StructColumnWriter and IntegerColumnWriter. With them, we will be
able to write a complete ORC file
61 matches
Mail list logo
