[GitHub] orc pull request #249: [ORC-341] Support time zone as a parameter for Java r...

2018-05-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/orc/pull/249 ---

[GitHub] orc pull request #249: [ORC-341] Support time zone as a parameter for Java r...

2018-05-04 Thread omalley
Github user omalley commented on a diff in the pull request: https://github.com/apache/orc/pull/249#discussion_r186137062 --- Diff: java/core/src/java/org/apache/orc/impl/writer/WriterImplV2.java --- @@ -373,7 +379,11 @@ private void flushStripe() throws IOException { Or

[GitHub] orc pull request #249: [ORC-341] Support time zone as a parameter for Java r...

2018-05-04 Thread omalley
Github user omalley commented on a diff in the pull request: https://github.com/apache/orc/pull/249#discussion_r186133762 --- Diff: java/core/src/java/org/apache/orc/OrcFile.java --- @@ -320,6 +321,16 @@ public ReaderOptions fileMetadata(final FileMetadata metadata) { publ

[GitHub] orc pull request #249: [ORC-341] Support time zone as a parameter for Java r...

2018-05-04 Thread omalley
Github user omalley commented on a diff in the pull request: https://github.com/apache/orc/pull/249#discussion_r186134015 --- Diff: java/core/src/java/org/apache/orc/OrcFile.java --- @@ -320,6 +321,16 @@ public ReaderOptions fileMetadata(final FileMetadata metadata) { publ

[GitHub] orc pull request #249: [ORC-341] Support time zone as a parameter for Java r...

2018-05-04 Thread omalley
Github user omalley commented on a diff in the pull request: https://github.com/apache/orc/pull/249#discussion_r186134142 --- Diff: java/core/src/java/org/apache/orc/OrcFile.java --- @@ -761,6 +782,10 @@ public boolean getWriteVariableLengthBlocks() { public HadoopShims get

[GitHub] orc pull request #249: [ORC-341] Support time zone as a parameter for Java r...

2018-05-04 Thread omalley
Github user omalley commented on a diff in the pull request: https://github.com/apache/orc/pull/249#discussion_r186140770 --- Diff: java/core/src/java/org/apache/orc/impl/writer/TimestampTreeWriter.java --- @@ -54,9 +57,20 @@ public TimestampTreeWriter(int columnId, if (ro

[GitHub] orc pull request #249: [ORC-341] Support time zone as a parameter for Java r...

2018-05-02 Thread wgtmac
Github user wgtmac commented on a diff in the pull request: https://github.com/apache/orc/pull/249#discussion_r185690848 --- Diff: java/core/src/java/org/apache/orc/impl/writer/TimestampTreeWriter.java --- @@ -54,9 +57,20 @@ public TimestampTreeWriter(int columnId, if (row

[GitHub] orc pull request #249: [ORC-341] Support time zone as a parameter for Java r...

2018-05-02 Thread wgtmac
Github user wgtmac commented on a diff in the pull request: https://github.com/apache/orc/pull/249#discussion_r185691194 --- Diff: java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java --- @@ -990,6 +1007,10 @@ public void nextVector(ColumnVector previousVector, T

[GitHub] orc pull request #249: [ORC-341] Support time zone as a parameter for Java r...

2018-05-02 Thread wgtmac
Github user wgtmac commented on a diff in the pull request: https://github.com/apache/orc/pull/249#discussion_r185691649 --- Diff: java/core/src/java/org/apache/orc/impl/writer/TimestampTreeWriter.java --- @@ -28,7 +28,9 @@ import org.apache.orc.impl.SerializationUtils;

[GitHub] orc pull request #249: [ORC-341] Support time zone as a parameter for Java r...

2018-04-27 Thread jcamachor
Github user jcamachor commented on a diff in the pull request: https://github.com/apache/orc/pull/249#discussion_r184811998 --- Diff: java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java --- @@ -975,6 +992,8 @@ public void nextVector(ColumnVector previousVector,

[GitHub] orc pull request #249: [ORC-341] Support time zone as a parameter for Java r...

2018-04-27 Thread wgtmac
Github user wgtmac commented on a diff in the pull request: https://github.com/apache/orc/pull/249#discussion_r184807989 --- Diff: java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java --- @@ -975,6 +992,8 @@ public void nextVector(ColumnVector previousVector, Tim

[GitHub] orc pull request #249: [ORC-341] Support time zone as a parameter for Java r...

2018-04-14 Thread jcamachor
GitHub user jcamachor opened a pull request: https://github.com/apache/orc/pull/249 [ORC-341] Support time zone as a parameter for Java reader and writer You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcamachor/orc ORC-341 Alte