[GitHub] NisariAIT commented on issue #1578: goog.crypt.base64 not working after pagespeed is enabled
NisariAIT commented on issue #1578: goog.crypt.base64 not working after pagespeed is enabled URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1578#issuecomment-405476023 Yes @jmarantz, the script files are hosted by us. The deps.js file is not being called directly in the application. When goog.require is used, the deps.js file is called and this file uses the other JS files within the library to complete the process. I have resolved it by using the following directive: pagespeed Disallow "*js/MiscJS/*". This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] NisariAIT commented on issue #1578: goog.crypt.base64 not working after pagespeed is enabled
NisariAIT commented on issue #1578: goog.crypt.base64 not working after pagespeed is enabled URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1578#issuecomment-404740553 @jmarantz, I was not the one who compiled the JS closure libraries. I was given a set of js files that can be used in the web application directly(which I think must be because it was compiled with a closure compiler?). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] NisariAIT commented on issue #1578: goog.crypt.base64 not working after pagespeed is enabled
NisariAIT commented on issue #1578: goog.crypt.base64 not working after pagespeed is enabled URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1578#issuecomment-404510025 @jmarantz, How can I check if the script is using a compiler? The script is as below: goog.require('goog.crypt.base64'); This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] NisariAIT commented on issue #1578: goog.crypt.base64 not working after pagespeed is enabled
NisariAIT commented on issue #1578: goog.crypt.base64 not working after pagespeed is enabled URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1578#issuecomment-404426852 No @Lofesa. I have not enabled defer javascript. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] NisariAIT commented on issue #1578: goog.crypt.base64 not working after pagespeed is enabled
NisariAIT commented on issue #1578: goog.crypt.base64 not working after pagespeed is enabled URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1578#issuecomment-404139373 I added this: `pagespeed DisableFilters combine_javascript; ` after ``` pagespeed on; pagespeed HonorCsp on; ``` But I have the same error still. I am also getting this error in one other place: ![image](https://user-images.githubusercontent.com/36888737/42569195-5c659962-852d-11e8-9950-f9f5fcb7791c.png) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services