Re: Arrow 1404: Adding index for Page-level Skipping

2020-06-13 Thread Lekshmi Narayanan, Arun Balajiee
Hi Dev Thanks Wes for these comments. As Informed in other threads, I have completed most of it. Will try to structure it according to the comments. I had one question reading a (un)related matter. whenever we make calls to ReadBatch(int64_t batch_size, int16_t* def_levels,

[GitHub] [parquet-mr] ggershinsky commented on a change in pull request #615: PARQUET-1373: Encryption key tools

2020-06-13 Thread GitBox
ggershinsky commented on a change in pull request #615: URL: https://github.com/apache/parquet-mr/pull/615#discussion_r439793036 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/KeyToolkit.java ## @@ -0,0 +1,299 @@ +/* + * Licensed to the Apache

[jira] [Commented] (PARQUET-1373) Encryption key management tools

2020-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135039#comment-17135039 ] ASF GitHub Bot commented on PARQUET-1373: - ggershinsky commented on a change in pull request

[jira] [Commented] (PARQUET-1373) Encryption key management tools

2020-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135046#comment-17135046 ] ASF GitHub Bot commented on PARQUET-1373: - ggershinsky commented on a change in pull request

[GitHub] [parquet-mr] ggershinsky commented on a change in pull request #615: PARQUET-1373: Encryption key tools

2020-06-13 Thread GitBox
ggershinsky commented on a change in pull request #615: URL: https://github.com/apache/parquet-mr/pull/615#discussion_r439794717 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/FileKeyUnwrapper.java ## @@ -0,0 +1,216 @@ +/* + * Licensed to the