[GitHub] [parquet-mr] ggershinsky commented on a change in pull request #615: PARQUET-1373: Encryption key tools

2020-06-30 Thread GitBox
ggershinsky commented on a change in pull request #615: URL: https://github.com/apache/parquet-mr/pull/615#discussion_r447508660 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/KeyMaterial.java ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache

[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #615: PARQUET-1373: Encryption key tools

2020-06-30 Thread GitBox
gszadovszky commented on a change in pull request #615: URL: https://github.com/apache/parquet-mr/pull/615#discussion_r447562824 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/KeyMaterial.java ## @@ -0,0 +1,166 @@ +/* Review comment: In

[jira] [Commented] (PARQUET-1373) Encryption key management tools

2020-06-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148488#comment-17148488 ] ASF GitHub Bot commented on PARQUET-1373: - gszadovszky commented on a change in pull request

[jira] [Commented] (PARQUET-1373) Encryption key management tools

2020-06-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148485#comment-17148485 ] ASF GitHub Bot commented on PARQUET-1373: - gszadovszky commented on a change in pull request

[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #615: PARQUET-1373: Encryption key tools

2020-06-30 Thread GitBox
gszadovszky commented on a change in pull request #615: URL: https://github.com/apache/parquet-mr/pull/615#discussion_r447561609 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/KeyMaterial.java ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache

[jira] [Commented] (PARQUET-1373) Encryption key management tools

2020-06-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148442#comment-17148442 ] ASF GitHub Bot commented on PARQUET-1373: - ggershinsky commented on a change in pull request

[jira] [Commented] (PARQUET-1373) Encryption key management tools

2020-06-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148436#comment-17148436 ] ASF GitHub Bot commented on PARQUET-1373: - ggershinsky commented on a change in pull request

[GitHub] [parquet-mr] ggershinsky commented on a change in pull request #615: PARQUET-1373: Encryption key tools

2020-06-30 Thread GitBox
ggershinsky commented on a change in pull request #615: URL: https://github.com/apache/parquet-mr/pull/615#discussion_r447509073 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/PropertiesDrivenCryptoFactory.java ## @@ -36,38 +39,62 @@ import

[jira] [Commented] (PARQUET-1373) Encryption key management tools

2020-06-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148434#comment-17148434 ] ASF GitHub Bot commented on PARQUET-1373: - ggershinsky commented on a change in pull request

[jira] [Commented] (PARQUET-1373) Encryption key management tools

2020-06-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148437#comment-17148437 ] ASF GitHub Bot commented on PARQUET-1373: - ggershinsky commented on a change in pull request

[GitHub] [parquet-mr] ggershinsky commented on a change in pull request #615: PARQUET-1373: Encryption key tools

2020-06-30 Thread GitBox
ggershinsky commented on a change in pull request #615: URL: https://github.com/apache/parquet-mr/pull/615#discussion_r447508802 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/KeyMaterial.java ## @@ -0,0 +1,166 @@ +/* Review comment: >

[GitHub] [parquet-mr] gszadovszky merged pull request #799: Parquet-1872: Add TransCompression command to parquet-tools - Add theā€¦

2020-06-30 Thread GitBox
gszadovszky merged pull request #799: URL: https://github.com/apache/parquet-mr/pull/799 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [parquet-mr] ggershinsky commented on a change in pull request #615: PARQUET-1373: Encryption key tools

2020-06-30 Thread GitBox
ggershinsky commented on a change in pull request #615: URL: https://github.com/apache/parquet-mr/pull/615#discussion_r447508802 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/KeyMaterial.java ## @@ -0,0 +1,166 @@ +/* Review comment: >

Re: [DISCUSS] Ongoing LZ4 problems with Parquet files

2020-06-30 Thread Uwe L. Korn
I'm also in favor of disabling support for now. Having to deal with broken files or the detection of various incompatible implementations in the long-term will harm more than not supporting LZ4 for a while. Snappy is generally more used than LZ4 in this category as it has been available since