[jira] [Commented] (PARQUET-2052) Integer overflow when writing huge binary using dictionary encoding

2021-05-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351597#comment-17351597 ] ASF GitHub Bot commented on PARQUET-2052: - gszadovszky merged pull request #910: URL:

[GitHub] [parquet-mr] gszadovszky commented on pull request #910: PARQUET-2052: Integer overflow when writing huge binary using dictionary encoding

2021-05-26 Thread GitBox
gszadovszky commented on pull request #910: URL: https://github.com/apache/parquet-mr/pull/910#issuecomment-848545543 I agree, @sunchao that failing with a proper exception is always better than committing a corrupt file. Any issues might happen after the fallback should be handled in a

[GitHub] [parquet-mr] gszadovszky merged pull request #910: PARQUET-2052: Integer overflow when writing huge binary using dictionary encoding

2021-05-26 Thread GitBox
gszadovszky merged pull request #910: URL: https://github.com/apache/parquet-mr/pull/910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Resolved] (PARQUET-2052) Integer overflow when writing huge binary using dictionary encoding

2021-05-26 Thread Gabor Szadovszky (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Szadovszky resolved PARQUET-2052. --- Resolution: Fixed > Integer overflow when writing huge binary using dictionary

[jira] [Commented] (PARQUET-1633) Integer overflow in ParquetFileReader.ConsecutiveChunkList

2021-05-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351932#comment-17351932 ] ASF GitHub Bot commented on PARQUET-1633: - gszadovszky commented on pull request #902: URL:

[GitHub] [parquet-mr] gszadovszky commented on pull request #902: PARQUET-1633 Fix integer overflow

2021-05-26 Thread GitBox
gszadovszky commented on pull request #902: URL: https://github.com/apache/parquet-mr/pull/902#issuecomment-848941568 @eadwright, I've implemented a [unit test](https://github.com/gszadovszky/parquet-mr/commit/fcaf41269470c03c088b7eb5598558d44013f59d) to reproduce the issue and test your