[GitHub] [parquet-mr] shangxinli commented on pull request #962: Performance optimization to ByteBitPackingValuesReader

shangxinli commented on PR #962: URL: https://github.com/apache/parquet-mr/pull/962#issuecomment-1124443439 Can you add tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (PARQUET-2134) Incorrect type checking in HadoopStreams.wrap

[ https://issues.apache.org/jira/browse/PARQUET-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534948#comment-17534948 ] ASF GitHub Bot commented on PARQUET-2134: - shangxinli commented on PR #951: URL:

[GitHub] [parquet-mr] shangxinli commented on pull request #951: PARQUET-2134: Fix type checking in HadoopStreams.wrap

shangxinli commented on PR #951: URL: https://github.com/apache/parquet-mr/pull/951#issuecomment-1123901314 @7c00 Do you have time to look into the last feedback? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [parquet-mr] shangxinli merged pull request #955: PARQUET-2127: update jackson-databind to 2.13.2.2

shangxinli merged PR #955: URL: https://github.com/apache/parquet-mr/pull/955 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [parquet-mr] 7c00 commented on pull request #951: PARQUET-2134: Fix type checking in HadoopStreams.wrap

7c00 commented on PR #951: URL: https://github.com/apache/parquet-mr/pull/951#issuecomment-1123913274 > @7c00 Do you have time to look into the last feedback? @shangxinli Thanks for your comments. Sorry for late to reply. I think it's ok to add some unit tests, and I am going to do

[jira] [Commented] (PARQUET-2134) Incorrect type checking in HadoopStreams.wrap

[ https://issues.apache.org/jira/browse/PARQUET-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534953#comment-17534953 ] ASF GitHub Bot commented on PARQUET-2134: - 7c00 commented on PR #951: URL:

[GitHub] [parquet-mr] dependabot[bot] opened a new pull request, #964: Bump h2 from 1.4.193 to 2.1.210 in /parquet-column

dependabot[bot] opened a new pull request, #964: URL: https://github.com/apache/parquet-mr/pull/964 Bumps [h2](https://github.com/h2database/h2database) from 1.4.193 to 2.1.210. Release notes Sourced from https://github.com/h2database/h2database/releases;>h2's releases.

[GitHub] [parquet-mr] dependabot[bot] opened a new pull request, #965: Bump protobuf-java from 3.5.1 to 3.16.1 in /parquet-protobuf

dependabot[bot] opened a new pull request, #965: URL: https://github.com/apache/parquet-mr/pull/965 Bumps [protobuf-java](https://github.com/protocolbuffers/protobuf) from 3.5.1 to 3.16.1. Release notes Sourced from

[GitHub] [parquet-mr] dependabot[bot] opened a new pull request, #967: Bump commons-io from 2.4 to 2.7 in /parquet-cli

dependabot[bot] opened a new pull request, #967: URL: https://github.com/apache/parquet-mr/pull/967 Bumps commons-io from 2.4 to 2.7. [![Dependabot compatibility

[GitHub] [parquet-mr] dependabot[bot] opened a new pull request, #966: Bump commons-io from 2.4 to 2.7 in /parquet-hadoop

dependabot[bot] opened a new pull request, #966: URL: https://github.com/apache/parquet-mr/pull/966 Bumps commons-io from 2.4 to 2.7. [![Dependabot compatibility

[jira] [Commented] (PARQUET-2127) Security risk in latest parquet-jackson-1.12.2.jar

[ https://issues.apache.org/jira/browse/PARQUET-2127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534919#comment-17534919 ] ASF GitHub Bot commented on PARQUET-2127: - braiscouce commented on code in PR #955: URL:

[GitHub] [parquet-mr] braiscouce commented on a diff in pull request #955: PARQUET-2127: update jackson-databind to 2.13.2.2

braiscouce commented on code in PR #955: URL: https://github.com/apache/parquet-mr/pull/955#discussion_r870348560 ## pom.xml: ## @@ -73,7 +73,7 @@ com.fasterxml.jackson.core com.fasterxml.jackson 2.13.2 -${jackson.version} +2.13.2.2 Review Comment:

[jira] [Commented] (PARQUET-2069) Parquet file containing arrays, written by Parquet-MR, cannot be read again by Parquet-MR

[ https://issues.apache.org/jira/browse/PARQUET-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534977#comment-17534977 ] ASF GitHub Bot commented on PARQUET-2069: - shangxinli commented on PR #957: URL:

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #957: PARQUET-2069: Allow list and array record types to be compatible.

shangxinli commented on code in PR #957: URL: https://github.com/apache/parquet-mr/pull/957#discussion_r870479919 ## parquet-avro/src/main/java/org/apache/parquet/avro/AvroRecordConverter.java: ## @@ -866,6 +866,20 @@ static boolean isElementType(Type repeatedType, Schema

[GitHub] [parquet-mr] shangxinli commented on pull request #957: PARQUET-2069: Allow list and array record types to be compatible.

shangxinli commented on PR #957: URL: https://github.com/apache/parquet-mr/pull/957#issuecomment-1123948507 Can you add tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (PARQUET-2069) Parquet file containing arrays, written by Parquet-MR, cannot be read again by Parquet-MR

[ https://issues.apache.org/jira/browse/PARQUET-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534976#comment-17534976 ] ASF GitHub Bot commented on PARQUET-2069: - shangxinli commented on code in PR #957: URL:

[jira] [Commented] (PARQUET-2069) Parquet file containing arrays, written by Parquet-MR, cannot be read again by Parquet-MR

[ https://issues.apache.org/jira/browse/PARQUET-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534982#comment-17534982 ] ASF GitHub Bot commented on PARQUET-2069: - theosib-amazon commented on PR #957: URL:

[GitHub] [parquet-mr] theosib-amazon commented on pull request #957: PARQUET-2069: Allow list and array record types to be compatible.

theosib-amazon commented on PR #957: URL: https://github.com/apache/parquet-mr/pull/957#issuecomment-1123953964 I'm not sure how to add a whole new test. I'll see if I can figure it out. Also, the best way to test this would be to include the parquet file from the bug report, and I'm not

[GitHub] [parquet-mr] braiscouce commented on a diff in pull request #955: PARQUET-2127: update jackson-databind to 2.13.2.2

braiscouce commented on code in PR #955: URL: https://github.com/apache/parquet-mr/pull/955#discussion_r870348560 ## pom.xml: ## @@ -73,7 +73,7 @@ com.fasterxml.jackson.core com.fasterxml.jackson 2.13.2 -${jackson.version} +2.13.2.2 Review Comment:

[jira] [Commented] (PARQUET-2127) Security risk in latest parquet-jackson-1.12.2.jar

[ https://issues.apache.org/jira/browse/PARQUET-2127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534994#comment-17534994 ] ASF GitHub Bot commented on PARQUET-2127: - braiscouce commented on code in PR #955: URL: