[jira] [Created] (PARQUET-2154) ParquetFileReader should close its input stream when `filterRowGroups` throw Exception in constructor

2022-06-08 Thread Yang Jie (Jira)
Yang Jie created PARQUET-2154: - Summary: ParquetFileReader should close its input stream when `filterRowGroups` throw Exception in constructor Key: PARQUET-2154 URL: https://issues.apache.org/jira/browse/PARQUET-2154

[jira] [Updated] (PARQUET-2154) ParquetFileReader should close its input stream when `filterRowGroups` throw Exception in constructor

2022-06-08 Thread Yang Jie (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Jie updated PARQUET-2154: -- Description:   {code:java} public ParquetFileReader(InputFile file, ParquetReadOptions options) throw

[jira] [Commented] (PARQUET-2117) Add rowPosition API in parquet record readers

2022-06-08 Thread Prakhar Jain (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551740#comment-17551740 ] Prakhar Jain commented on PARQUET-2117: --- Resolving this issue as the PR is merged

[jira] [Resolved] (PARQUET-2117) Add rowPosition API in parquet record readers

2022-06-08 Thread Prakhar Jain (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prakhar Jain resolved PARQUET-2117. --- Fix Version/s: 1.12.3 (was: 1.13.0) Resolution: Fixed > Add r

Re: [VOTE] Release Apache Parquet 1.12.3 RC1

2022-06-08 Thread Prakhar Jain
Hi Team Is *Apache Parquet 1.12.3* already out? I didn't see any announcement/release notes around this but saw this thread in Apache Spark mentioning it has already been released - https://github.com/apache/spark/pull/36629#issuecomment-1139211125 . Also the commits referred by it

Re: [VOTE] Release Apache Parquet 1.12.3 RC1

2022-06-08 Thread Prakhar Jain
Also the commits referred by it are not the same as the RC candidate mentioned in the above email - https://github.com/apache/parquet-mr/blob/parquet-1.12.3/CHANGES.md . Correction: The commits seem to be the same. Ignore the pre

[GitHub] [parquet-mr] LuciferYang opened a new pull request, #972: PARQUET-2154: `ParquetFileReader` should close its input stream when `filterRowGroups` throw Exception in constructor

2022-06-08 Thread GitBox
LuciferYang opened a new pull request, #972: URL: https://github.com/apache/parquet-mr/pull/972 During the construction of `ParquetFileReader`, if `filterRowGroups(footer.getBlocks())` method throws an exception, it will cause resource leak because when the Exception thrown, the open stream

[jira] [Commented] (PARQUET-2154) ParquetFileReader should close its input stream when `filterRowGroups` throw Exception in constructor

2022-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551939#comment-17551939 ] ASF GitHub Bot commented on PARQUET-2154: - LuciferYang opened a new pull reques

[jira] [Commented] (PARQUET-2154) ParquetFileReader should close its input stream when `filterRowGroups` throw Exception in constructor

2022-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551944#comment-17551944 ] ASF GitHub Bot commented on PARQUET-2154: - LuciferYang commented on code in PR

[GitHub] [parquet-mr] LuciferYang commented on a diff in pull request #972: PARQUET-2154: `ParquetFileReader` should close its input stream when `filterRowGroups` throw Exception in constructor

2022-06-08 Thread GitBox
LuciferYang commented on code in PR #972: URL: https://github.com/apache/parquet-mr/pull/972#discussion_r893047755 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java: ## @@ -715,7 +715,14 @@ public ParquetFileReader(

[GitHub] [parquet-mr] LuciferYang commented on a diff in pull request #972: PARQUET-2154: `ParquetFileReader` should close its input stream when `filterRowGroups` throw Exception in constructor

2022-06-08 Thread GitBox
LuciferYang commented on code in PR #972: URL: https://github.com/apache/parquet-mr/pull/972#discussion_r893047755 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java: ## @@ -715,7 +715,14 @@ public ParquetFileReader(

[jira] [Commented] (PARQUET-2154) ParquetFileReader should close its input stream when `filterRowGroups` throw Exception in constructor

2022-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551945#comment-17551945 ] ASF GitHub Bot commented on PARQUET-2154: - LuciferYang commented on code in PR

[GitHub] [parquet-mr] ggershinsky commented on pull request #972: PARQUET-2154: `ParquetFileReader` should close its input stream when `filterRowGroups` throw Exception in constructor

2022-06-08 Thread GitBox
ggershinsky commented on PR #972: URL: https://github.com/apache/parquet-mr/pull/972#issuecomment-1150670630 yep, I've approved the CI run. Once complete, will merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (PARQUET-2154) ParquetFileReader should close its input stream when `filterRowGroups` throw Exception in constructor

2022-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551960#comment-17551960 ] ASF GitHub Bot commented on PARQUET-2154: - ggershinsky commented on PR #972: UR