[jira] [Commented] (PARQUET-2134) Incorrect type checking in HadoopStreams.wrap

[ https://issues.apache.org/jira/browse/PARQUET-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555809#comment-17555809 ] ASF GitHub Bot commented on PARQUET-2134: - shangxinli commented on code in PR #951: URL:

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #951: PARQUET-2134: Fix type checking in HadoopStreams.wrap

shangxinli commented on code in PR #951: URL: https://github.com/apache/parquet-mr/pull/951#discussion_r900676217 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/HadoopStreams.java: ## @@ -50,51 +46,45 @@ public class HadoopStreams { */ public static

[GitHub] [parquet-mr] shangxinli commented on pull request #975: PARQUET-2157: add bloom filter fpp config

shangxinli commented on PR #975: URL: https://github.com/apache/parquet-mr/pull/975#issuecomment-1159349333 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (PARQUET-2157) Add BloomFilter fpp config

[ https://issues.apache.org/jira/browse/PARQUET-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555817#comment-17555817 ] ASF GitHub Bot commented on PARQUET-2157: - shangxinli commented on PR #975: URL:

[jira] [Commented] (PARQUET-2157) Add BloomFilter fpp config

[ https://issues.apache.org/jira/browse/PARQUET-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555818#comment-17555818 ] ASF GitHub Bot commented on PARQUET-2157: - shangxinli merged PR #975: URL:

[GitHub] [parquet-mr] shangxinli merged pull request #975: PARQUET-2157: add bloom filter fpp config

shangxinli merged PR #975: URL: https://github.com/apache/parquet-mr/pull/975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (PARQUET-2138) Add ShowBloomFilterCommand to parquet-cli

[ https://issues.apache.org/jira/browse/PARQUET-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555814#comment-17555814 ] ASF GitHub Bot commented on PARQUET-2138: - shangxinli commented on PR #958: URL:

[GitHub] [parquet-mr] shangxinli commented on pull request #958: PARQUET-2138: Add ShowBloomFilterCommand to parquet-cli

shangxinli commented on PR #958: URL: https://github.com/apache/parquet-mr/pull/958#issuecomment-1159347960 @WangGuangxin Do you still plan to implement the decryption? I don't want to place a blocker if you don't have plan for it. -- This is an automated message from the Apache Git

[jira] [Commented] (PARQUET-2158) Upgrade Hadoop dependency to version 3.2.0

[ https://issues.apache.org/jira/browse/PARQUET-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555821#comment-17555821 ] ASF GitHub Bot commented on PARQUET-2158: - sunchao commented on code in PR #976: URL:

[jira] [Commented] (PARQUET-2158) Upgrade Hadoop dependency to version 3.2.0

[ https://issues.apache.org/jira/browse/PARQUET-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555820#comment-17555820 ] ASF GitHub Bot commented on PARQUET-2158: - sunchao commented on code in PR #976: URL:

[jira] [Commented] (PARQUET-2157) Add BloomFilter fpp config

[ https://issues.apache.org/jira/browse/PARQUET-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555826#comment-17555826 ] ASF GitHub Bot commented on PARQUET-2157: - huaxingao commented on PR #975: URL:

[GitHub] [parquet-mr] huaxingao commented on pull request #975: PARQUET-2157: add bloom filter fpp config

huaxingao commented on PR #975: URL: https://github.com/apache/parquet-mr/pull/975#issuecomment-1159354846 Thank you all very much! @chenjunjiedada @dongjoon-hyun @ggershinsky @shangxinli -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (PARQUET-2158) Upgrade Hadoop dependency to version 3.2.0

[ https://issues.apache.org/jira/browse/PARQUET-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555816#comment-17555816 ] ASF GitHub Bot commented on PARQUET-2158: - shangxinli commented on code in PR #976: URL:

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #976: PARQUET-2158: Upgrade Hadoop dependency to version 3.2.0

shangxinli commented on code in PR #976: URL: https://github.com/apache/parquet-mr/pull/976#discussion_r900688843 ## pom.xml: ## @@ -76,7 +76,7 @@ 2.13.2.2 0.14.2 shaded.parquet -2.10.1 +3.2.0 Review Comment: +1 for the question -- This is an

[jira] [Commented] (PARQUET-2150) parquet-protobuf to compile on mac M1

[ https://issues.apache.org/jira/browse/PARQUET-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555823#comment-17555823 ] ASF GitHub Bot commented on PARQUET-2150: - shangxinli commented on PR #970: URL:

[GitHub] [parquet-mr] shangxinli commented on pull request #970: PARQUET-2150: parquet-protobuf to compile on Mac M1

shangxinli commented on PR #970: URL: https://github.com/apache/parquet-mr/pull/970#issuecomment-1159351267 @sunchao I see your change is to upgrade the protobuf version. Is that required to solve this problem, which I don't see in this PR. -- This is an automated message from the

[GitHub] [parquet-mr] sunchao commented on a diff in pull request #976: PARQUET-2158: Upgrade Hadoop dependency to version 3.2.0

sunchao commented on code in PR #976: URL: https://github.com/apache/parquet-mr/pull/976#discussion_r900576817 ## pom.xml: ## @@ -76,7 +76,7 @@ 2.13.2.2 0.14.2 shaded.parquet -2.10.1 +3.2.0 Review Comment: hmm why 3.2.0, not 3.3.1/3.3.2? -- This

[jira] [Commented] (PARQUET-2158) Upgrade Hadoop dependency to version 3.2.0

[ https://issues.apache.org/jira/browse/PARQUET-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555790#comment-17555790 ] ASF GitHub Bot commented on PARQUET-2158: - sunchao commented on code in PR #976: URL:

[jira] [Commented] (PARQUET-2069) Parquet file containing arrays, written by Parquet-MR, cannot be read again by Parquet-MR

[ https://issues.apache.org/jira/browse/PARQUET-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555810#comment-17555810 ] ASF GitHub Bot commented on PARQUET-2069: - shangxinli commented on code in PR #957: URL:

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #957: PARQUET-2069: Allow list and array record types to be compatible.

shangxinli commented on code in PR #957: URL: https://github.com/apache/parquet-mr/pull/957#discussion_r900687175 ## parquet-avro/src/test/java/org/apache/parquet/avro/TestArrayListCompatibility.java: ## @@ -0,0 +1,51 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [parquet-mr] sunchao commented on a diff in pull request #976: PARQUET-2158: Upgrade Hadoop dependency to version 3.2.0

sunchao commented on code in PR #976: URL: https://github.com/apache/parquet-mr/pull/976#discussion_r900689594 ## parquet-thrift/src/main/java/org/apache/parquet/thrift/projection/deprecated/PathGlobPattern.java: ## @@ -20,8 +20,8 @@ import org.apache.hadoop.fs.GlobPattern;

[GitHub] [parquet-mr] sunchao commented on a diff in pull request #976: PARQUET-2158: Upgrade Hadoop dependency to version 3.2.0

sunchao commented on code in PR #976: URL: https://github.com/apache/parquet-mr/pull/976#discussion_r900689594 ## parquet-thrift/src/main/java/org/apache/parquet/thrift/projection/deprecated/PathGlobPattern.java: ## @@ -20,8 +20,8 @@ import org.apache.hadoop.fs.GlobPattern;

[jira] [Commented] (PARQUET-2069) Parquet file containing arrays, written by Parquet-MR, cannot be read again by Parquet-MR

[ https://issues.apache.org/jira/browse/PARQUET-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555811#comment-17555811 ] ASF GitHub Bot commented on PARQUET-2069: - shangxinli commented on code in PR #957: URL:

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #957: PARQUET-2069: Allow list and array record types to be compatible.

shangxinli commented on code in PR #957: URL: https://github.com/apache/parquet-mr/pull/957#discussion_r900687324 ## parquet-avro/src/main/java/org/apache/parquet/avro/AvroReadSupport.java: ## @@ -136,10 +137,22 @@ public RecordMaterializer prepareForRead( GenericData

[jira] [Commented] (PARQUET-2069) Parquet file containing arrays, written by Parquet-MR, cannot be read again by Parquet-MR

[ https://issues.apache.org/jira/browse/PARQUET-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555813#comment-17555813 ] ASF GitHub Bot commented on PARQUET-2069: - shangxinli commented on code in PR #957: URL:

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #957: PARQUET-2069: Allow list and array record types to be compatible.

shangxinli commented on code in PR #957: URL: https://github.com/apache/parquet-mr/pull/957#discussion_r900688194 ## parquet-avro/src/main/java/org/apache/parquet/avro/AvroReadSupport.java: ## @@ -136,10 +137,22 @@ public RecordMaterializer prepareForRead( GenericData