[GitHub] [parquet-mr] steveloughran commented on a diff in pull request #971: PARQUET-2134: Improve binding to ByteBufferReadable

2022-07-14 Thread GitBox
steveloughran commented on code in PR #971: URL: https://github.com/apache/parquet-mr/pull/971#discussion_r921124617 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/HadoopStreams.java: ## @@ -50,51 +46,45 @@ public class HadoopStreams { */ public static See

[jira] [Commented] (PARQUET-2134) Incorrect type checking in HadoopStreams.wrap

2022-07-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566825#comment-17566825 ] ASF GitHub Bot commented on PARQUET-2134: - steveloughran commented on code in P

[GitHub] [parquet-mr] steveloughran commented on a diff in pull request #971: PARQUET-2134: Improve binding to ByteBufferReadable

2022-07-14 Thread GitBox
steveloughran commented on code in PR #971: URL: https://github.com/apache/parquet-mr/pull/971#discussion_r921125471 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/HadoopStreams.java: ## @@ -50,51 +46,45 @@ public class HadoopStreams { */ public static See

[jira] [Commented] (PARQUET-2134) Incorrect type checking in HadoopStreams.wrap

2022-07-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566826#comment-17566826 ] ASF GitHub Bot commented on PARQUET-2134: - steveloughran commented on code in P

[GitHub] [parquet-mr] sunchao commented on a diff in pull request #971: PARQUET-2134: Improve binding to ByteBufferReadable

2022-07-14 Thread GitBox
sunchao commented on code in PR #971: URL: https://github.com/apache/parquet-mr/pull/971#discussion_r921361565 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/HadoopStreams.java: ## @@ -50,51 +46,45 @@ public class HadoopStreams { */ public static SeekableI

[jira] [Commented] (PARQUET-2134) Incorrect type checking in HadoopStreams.wrap

2022-07-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566915#comment-17566915 ] ASF GitHub Bot commented on PARQUET-2134: - sunchao commented on code in PR #971