[GitHub] [parquet-mr] jerolba commented on a diff in pull request #1035: PARQUET-2202: Review usage and implementation of Preconditions.checkargument method

2023-03-08 Thread via GitHub
jerolba commented on code in PR #1035: URL: https://github.com/apache/parquet-mr/pull/1035#discussion_r1129276294 ## parquet-column/src/main/java/org/apache/parquet/column/ParquetProperties.java: ## @@ -477,15 +477,15 @@ public Builder withMaxBloomFilterBytes(int

[jira] [Commented] (PARQUET-2202) Redundant String allocation on the hot path in CapacityByteArrayOutputStream.setByte

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697841#comment-17697841 ] ASF GitHub Bot commented on PARQUET-2202: - jerolba commented on code in PR #1035: URL:

[jira] [Commented] (PARQUET-2202) Redundant String allocation on the hot path in CapacityByteArrayOutputStream.setByte

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697843#comment-17697843 ] ASF GitHub Bot commented on PARQUET-2202: - jerolba commented on PR #1035: URL:

[GitHub] [parquet-mr] jerolba commented on a diff in pull request #1035: PARQUET-2202: Review usage and implementation of Preconditions.checkargument method

2023-03-08 Thread via GitHub
jerolba commented on code in PR #1035: URL: https://github.com/apache/parquet-mr/pull/1035#discussion_r1129277490 ## parquet-column/src/main/java/org/apache/parquet/column/ParquetProperties.java: ## @@ -477,15 +477,15 @@ public Builder withMaxBloomFilterBytes(int

[GitHub] [parquet-mr] jerolba commented on pull request #1035: PARQUET-2202: Review usage and implementation of Preconditions.checkargument method

2023-03-08 Thread via GitHub
jerolba commented on PR #1035: URL: https://github.com/apache/parquet-mr/pull/1035#issuecomment-1460008854 > Is the change exhaustive? Yes, I reviewed all calls to `checkArgument` to fix incorrect usage of %f and %d -- This is an automated message from the Apache Git Service. To

[GitHub] [parquet-mr] wgtmac commented on a diff in pull request #1035: PARQUET-2202: Review usage and implementation of Preconditions.checkargument method

2023-03-08 Thread via GitHub
wgtmac commented on code in PR #1035: URL: https://github.com/apache/parquet-mr/pull/1035#discussion_r1129335329 ## parquet-column/src/main/java/org/apache/parquet/column/ParquetProperties.java: ## @@ -477,15 +477,15 @@ public Builder withMaxBloomFilterBytes(int

[jira] [Commented] (PARQUET-2202) Redundant String allocation on the hot path in CapacityByteArrayOutputStream.setByte

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697840#comment-17697840 ] ASF GitHub Bot commented on PARQUET-2202: - jerolba commented on code in PR #1035: URL:

[jira] [Commented] (PARQUET-2202) Redundant String allocation on the hot path in CapacityByteArrayOutputStream.setByte

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697862#comment-17697862 ] ASF GitHub Bot commented on PARQUET-2202: - wgtmac commented on code in PR #1035: URL:

[jira] [Commented] (PARQUET-2254) Build a BloomFilter with a more precise size

2023-03-08 Thread Mars (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697987#comment-17697987 ] Mars commented on PARQUET-2254: --- [~wgtmac] [~gszadovszky] 1) This Jira is used to track the building of

[jira] [Assigned] (PARQUET-2237) Improve performance when filters in RowGroupFilter can match exactly

2023-03-08 Thread Mars (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mars reassigned PARQUET-2237: - Assignee: Mars > Improve performance when filters in RowGroupFilter can match exactly >

[jira] [Commented] (PARQUET-1889) Register a MIME type for the Parquet format.

2023-03-08 Thread Bryce Mecum (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698080#comment-17698080 ] Bryce Mecum commented on PARQUET-1889: -- It looks like a request to IANA to register

[jira] [Commented] (PARQUET-2228) ParquetRewriter supports more than one input file

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698051#comment-17698051 ] ASF GitHub Bot commented on PARQUET-2228: - vectorijk commented on code in PR #1026: URL:

[GitHub] [parquet-mr] vectorijk commented on a diff in pull request #1026: PARQUET-2228: ParquetRewriter supports more than one input file

2023-03-08 Thread via GitHub
vectorijk commented on code in PR #1026: URL: https://github.com/apache/parquet-mr/pull/1026#discussion_r1129917664 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/ParquetRewriter.java: ## @@ -183,12 +189,69 @@ public ParquetRewriter(TransParquetFileReader