[GitHub] [parquet-site] rdblue commented on issue #1: PARQUET-1674: The announcement email on the web site does not comply with ASF rules

2019-10-30 Thread GitBox
rdblue commented on issue #1: PARQUET-1674: The announcement email on the web site does not comply with ASF rules URL: https://github.com/apache/parquet-site/pull/1#issuecomment-547979893 Can you please update the description with what the policy is and what needed to be changed?

[GitHub] [parquet-site] gszadovszky opened a new pull request #1: PARQUET-1674: The announcement email on the web site does not comply with ASF rules

2019-10-30 Thread GitBox
gszadovszky opened a new pull request #1: PARQUET-1674: The announcement email on the web site does not comply with ASF rules URL: https://github.com/apache/parquet-site/pull/1 This is an automated message from the Apache

[GitHub] [parquet-site] zivanfi commented on a change in pull request #2: PARQUET-1687: Update release process

2019-11-12 Thread GitBox
zivanfi commented on a change in pull request #2: PARQUET-1687: Update release process URL: https://github.com/apache/parquet-site/pull/2#discussion_r345113629 ## File path: source/documentation/how-to-release.html.md ## @@ -68,7 +69,7 @@ Closing a staging repository

[GitHub] [parquet-site] zivanfi commented on a change in pull request #2: PARQUET-1687: Update release process

2019-11-12 Thread GitBox
zivanfi commented on a change in pull request #2: PARQUET-1687: Update release process URL: https://github.com/apache/parquet-site/pull/2#discussion_r345112821 ## File path: source/documentation/how-to-release.html.md ## @@ -90,24 +91,23 @@ Hi everyone, I propose the

[GitHub] [parquet-site] zivanfi commented on a change in pull request #2: PARQUET-1687: Update release process

2019-11-12 Thread GitBox
zivanfi commented on a change in pull request #2: PARQUET-1687: Update release process URL: https://github.com/apache/parquet-site/pull/2#discussion_r345112244 ## File path: source/documentation/how-to-release.html.md ## @@ -68,7 +69,7 @@ Closing a staging repository

[GitHub] [parquet-site] gszadovszky merged pull request #2: PARQUET-1687: Update release process

2019-11-12 Thread GitBox
gszadovszky merged pull request #2: PARQUET-1687: Update release process URL: https://github.com/apache/parquet-site/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [parquet-site] gszadovszky commented on a change in pull request #2: PARQUET-1687: Update release process

2019-11-12 Thread GitBox
gszadovszky commented on a change in pull request #2: PARQUET-1687: Update release process URL: https://github.com/apache/parquet-site/pull/2#discussion_r345209689 ## File path: source/documentation/how-to-release.html.md ## @@ -90,24 +91,23 @@ Hi everyone, I propose the

[GitHub] [parquet-site] rdblue commented on issue #1: PARQUET-1674: The announcement email on the web site does not comply with ASF rules

2019-11-06 Thread GitBox
rdblue commented on issue #1: PARQUET-1674: The announcement email on the web site does not comply with ASF rules URL: https://github.com/apache/parquet-site/pull/1#issuecomment-550450161 +1 This is an automated message from

[GitHub] [parquet-site] gszadovszky opened a new pull request #2: PARQUET-1687: Update release process

2019-11-05 Thread GitBox
gszadovszky opened a new pull request #2: PARQUET-1687: Update release process URL: https://github.com/apache/parquet-site/pull/2 Update the link of the keys file to the official one. The official link is required by the Apache release process. Update the usage of the prepare script

[GitHub] [parquet-site] gszadovszky merged pull request #1: PARQUET-1674: The announcement email on the web site does not comply with ASF rules

2019-11-07 Thread GitBox
gszadovszky merged pull request #1: PARQUET-1674: The announcement email on the web site does not comply with ASF rules URL: https://github.com/apache/parquet-site/pull/1 This is an automated message from the Apache Git

[GitHub] [parquet-site] gszadovszky commented on issue #1: PARQUET-1674: The announcement email on the web site does not comply with ASF rules

2019-10-31 Thread GitBox
gszadovszky commented on issue #1: PARQUET-1674: The announcement email on the web site does not comply with ASF rules URL: https://github.com/apache/parquet-site/pull/1#issuecomment-548245860 Added some notes about the apache requirements. More precise requirements and the related links

[GitHub] [parquet-site] gszadovszky commented on issue #1: PARQUET-1674: The announcement email on the web site does not comply with ASF rules

2019-11-04 Thread GitBox
gszadovszky commented on issue #1: PARQUET-1674: The announcement email on the web site does not comply with ASF rules URL: https://github.com/apache/parquet-site/pull/1#issuecomment-549264860 @rdblue, Could you please take a look?

[GitHub] [parquet-site] gszadovszky opened a new pull request #3: PARQUET-1811: Update download links

2020-03-05 Thread GitBox
gszadovszky opened a new pull request #3: PARQUET-1811: Update download links URL: https://github.com/apache/parquet-site/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [parquet-mr] brimzi commented on a change in pull request #775: PARQUET-1381: add parquet block merging feature

2020-04-20 Thread GitBox
brimzi commented on a change in pull request #775: URL: https://github.com/apache/parquet-mr/pull/775#discussion_r411696939 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/RowGroupMerger.java ## @@ -0,0 +1,634 @@ +/* + * Licensed to the Apache Software

[GitHub] [parquet-mr] brimzi commented on a change in pull request #775: PARQUET-1381: add parquet block merging feature

2020-04-20 Thread GitBox
brimzi commented on a change in pull request #775: URL: https://github.com/apache/parquet-mr/pull/775#discussion_r411741293 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java ## @@ -919,6 +895,59 @@ public void

[GitHub] [parquet-mr] brimzi commented on a change in pull request #775: PARQUET-1381: add parquet block merging feature

2020-04-20 Thread GitBox
brimzi commented on a change in pull request #775: URL: https://github.com/apache/parquet-mr/pull/775#discussion_r411711834 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/RowGroupMerger.java ## @@ -0,0 +1,634 @@ +/* Review comment: Same issue

[GitHub] [parquet-mr] brimzi commented on a change in pull request #775: PARQUET-1381: add parquet block merging feature

2020-04-20 Thread GitBox
brimzi commented on a change in pull request #775: URL: https://github.com/apache/parquet-mr/pull/775#discussion_r411708296 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/RowGroupMerger.java ## @@ -0,0 +1,634 @@ +/* + * Licensed to the Apache Software

[GitHub] [parquet-mr] brimzi commented on a change in pull request #775: PARQUET-1381: add parquet block merging feature

2020-04-20 Thread GitBox
brimzi commented on a change in pull request #775: URL: https://github.com/apache/parquet-mr/pull/775#discussion_r411711834 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/RowGroupMerger.java ## @@ -0,0 +1,634 @@ +/* Review comment: Same issue

[GitHub] [parquet-mr] brimzi commented on a change in pull request #775: PARQUET-1381: add parquet block merging feature

2020-04-20 Thread GitBox
brimzi commented on a change in pull request #775: URL: https://github.com/apache/parquet-mr/pull/775#discussion_r411692398 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/RowGroupMerger.java ## @@ -0,0 +1,634 @@ +/* + * Licensed to the Apache Software

[GitHub] [parquet-mr] ggershinsky commented on issue #776: PARQUET-1229: Parquet MR encryption

2020-04-21 Thread GitBox
ggershinsky commented on issue #776: URL: https://github.com/apache/parquet-mr/pull/776#issuecomment-617009069 > can you squash it to one single commit to make the review easier? This can be reviewed as a single commit at https://github.com/apache/parquet-mr/pull/776/files

[GitHub] [parquet-mr] ggershinsky commented on issue #776: PARQUET-1229: Parquet MR encryption

2020-04-21 Thread GitBox
ggershinsky commented on issue #776: URL: https://github.com/apache/parquet-mr/pull/776#issuecomment-617008320 preferably reviewed after the Travis fix is in. @gszadovszky @shangxinli can you apply #777 to the encryption branch.

[GitHub] [parquet-mr] chenjunjiedada opened a new pull request #788: PARQUET-1847: Filter out github notification from dev mail list

2020-04-21 Thread GitBox
chenjunjiedada opened a new pull request #788: URL: https://github.com/apache/parquet-mr/pull/788 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [parquet-mr] wesm commented on issue #788: PARQUET-1847: Filter out github notification from dev mail list

2020-04-21 Thread GitBox
wesm commented on issue #788: URL: https://github.com/apache/parquet-mr/pull/788#issuecomment-617166374 github@ doesn't exist for parquet.a.o so either this traffic should be directed to another mailing list, or a new one should be created. Pausing for a second, we should probably

[GitHub] [parquet-mr] chenjunjiedada edited a comment on issue #788: PARQUET-1847: Filter out github notification from dev mail list

2020-04-21 Thread GitBox
chenjunjiedada edited a comment on issue #788: URL: https://github.com/apache/parquet-mr/pull/788#issuecomment-617169461 Got it. Maybe we should list solutions and start a vote on dev. This is an automated message from the

[GitHub] [parquet-mr] chenjunjiedada commented on issue #788: PARQUET-1847: Filter out github notification from dev mail list

2020-04-21 Thread GitBox
chenjunjiedada commented on issue #788: URL: https://github.com/apache/parquet-mr/pull/788#issuecomment-617163785 @wesm, Could you please help to take a look? This is an automated message from the Apache Git Service. To

[GitHub] [parquet-mr] chenjunjiedada commented on issue #788: PARQUET-1847: Filter out github notification from dev mail list

2020-04-21 Thread GitBox
chenjunjiedada commented on issue #788: URL: https://github.com/apache/parquet-mr/pull/788#issuecomment-617169461 Got it. Maybe we need a vote to choose solutions. This is an automated message from the Apache Git Service. To

[GitHub] [parquet-mr] chenjunjiedada commented on issue #788: PARQUET-1847: Filter out github notification from dev mail list

2020-04-21 Thread GitBox
chenjunjiedada commented on issue #788: URL: https://github.com/apache/parquet-mr/pull/788#issuecomment-617173203 @wesm , I guess you are familiar with infra setup. Would you please help to list the options and start a vote thread for this?

[GitHub] [parquet-mr] gszadovszky commented on issue #787: PARQUET-1844: Eliminate using commons-lang

2020-04-21 Thread GitBox
gszadovszky commented on issue #787: URL: https://github.com/apache/parquet-mr/pull/787#issuecomment-617188187 @shangxinli, could you please check if you have some time? It is required for hadoop 3.3. This is an automated

[GitHub] [parquet-mr] gszadovszky opened a new pull request #787: PARQUET-1844: Eliminate using commons-lang

2020-04-21 Thread GitBox
gszadovszky opened a new pull request #787: URL: https://github.com/apache/parquet-mr/pull/787 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #775: PARQUET-1381: add parquet block merging feature

2020-04-19 Thread GitBox
shangxinli commented on a change in pull request #775: URL: https://github.com/apache/parquet-mr/pull/775#discussion_r411031080 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/RowGroupMerger.java ## @@ -0,0 +1,634 @@ +/* + * Licensed to the Apache

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #775: PARQUET-1381: add parquet block merging feature

2020-04-19 Thread GitBox
shangxinli commented on a change in pull request #775: URL: https://github.com/apache/parquet-mr/pull/775#discussion_r411031080 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/RowGroupMerger.java ## @@ -0,0 +1,634 @@ +/* + * Licensed to the Apache

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #775: PARQUET-1381: add parquet block merging feature

2020-04-19 Thread GitBox
shangxinli commented on a change in pull request #775: URL: https://github.com/apache/parquet-mr/pull/775#discussion_r411030497 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/RowGroupMerger.java ## @@ -0,0 +1,634 @@ +/* + * Licensed to the Apache

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #775: PARQUET-1381: add parquet block merging feature

2020-04-19 Thread GitBox
shangxinli commented on a change in pull request #775: URL: https://github.com/apache/parquet-mr/pull/775#discussion_r411026823 ## File path: parquet-tools/src/main/java/org/apache/parquet/tools/command/MergeCommand.java ## @@ -18,27 +18,37 @@ */ package

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #775: PARQUET-1381: add parquet block merging feature

2020-04-19 Thread GitBox
shangxinli commented on a change in pull request #775: URL: https://github.com/apache/parquet-mr/pull/775#discussion_r411033348 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/RowGroupMerger.java ## @@ -0,0 +1,634 @@ +/* + * Licensed to the Apache

[GitHub] [parquet-mr] bagipriyank opened a new pull request #786: PARQUET-1699: upgrade yetus to 0.12.0

2020-04-19 Thread GitBox
bagipriyank opened a new pull request #786: URL: https://github.com/apache/parquet-mr/pull/786 addresses [PARQUET-1699](https://issues.apache.org/jira/browse/PARQUET-1699) This is an automated message from the Apache Git

[GitHub] [parquet-mr] shangxinli commented on issue #776: PARQUET-1229: Parquet MR encryption

2020-04-20 Thread GitBox
shangxinli commented on issue #776: URL: https://github.com/apache/parquet-mr/pull/776#issuecomment-616599564 Is this ready to review? Since there is no comment yet, can you squash it to one single commit to make the review easier?

[GitHub] [parquet-site] shangxinli commented on a change in pull request #3: PARQUET-1811: Update download links

2020-03-15 Thread GitBox
shangxinli commented on a change in pull request #3: PARQUET-1811: Update download links URL: https://github.com/apache/parquet-site/pull/3#discussion_r392783564 ## File path: output/documentation/how-to-release/index.html ## @@ -210,7 +210,7 @@ 5. Send a VOTE e-mail to

[GitHub] [parquet-mr] ggershinsky commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

2020-04-27 Thread GitBox
ggershinsky commented on a change in pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#discussion_r415617873 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/crypto/AesCipher.java ## @@ -90,6 +102,10 @@ // Update last two bytes with new

[GitHub] [parquet-mr] ggershinsky commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

2020-04-27 Thread GitBox
ggershinsky commented on a change in pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#discussion_r415621398 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -463,14 +486,29 @@ ConvertedType

[GitHub] [parquet-mr] ggershinsky commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

2020-04-27 Thread GitBox
ggershinsky commented on a change in pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#discussion_r415622844 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -1185,70 +1275,189 @@ static

[GitHub] [parquet-mr] gszadovszky commented on pull request #776: PARQUET-1229: Parquet MR encryption

2020-04-27 Thread GitBox
gszadovszky commented on pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#issuecomment-619820989 > > preferably reviewed after the Travis fix is in. @gszadovszky @shangxinli can you apply #777 to the encryption branch. > > It seems I still don't have permission

[GitHub] [parquet-mr] srinivasst commented on pull request #789: PARQUET-1850: Fix dictionaryPageOffset flag setting in toParquetMetadata method

2020-04-27 Thread GitBox
srinivasst commented on pull request #789: URL: https://github.com/apache/parquet-mr/pull/789#issuecomment-619973869 @julienledem @rdblue @belugabehr please review this PR This is an automated message from the Apache Git

[GitHub] [parquet-mr] srinivasst opened a new pull request #789: PARQUET-1850: Fix dictionaryPageOffset flag setting in toParquetMetadata method

2020-04-27 Thread GitBox
srinivasst opened a new pull request #789: URL: https://github.com/apache/parquet-mr/pull/789 ### Issue toParquetMetadata method converts org.apache.parquet.hadoop.metadata.ParquetMetadata to org.apache.parquet.format.FileMetaData but this does not set the dictionary page offset

[GitHub] [parquet-mr] Fokko commented on pull request #741: PARQUET-1756: Remove Dependency on Maven Plugin semantic-versioning

2020-04-26 Thread GitBox
Fokko commented on pull request #741: URL: https://github.com/apache/parquet-mr/pull/741#issuecomment-619518995 @gszadovszky do you know if we still use this? This is an automated message from the Apache Git Service. To

[GitHub] [parquet-mr] bagipriyank commented on pull request #702: PARQUET-1684: dont store default protobuf values as null for proto3

2020-04-24 Thread GitBox
bagipriyank commented on pull request #702: URL: https://github.com/apache/parquet-mr/pull/702#issuecomment-619205704 how can i help to get some eyes on this pr? This is an automated message from the Apache Git Service. To

[GitHub] [parquet-mr] garawalid commented on a change in pull request #781: PARQUET-1826: Document Hadoop configuration options

2020-04-21 Thread GitBox
garawalid commented on a change in pull request #781: URL: https://github.com/apache/parquet-mr/pull/781#discussion_r412497639 ## File path: parquet-hadoop/README.md ## @@ -230,23 +236,28 @@ conf.set("parquet.bloom.filter.expected.ndv#column.path", 200) ## Class:

[GitHub] [parquet-mr] garawalid commented on a change in pull request #781: PARQUET-1826: Document Hadoop configuration options

2020-04-21 Thread GitBox
garawalid commented on a change in pull request #781: URL: https://github.com/apache/parquet-mr/pull/781#discussion_r412496194 ## File path: parquet-hadoop/README.md ## @@ -158,7 +164,7 @@ This property should be between 0 and 1. --- **Property:**

[GitHub] [parquet-mr] garawalid commented on a change in pull request #781: PARQUET-1826: Document Hadoop configuration options

2020-04-21 Thread GitBox
garawalid commented on a change in pull request #781: URL: https://github.com/apache/parquet-mr/pull/781#discussion_r412495171 ## File path: parquet-hadoop/README.md ## @@ -230,23 +236,28 @@ conf.set("parquet.bloom.filter.expected.ndv#column.path", 200) ## Class:

[GitHub] [parquet-mr] gszadovszky commented on issue #787: PARQUET-1844: Eliminate using commons-lang

2020-04-22 Thread GitBox
gszadovszky commented on issue #787: URL: https://github.com/apache/parquet-mr/pull/787#issuecomment-617603932 Thanks a lot, @shangxinli for the fast reply! This is an automated message from the Apache Git Service. To

[GitHub] [parquet-mr] garawalid commented on issue #781: PARQUET-1826: Document Hadoop configuration options

2020-04-22 Thread GitBox
garawalid commented on issue #781: URL: https://github.com/apache/parquet-mr/pull/781#issuecomment-617697630 Thanks @gszadovszky for reviewing this PR. This is an automated message from the Apache Git Service. To respond to

[GitHub] [parquet-mr] gszadovszky edited a comment on issue #781: PARQUET-1826: Document Hadoop configuration options

2020-04-22 Thread GitBox
gszadovszky edited a comment on issue #781: URL: https://github.com/apache/parquet-mr/pull/781#issuecomment-617721781 Thanks, @garawalid for working on it! :) This is an automated message from the Apache Git Service. To

[GitHub] [parquet-mr] gszadovszky commented on issue #781: PARQUET-1826: Document Hadoop configuration options

2020-04-22 Thread GitBox
gszadovszky commented on issue #781: URL: https://github.com/apache/parquet-mr/pull/781#issuecomment-617721781 Tanks, @garawalid for working on it! :) This is an automated message from the Apache Git Service. To respond to

[GitHub] [parquet-mr] ggershinsky commented on issue #776: PARQUET-1229: Parquet MR encryption

2020-04-22 Thread GitBox
ggershinsky commented on issue #776: URL: https://github.com/apache/parquet-mr/pull/776#issuecomment-617843400 the PR is ready for review This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [parquet-mr] patrickofriel-wk commented on issue #785: PARQUET-1842: Update jackson-databind version

2020-04-22 Thread GitBox
patrickofriel-wk commented on issue #785: URL: https://github.com/apache/parquet-mr/pull/785#issuecomment-617781539 Anything else you'd like me to do before merging this @Fokko ? This is an automated message from the Apache

[GitHub] [parquet-mr] dbtsai commented on pull request #671: PARQUET-1643 Use airlift codecs for LZ4, LZ0, GZIP

2020-04-30 Thread GitBox
dbtsai commented on pull request #671: URL: https://github.com/apache/parquet-mr/pull/671#issuecomment-622018995 @samarthjain thanks for the work. I am looking to deploy zstd parquet into prod, but that requires new hadoop with native library support which is not practical in many prod

[GitHub] [parquet-mr] rdblue commented on pull request #790: PARQUET-1853: Minimize shaded fastutil

2020-04-30 Thread GitBox
rdblue commented on pull request #790: URL: https://github.com/apache/parquet-mr/pull/790#issuecomment-622137193 Looks fine to me, but for 1.11.1 I wouldn't want to update fastutil. This is an automated message from the

[GitHub] [parquet-mr] Fokko opened a new pull request #790: PARQUET-1853: Minimize shaded fastutil

2020-04-30 Thread GitBox
Fokko opened a new pull request #790: URL: https://github.com/apache/parquet-mr/pull/790 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in

[GitHub] [parquet-mr] Fokko commented on pull request #790: PARQUET-1853: Minimize shaded fastutil

2020-05-02 Thread GitBox
Fokko commented on pull request #790: URL: https://github.com/apache/parquet-mr/pull/790#issuecomment-622831434 @rdblue I've checked, and it the `minimizeJar` was indeed the issue. This is an automated message from the

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #778: PARQUET-1827: UUID type currently not supported by parquet-mr

2020-05-02 Thread GitBox
shangxinli commented on a change in pull request #778: URL: https://github.com/apache/parquet-mr/pull/778#discussion_r418981845 ## File path: parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveStringifier.java ## @@ -421,4 +422,30 @@ private String

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #778: PARQUET-1827: UUID type currently not supported by parquet-mr

2020-05-02 Thread GitBox
shangxinli commented on a change in pull request #778: URL: https://github.com/apache/parquet-mr/pull/778#discussion_r418984184 ## File path: parquet-column/src/test/java/org/apache/parquet/schema/TestPrimitiveStringifier.java ## @@ -309,6 +308,35 @@ public void

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #778: PARQUET-1827: UUID type currently not supported by parquet-mr

2020-05-02 Thread GitBox
shangxinli commented on a change in pull request #778: URL: https://github.com/apache/parquet-mr/pull/778#discussion_r418985058 ## File path: parquet-avro/README.md ## @@ -0,0 +1,44 @@

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #778: PARQUET-1827: UUID type currently not supported by parquet-mr

2020-05-02 Thread GitBox
shangxinli commented on a change in pull request #778: URL: https://github.com/apache/parquet-mr/pull/778#discussion_r418987550 ## File path: parquet-avro/src/test/java/org/apache/parquet/avro/TestAvroSchemaConverter.java ## @@ -766,6 +768,33 @@ public void

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #778: PARQUET-1827: UUID type currently not supported by parquet-mr

2020-05-02 Thread GitBox
shangxinli commented on a change in pull request #778: URL: https://github.com/apache/parquet-mr/pull/778#discussion_r418980107 ## File path: parquet-column/src/main/java/org/apache/parquet/schema/LogicalTypeAnnotation.java ## @@ -861,6 +871,36 @@ PrimitiveStringifier

[GitHub] [parquet-mr] rdblue commented on pull request #790: PARQUET-1853: Minimize shaded fastutil

2020-05-02 Thread GitBox
rdblue commented on pull request #790: URL: https://github.com/apache/parquet-mr/pull/790#issuecomment-623023653 Thanks, @Fokko! This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #775: PARQUET-1381: add parquet block merging feature

2020-04-26 Thread GitBox
shangxinli commented on a change in pull request #775: URL: https://github.com/apache/parquet-mr/pull/775#discussion_r415418003 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java ## @@ -919,6 +895,59 @@ public void

[GitHub] [parquet-mr] shangxinli commented on pull request #776: PARQUET-1229: Parquet MR encryption

2020-04-26 Thread GitBox
shangxinli commented on pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#issuecomment-619640880 > preferably reviewed after the Travis fix is in. @gszadovszky @shangxinli can you apply #777 to the encryption branch. It seems I still don't have permission to do

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

2020-04-26 Thread GitBox
shangxinli commented on a change in pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#discussion_r415429416 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/crypto/AesCipher.java ## @@ -90,6 +102,10 @@ // Update last two bytes with new

[GitHub] [parquet-mr] prakharjain09 commented on a change in pull request #789: PARQUET-1850: Fix dictionaryPageOffset flag setting in toParquetMetadata method

2020-04-28 Thread GitBox
prakharjain09 commented on a change in pull request #789: URL: https://github.com/apache/parquet-mr/pull/789#discussion_r416463221 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -480,6 +480,10 @@ private void

[GitHub] [parquet-mr] Fokko commented on pull request #741: PARQUET-1756: Remove Dependency on Maven Plugin semantic-versioning

2020-04-28 Thread GitBox
Fokko commented on pull request #741: URL: https://github.com/apache/parquet-mr/pull/741#issuecomment-620428385 Thanks for the second pair of eyes @gszadovszky This is an automated message from the Apache Git Service. To

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

2020-04-26 Thread GitBox
shangxinli commented on a change in pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#discussion_r415440161 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -463,14 +486,29 @@ ConvertedType

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

2020-04-26 Thread GitBox
shangxinli commented on a change in pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#discussion_r415440161 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -463,14 +486,29 @@ ConvertedType

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

2020-04-26 Thread GitBox
shangxinli commented on a change in pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#discussion_r415444590 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -463,14 +486,29 @@ ConvertedType

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

2020-04-26 Thread GitBox
shangxinli commented on a change in pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#discussion_r415444590 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -463,14 +486,29 @@ ConvertedType

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

2020-04-26 Thread GitBox
shangxinli commented on a change in pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#discussion_r415444590 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -463,14 +486,29 @@ ConvertedType

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

2020-04-26 Thread GitBox
shangxinli commented on a change in pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#discussion_r415446216 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -1185,70 +1275,189 @@ static long

[GitHub] [parquet-mr] Fokko commented on issue #785: PARQUET-1842: Update jackson-databind version

2020-04-22 Thread GitBox
Fokko commented on issue #785: URL: https://github.com/apache/parquet-mr/pull/785#issuecomment-617963038 @patrickofriel-wk No nothing from your side. It is just common courtesy to wait a bit, so other committers/PMC can response, before merging. Thanks for your contribution

[GitHub] [parquet-mr] Fokko commented on issue #785: PARQUET-1842: Update jackson-databind version

2020-04-22 Thread GitBox
Fokko commented on issue #785: URL: https://github.com/apache/parquet-mr/pull/785#issuecomment-617985085 My pleasure @patrickofriel-wk This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [parquet-mr] patrickofriel-wk commented on issue #785: PARQUET-1842: Update jackson-databind version

2020-04-22 Thread GitBox
patrickofriel-wk commented on issue #785: URL: https://github.com/apache/parquet-mr/pull/785#issuecomment-617964290 Makes sense, thanks for the quick review @Fokko ! This is an automated message from the Apache Git Service.

[GitHub] [parquet-mr] Fokko commented on issue #783: java.lang.IllegalArgumentException: requirement failed: File segment length cannot be negative (got -307984865)

2020-04-22 Thread GitBox
Fokko commented on issue #783: URL: https://github.com/apache/parquet-mr/pull/783#issuecomment-617970615 Please provide a test case that will surface the issue, this PR doesn't give any meaningful information. This is an

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #778: PARQUET-1827: UUID type currently not supported by parquet-mr

2020-05-09 Thread GitBox
shangxinli commented on a change in pull request #778: URL: https://github.com/apache/parquet-mr/pull/778#discussion_r422563108 ## File path: parquet-avro/src/test/java/org/apache/parquet/avro/TestAvroSchemaConverter.java ## @@ -766,6 +768,33 @@ public void

[GitHub] [parquet-mr] shangxinli commented on pull request #776: PARQUET-1229: Parquet MR encryption

2020-05-09 Thread GitBox
shangxinli commented on pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#issuecomment-626266715 @ggershinsky Do you have time to review the code? This is an automated message from the Apache Git

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

2020-05-09 Thread GitBox
shangxinli commented on a change in pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#discussion_r422577368 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -463,14 +486,29 @@ ConvertedType

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #778: PARQUET-1827: UUID type currently not supported by parquet-mr

2020-05-09 Thread GitBox
shangxinli commented on a change in pull request #778: URL: https://github.com/apache/parquet-mr/pull/778#discussion_r422564200 ## File path: parquet-column/src/test/java/org/apache/parquet/schema/TestPrimitiveStringifier.java ## @@ -309,6 +308,35 @@ public void

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

2020-05-09 Thread GitBox
shangxinli commented on a change in pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#discussion_r422575326 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -1185,70 +1275,189 @@ static long

[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #778: PARQUET-1827: UUID type currently not supported by parquet-mr

2020-05-07 Thread GitBox
gszadovszky commented on a change in pull request #778: URL: https://github.com/apache/parquet-mr/pull/778#discussion_r421381112 ## File path: parquet-column/src/test/java/org/apache/parquet/schema/TestPrimitiveStringifier.java ## @@ -309,6 +308,35 @@ public void

[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #778: PARQUET-1827: UUID type currently not supported by parquet-mr

2020-05-07 Thread GitBox
gszadovszky commented on a change in pull request #778: URL: https://github.com/apache/parquet-mr/pull/778#discussion_r421368850 ## File path: parquet-column/src/main/java/org/apache/parquet/schema/LogicalTypeAnnotation.java ## @@ -861,6 +871,36 @@ PrimitiveStringifier

[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #778: PARQUET-1827: UUID type currently not supported by parquet-mr

2020-05-07 Thread GitBox
gszadovszky commented on a change in pull request #778: URL: https://github.com/apache/parquet-mr/pull/778#discussion_r421372389 ## File path: parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveStringifier.java ## @@ -421,4 +422,30 @@ private String

[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #778: PARQUET-1827: UUID type currently not supported by parquet-mr

2020-05-07 Thread GitBox
gszadovszky commented on a change in pull request #778: URL: https://github.com/apache/parquet-mr/pull/778#discussion_r421384119 ## File path: parquet-avro/README.md ## @@ -0,0 +1,44 @@

[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #778: PARQUET-1827: UUID type currently not supported by parquet-mr

2020-05-07 Thread GitBox
gszadovszky commented on a change in pull request #778: URL: https://github.com/apache/parquet-mr/pull/778#discussion_r421389575 ## File path: parquet-avro/src/test/java/org/apache/parquet/avro/TestAvroSchemaConverter.java ## @@ -766,6 +768,33 @@ public void

[GitHub] [parquet-format] a2un commented on a change in pull request #146: PARQUET-1630: Update Bloom filter format

2020-05-13 Thread GitBox
a2un commented on a change in pull request #146: URL: https://github.com/apache/parquet-format/pull/146#discussion_r424791329 ## File path: BloomFilter.md ## @@ -181,6 +182,9 @@ struct ColumnMetaData { ``` +The Bloom filter data is stored right after pages indexes, the

[GitHub] [parquet-format] a2un commented on a change in pull request #146: PARQUET-1630: Update Bloom filter format

2020-05-13 Thread GitBox
a2un commented on a change in pull request #146: URL: https://github.com/apache/parquet-format/pull/146#discussion_r424791329 ## File path: BloomFilter.md ## @@ -181,6 +182,9 @@ struct ColumnMetaData { ``` +The Bloom filter data is stored right after pages indexes, the

[GitHub] [parquet-format] a2un commented on a change in pull request #146: PARQUET-1630: Update Bloom filter format

2020-05-13 Thread GitBox
a2un commented on a change in pull request #146: URL: https://github.com/apache/parquet-format/pull/146#discussion_r424791329 ## File path: BloomFilter.md ## @@ -181,6 +182,9 @@ struct ColumnMetaData { ``` +The Bloom filter data is stored right after pages indexes, the

[GitHub] [parquet-format] Liam8 opened a new pull request #159: PARQUET-1862: fix comment mistake of DataPageHeaderV2

2020-05-14 Thread GitBox
Liam8 opened a new pull request #159: URL: https://github.com/apache/parquet-format/pull/159 Statistics in DataPageHeaderV2 should be about the page, not column chunk. Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Parquet

[GitHub] [parquet-mr] gszadovszky merged pull request #792: PARQUET-1863: Configure protoc-jar-maven-plugin to add generated sources to test sources path

2020-05-18 Thread GitBox
gszadovszky merged pull request #792: URL: https://github.com/apache/parquet-mr/pull/792 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [parquet-mr] cervebar commented on a change in pull request #620: PARQUET-1531: Page row count limit causes empty pages to be written from MessageColumnIO

2020-05-18 Thread GitBox
cervebar commented on a change in pull request #620: URL: https://github.com/apache/parquet-mr/pull/620#discussion_r426640001 ## File path: parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnWriterBase.java ## @@ -305,6 +305,9 @@ long getRowsWrittenSoFar() {

[GitHub] [parquet-mr] gszadovszky commented on pull request #777: PARQUET-1832: Travis fails with too long output

2020-05-19 Thread GitBox
gszadovszky commented on pull request #777: URL: https://github.com/apache/parquet-mr/pull/777#issuecomment-630712290 I don't know how/why this is reopened. Closing it as it is merged to master and encryption branch is rebased to it already.

[GitHub] [parquet-format] gszadovszky merged pull request #159: PARQUET-1862: fix comment mistake of DataPageHeaderV2

2020-05-14 Thread GitBox
gszadovszky merged pull request #159: URL: https://github.com/apache/parquet-format/pull/159 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [parquet-mr] laurentgo opened a new pull request #792: PARQUET-1863: Configure protoc-jar-maven-plugin to add generated sources to test sources path

2020-05-14 Thread GitBox
laurentgo opened a new pull request #792: URL: https://github.com/apache/parquet-mr/pull/792 By default, protoc-jar-maven-plugin adds generated source files into the main sources path but it can be configured to add them to the test sources path instead. Change the plugin

[GitHub] [parquet-format] a2un commented on a change in pull request #146: PARQUET-1630: Update Bloom filter format

2020-05-14 Thread GitBox
a2un commented on a change in pull request #146: URL: https://github.com/apache/parquet-format/pull/146#discussion_r424791329 ## File path: BloomFilter.md ## @@ -181,6 +182,9 @@ struct ColumnMetaData { ``` +The Bloom filter data is stored right after pages indexes, the

[GitHub] [parquet-mr] belugabehr commented on pull request #750: PARQUET-1775: Deprecate AvroParquetWriter Builder Hadoop Path

2020-05-07 Thread GitBox
belugabehr commented on pull request #750: URL: https://github.com/apache/parquet-mr/pull/750#issuecomment-625255839 @Fokko @ryanrupp Ready to merge this PR? Thanks! :) This is an automated message from the Apache Git

  1   2   3   4   >