Re: Inconsistent float/double sort order in spec and implementations can lead to incorrect results

2018-02-16 Thread Zoltan Borok-Nagy
I would just like to mention that the fmax() / fmin() functions in C/C++ Math library follow the aforementioned IEEE 754-2008 min and max specification: http://en.cppreference.com/w/c/numeric/math/fmax I think this behavior is also the most intuitive and useful regarding to statistics. If we want

Re: [VOTE] Release Apache Parquet C++ 1.4.0 RC0

2018-02-20 Thread Zoltan Borok-Nagy
Hi, I'm implementing the quick fix for Impala. The current proposal for the write path fix is to behave like the fmax()/fmin() functions in math.h, ie. ignore NaNs, except for the case when all the values are NaN. http://en.cppreference.com/w/c/numeric/math/fmax https://issues.apache.org/jira/bro

Re: [VOTE] Release Apache Parquet C++ 1.4.0 RC0

2018-02-21 Thread Zoltan Borok-Nagy
Deepak, just for clarification, does it mean that parquet-cpp will also write statistics when all the values are NaN? On Wed, Feb 21, 2018 at 1:16 PM, Deepak Majeti wrote: > I am okay with this proposed fix for Impala. > > On Tue, Feb 20, 2018 at 5:46 PM, Zoltan Borok-Nagy &l

Re: [VOTE] Release Apache Parquet C++ 1.4.0 RC0

2018-02-22 Thread Zoltan Borok-Nagy
OK, thanks! On Wed, Feb 21, 2018 at 7:33 PM, Deepak Majeti wrote: > Yes! The min/max will be set to NaN in the case when all the values are > NaN. > > On Wed, Feb 21, 2018 at 10:54 AM, Zoltan Borok-Nagy < > borokna...@cloudera.com > > wrote: > > > Deepak, jus

page and record boundaries

2018-07-12 Thread Zoltan Borok-Nagy
Hi everyone, Currently I am working on the implementation of the Parquet page index for Impala. (design doc is here if you are interested: https://docs.google.com/document/d/1D-el8njq_I-JKd3NDcW1mRXID_n0dBDKIkjWxwULVus/edit?usp=sharing ) During our discussions it came up that DataPageHeaderV2 sta

Re: page and record boundaries

2018-07-16 Thread Zoltan Borok-Nagy
> becomes desirable. And since indexes are a new feature, we can simply > implement them in a way so that we always do this alignment when writing > pages with indexes. > > Br, > > Zoltan > > On Thu, Jul 12, 2018 at 7:12 PM Zoltan Borok-Nagy > wrote: > > > Hi