[GitHub] [parquet-mr] shangxinli commented on pull request #970: PARQUET-2150: parquet-protobuf to compile on Mac M1

2022-07-02 Thread GitBox 


shangxinli commented on PR #970:
URL: https://github.com/apache/parquet-mr/pull/970#issuecomment-1172920665

   @steveloughran Thanks for the explanation!  Do you have concerns if we use 
[PR-973](https://github.com/apache/parquet-mr/pull/973)?  It seems we can rely 
on proto-buf itself to solve the issue.
   
   @sunchao please add @steveloughran as co-author for your PR. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [parquet-mr] shangxinli commented on pull request #970: PARQUET-2150: parquet-protobuf to compile on Mac M1

2022-06-17 Thread GitBox 


shangxinli commented on PR #970:
URL: https://github.com/apache/parquet-mr/pull/970#issuecomment-1159351267

   @sunchao I see your change is to upgrade the protobuf version. Is that 
required to solve this problem, which I don't see in this PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org