[GitHub] [parquet-mr] steveloughran commented on pull request #951: PARQUET-2134: Fix type checking in HadoopStreams.wrap
steveloughran commented on PR #951: URL: https://github.com/apache/parquet-mr/pull/951#issuecomment-1181629067 thanks. created [HADOOP-18336](https://issues.apache.org/jira/browse/HADOOP-18336) tag FSDataInputStream.getWrappedStream() @Public/@Stable to make sure that hadoop code knows external libs may be calling the method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [parquet-mr] steveloughran commented on pull request #951: PARQUET-2134: Fix type checking in HadoopStreams.wrap
steveloughran commented on PR #951: URL: https://github.com/apache/parquet-mr/pull/951#issuecomment-1153871066 whoever actually commits this can use the github squash option to combine all commits into one before merging. FYI, I've just started writing a shim library so that apps compiling against hadoop 3.2.0 wil be able to invoke the 3.3+ API calls when present: [HADOOP-18287](https://issues.apache.org/jira/browse/HADOOP-18287). First parquet will need to be able to compile/link against hadoop 3.x: #976 976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [parquet-mr] steveloughran commented on pull request #951: PARQUET-2134: Fix type checking in HadoopStreams.wrap
steveloughran commented on PR #951: URL: https://github.com/apache/parquet-mr/pull/951#issuecomment-1148538544 I've taken this PR and added the changes I was suggesting, plus tests. see #971. If you take that extra commit and merge it in here, it should complete this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
