[jira] [Commented] (PARQUET-2243) Support zstd-jni in DirectCodecFactory
[
https://issues.apache.org/jira/browse/PARQUET-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17692509#comment-17692509
]
ASF GitHub Bot commented on PARQUET-2243:
-
gszadovszky merged PR #1027:
URL: https://github.com/apache/parquet-mr/pull/1027
> Support zstd-jni in DirectCodecFactory
> --
>
> Key: PARQUET-2243
> URL: https://issues.apache.org/jira/browse/PARQUET-2243
> Project: Parquet
> Issue Type: Bug
>Reporter: Gabor Szadovszky
>Assignee: Gabor Szadovszky
>Priority: Major
>
> During switching to zstd-jni (from the Hadoop native zstd codec) we missed to
> add proper implementations for {{DirectCodecFactory}}. Currently, NPE occurs
> in case of the {{DirectCodecFactory}} is used while reading/writing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (PARQUET-2243) Support zstd-jni in DirectCodecFactory
[
https://issues.apache.org/jira/browse/PARQUET-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689600#comment-17689600
]
ASF GitHub Bot commented on PARQUET-2243:
-
gszadovszky commented on PR #1027:
URL: https://github.com/apache/parquet-mr/pull/1027#issuecomment-1432679571
Thank you @wgtmac for the review!
I'll push it tomorrow if are no objections.
> Support zstd-jni in DirectCodecFactory
> --
>
> Key: PARQUET-2243
> URL: https://issues.apache.org/jira/browse/PARQUET-2243
> Project: Parquet
> Issue Type: Bug
>Reporter: Gabor Szadovszky
>Assignee: Gabor Szadovszky
>Priority: Major
>
> During switching to zstd-jni (from the Hadoop native zstd codec) we missed to
> add proper implementations for {{DirectCodecFactory}}. Currently, NPE occurs
> in case of the {{DirectCodecFactory}} is used while reading/writing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (PARQUET-2243) Support zstd-jni in DirectCodecFactory
[
https://issues.apache.org/jira/browse/PARQUET-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689514#comment-17689514
]
ASF GitHub Bot commented on PARQUET-2243:
-
wgtmac commented on code in PR #1027:
URL: https://github.com/apache/parquet-mr/pull/1027#discussion_r1108004026
##
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/example/TestInputOutputFormat.java:
##
@@ -66,7 +66,8 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class TestInputOutputFormat {
+public class
+TestInputOutputFormat {
Review Comment:
Looking good on my side. Thanks @gszadovszky
> Support zstd-jni in DirectCodecFactory
> --
>
> Key: PARQUET-2243
> URL: https://issues.apache.org/jira/browse/PARQUET-2243
> Project: Parquet
> Issue Type: Bug
>Reporter: Gabor Szadovszky
>Assignee: Gabor Szadovszky
>Priority: Major
>
> During switching to zstd-jni (from the Hadoop native zstd codec) we missed to
> add proper implementations for {{DirectCodecFactory}}. Currently, NPE occurs
> in case of the {{DirectCodecFactory}} is used while reading/writing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (PARQUET-2243) Support zstd-jni in DirectCodecFactory
[
https://issues.apache.org/jira/browse/PARQUET-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689103#comment-17689103
]
ASF GitHub Bot commented on PARQUET-2243:
-
gszadovszky commented on code in PR #1027:
URL: https://github.com/apache/parquet-mr/pull/1027#discussion_r1107084792
##
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/example/TestInputOutputFormat.java:
##
@@ -66,7 +66,8 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class TestInputOutputFormat {
+public class
+TestInputOutputFormat {
Review Comment:
Yes, thanks for the noticing.
> Support zstd-jni in DirectCodecFactory
> --
>
> Key: PARQUET-2243
> URL: https://issues.apache.org/jira/browse/PARQUET-2243
> Project: Parquet
> Issue Type: Bug
>Reporter: Gabor Szadovszky
>Assignee: Gabor Szadovszky
>Priority: Major
>
> During switching to zstd-jni (from the Hadoop native zstd codec) we missed to
> add proper implementations for {{DirectCodecFactory}}. Currently, NPE occurs
> in case of the {{DirectCodecFactory}} is used while reading/writing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (PARQUET-2243) Support zstd-jni in DirectCodecFactory
[
https://issues.apache.org/jira/browse/PARQUET-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689062#comment-17689062
]
ASF GitHub Bot commented on PARQUET-2243:
-
wgtmac commented on code in PR #1027:
URL: https://github.com/apache/parquet-mr/pull/1027#discussion_r1107006966
##
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/example/TestInputOutputFormat.java:
##
@@ -66,7 +66,8 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class TestInputOutputFormat {
+public class
+TestInputOutputFormat {
Review Comment:
Modified by accident?
> Support zstd-jni in DirectCodecFactory
> --
>
> Key: PARQUET-2243
> URL: https://issues.apache.org/jira/browse/PARQUET-2243
> Project: Parquet
> Issue Type: Bug
>Reporter: Gabor Szadovszky
>Assignee: Gabor Szadovszky
>Priority: Major
>
> During switching to zstd-jni (from the Hadoop native zstd codec) we missed to
> add proper implementations for {{DirectCodecFactory}}. Currently, NPE occurs
> in case of the {{DirectCodecFactory}} is used while reading/writing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (PARQUET-2243) Support zstd-jni in DirectCodecFactory
[
https://issues.apache.org/jira/browse/PARQUET-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688932#comment-17688932
]
ASF GitHub Bot commented on PARQUET-2243:
-
gszadovszky opened a new pull request, #1027:
URL: https://github.com/apache/parquet-mr/pull/1027
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Parquet
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-2243
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Enabled executing
`parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestDirectCodecFactory`
for ZSTD encoding
### Commits
- [x] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
> Support zstd-jni in DirectCodecFactory
> --
>
> Key: PARQUET-2243
> URL: https://issues.apache.org/jira/browse/PARQUET-2243
> Project: Parquet
> Issue Type: Bug
>Reporter: Gabor Szadovszky
>Assignee: Gabor Szadovszky
>Priority: Major
>
> During switching to zstd-jni (from the Hadoop native zstd codec) we missed to
> add proper implementations for {{DirectCodecFactory}}. Currently, NPE occurs
> in case of the {{DirectCodecFactory}} is used while reading/writing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
