Re: [VOTE] Release Apache Parquet C++ 1.4.0 RC0

OK, thanks! On Wed, Feb 21, 2018 at 7:33 PM, Deepak Majeti wrote: > Yes! The min/max will be set to NaN in the case when all the values are > NaN. > > On Wed, Feb 21, 2018 at 10:54 AM, Zoltan Borok-Nagy < > borokna...@cloudera.com > > wrote: > > > Deepak, just for

Re: [VOTE] Release Apache Parquet C++ 1.4.0 RC0

Yes! The min/max will be set to NaN in the case when all the values are NaN. On Wed, Feb 21, 2018 at 10:54 AM, Zoltan Borok-Nagy wrote: > Deepak, just for clarification, does it mean that parquet-cpp will also > write statistics when all the values are NaN? > > > On

Re: [VOTE] Release Apache Parquet C++ 1.4.0 RC0

Deepak, just for clarification, does it mean that parquet-cpp will also write statistics when all the values are NaN? On Wed, Feb 21, 2018 at 1:16 PM, Deepak Majeti wrote: > I am okay with this proposed fix for Impala. > > On Tue, Feb 20, 2018 at 5:46 PM, Zoltan

Re: [VOTE] Release Apache Parquet C++ 1.4.0 RC0

I am okay with this proposed fix for Impala. On Tue, Feb 20, 2018 at 5:46 PM, Zoltan Borok-Nagy wrote: > Hi, > > I'm implementing the quick fix for Impala. The current proposal for the > write path fix is to behave like the fmax()/fmin() functions in math.h, ie. >

Re: [VOTE] Release Apache Parquet C++ 1.4.0 RC0

Hi, I'm implementing the quick fix for Impala. The current proposal for the write path fix is to behave like the fmax()/fmin() functions in math.h, ie. ignore NaNs, except for the case when all the values are NaN. http://en.cppreference.com/w/c/numeric/math/fmax

Re: [VOTE] Release Apache Parquet C++ 1.4.0 RC0

Due to the issues raised, I will close this RC and once all patches are merged, I will build a new one. Uwe On Tue, Feb 20, 2018, at 1:48 AM, Deepak Majeti wrote: > Wes, Zoltan, > > I am taking a look at the issue now. I will handle the patch for this one. > Thanks! > > On Tue, Feb 20, 2018

Re: [VOTE] Release Apache Parquet C++ 1.4.0 RC0

Wes, Zoltan, I am taking a look at the issue now. I will handle the patch for this one. Thanks! On Tue, Feb 20, 2018 at 12:54 AM, Wes McKinney wrote: > hi Zoltan -- my quick read is that one appropriate fix in parquet-cpp > would be to exclude NaN values from statistics

Re: [VOTE] Release Apache Parquet C++ 1.4.0 RC0

hi Zoltan -- my quick read is that one appropriate fix in parquet-cpp would be to exclude NaN values from statistics calculations (there is also the case that the whole row group is NaN for a column, in which case we should not write statistics perhaps?)? This might not take too long to fix in

Re: [VOTE] Release Apache Parquet C++ 1.4.0 RC0

Hi, I wonder whether the fix for PARQUET-1225 should be included in the next release, even if it causes a delay. Br, Zoltan On Sun, Feb 18, 2018 at 10:10 PM Uwe L. Korn wrote: > +1 (binding) > > verified on Ubuntu 16.04 >