Zardoz89 closed pull request #3: Fix pdfbox 4671
URL: https://github.com/apache/pdfbox-jbig2/pull/3
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Zardoz89 commented on issue #3: Fix pdfbox 4671
URL: https://github.com/apache/pdfbox-jbig2/pull/3#issuecomment-554333119
I close this PR, to do the changes mentioned here :
Zardoz89 opened a new pull request #3: Fix pdfbox 4671
URL: https://github.com/apache/pdfbox-jbig2/pull/3
Fixes https://issues.apache.org/jira/browse/PDFBOX-4671
Keeps being necessary to use [TwelveMomkeys
bsanchezb opened a new pull request #83:
URL: https://github.com/apache/pdfbox/pull/83
For the ticket : https://issues.apache.org/jira/browse/PDFBOX-4784
PDFBox should provide a possibility to define a deterministic AES
Initialization Vector.
If we use a default random case, it
asfgit closed pull request #7:
URL: https://github.com/apache/pdfbox/pull/7
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
asfgit closed pull request #41:
URL: https://github.com/apache/pdfbox/pull/41
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
asfgit closed pull request #23:
URL: https://github.com/apache/pdfbox/pull/23
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
asfgit closed pull request #38:
URL: https://github.com/apache/pdfbox/pull/38
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
asfgit closed pull request #6:
URL: https://github.com/apache/pdfbox/pull/6
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
asfgit closed pull request #74:
URL: https://github.com/apache/pdfbox/pull/74
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
asfgit closed pull request #4:
URL: https://github.com/apache/pdfbox/pull/4
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
asfgit closed pull request #83:
URL: https://github.com/apache/pdfbox/pull/83
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
asfgit closed pull request #35:
URL: https://github.com/apache/pdfbox/pull/35
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
asfgit closed pull request #2:
URL: https://github.com/apache/pdfbox/pull/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
asfgit closed pull request #8:
URL: https://github.com/apache/pdfbox/pull/8
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
asfgit closed pull request #5:
URL: https://github.com/apache/pdfbox/pull/5
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
asfgit closed pull request #60:
URL: https://github.com/apache/pdfbox/pull/60
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
asfgit closed pull request #36:
URL: https://github.com/apache/pdfbox/pull/36
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
asfgit closed pull request #24:
URL: https://github.com/apache/pdfbox/pull/24
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
THausherr commented on pull request #84:
URL: https://github.com/apache/pdfbox/pull/84#issuecomment-633201495
Hi, just as I wanted to add this, I realized that the example file you used
is about taking stuff from /Info and adding it to the XML metadata. So you
should either alter another
christianAppl opened a new pull request #86:
URL: https://github.com/apache/pdfbox/pull/86
This pull request is discussed in JIRA ticket:
https://issues.apache.org/jira/browse/PDFBOX-4952
I implemented a basic starting point to realize a PDF compression based on
PDFBox
lonely-development opened a new pull request #87:
URL: https://github.com/apache/pdfbox/pull/87
https://issues.apache.org/jira/browse/PDFBOX-4984
This is an automated message from the Apache Git Service.
To respond to the
msahyoun commented on pull request #78:
URL: https://github.com/apache/pdfbox/pull/78#issuecomment-709837493
@dannymcpherson the feature has been fixed in PDFBOX-3812 and release for
2.0.21 and 3.0.0 - can you close the request?
bibhas2 opened a new pull request #3:
URL: https://github.com/apache/pdfbox-docs/pull/3
The main change is that there is no need to call ``spp.setPermissions(ap);``
as the access permission object is already set in the constructor of
``StandardProtectionPolicy``.
The other changes
lehmi commented on pull request #3:
URL: https://github.com/apache/pdfbox-docs/pull/3#issuecomment-674414927
Thanks for the contribution
This is an automated message from the Apache Git Service.
To respond to the message,
lehmi merged pull request #3:
URL: https://github.com/apache/pdfbox-docs/pull/3
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
rafaelrenanpacheco commented on pull request #84:
URL: https://github.com/apache/pdfbox/pull/84#issuecomment-633529503
Hello @THausherr!
Makes sense, thanks for the feedback.
Best regards,
Rafael Pacheco.
rafaelrenanpacheco closed pull request #84:
URL: https://github.com/apache/pdfbox/pull/84
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
bsanchezb opened a new pull request #85:
URL: https://github.com/apache/pdfbox/pull/85
Fixed the unit test + javadoc
See : https://github.com/apache/pdfbox/pull/83
This is an automated message from the Apache Git
asfgit closed pull request #85:
URL: https://github.com/apache/pdfbox/pull/85
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
rafaelrenanpacheco opened a new pull request #84:
URL: https://github.com/apache/pdfbox/pull/84
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
SchwingSK commented on pull request #89:
URL: https://github.com/apache/pdfbox/pull/89#issuecomment-717151484
After testing with 14646 PDFs, I reduced the five-space rule down to only
one, as it gives even better results, and does not break more TestTextStripper
tests.
5 spaces: 965
SchwingSK edited a comment on pull request #89:
URL: https://github.com/apache/pdfbox/pull/89#issuecomment-717151484
After testing with 14646 PDFs, I reduced the five-space rule down to only
one (my feeling was wrong ;) ), as it gives even better results, and does not
break more
asfgit closed pull request #88:
URL: https://github.com/apache/pdfbox/pull/88
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
THausherr commented on pull request #88:
URL: https://github.com/apache/pdfbox/pull/88#issuecomment-713736767
You're right, and you're welcome. We're always looking to improve our test
coverage, thanks.
This is an automated
SchwingSK opened a new pull request #89:
URL: https://github.com/apache/pdfbox/pull/89
The problem lied with the fact that maxHeightForLine is kept, even when the
text font changes (which is intentional so as not to trigger a new line when
there is sub/superscript). This leads in this
asfgit closed pull request #87:
URL: https://github.com/apache/pdfbox/pull/87
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
THausherr commented on pull request #93:
URL: https://github.com/apache/pdfbox/pull/93#issuecomment-751316676
why squared?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
THausherr commented on pull request #82:
URL: https://github.com/apache/pdfbox/pull/82#issuecomment-751333491
I've now found this PR and attached it to
https://issues.apache.org/jira/browse/PDFBOX-5057
This is an
THausherr edited a comment on pull request #82:
URL: https://github.com/apache/pdfbox/pull/82#issuecomment-751333491
Thanks, I've now found this PR and attached it to
https://issues.apache.org/jira/browse/PDFBOX-5057
This
asfgit closed pull request #100:
URL: https://github.com/apache/pdfbox/pull/100
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
msahyoun commented on pull request #102:
URL: https://github.com/apache/pdfbox/pull/102#issuecomment-752061527
See https://infra.apache.org/github-actions-secrets.html
This is an automated message from the Apache Git
THausherr commented on pull request #102:
URL: https://github.com/apache/pdfbox/pull/102#issuecomment-752063239
"The ASF maxes out its runner allocation quite often, so a project needs to
plan carefully to make best use of them for everyone's sake."
So to me this looks as if "no,
lehmi edited a comment on pull request #102:
URL: https://github.com/apache/pdfbox/pull/102#issuecomment-752068241
IMHO it doesn't make that much sense as we don't use github as primary
repository, but as readonly mirror. So that those github actions are just
another tool to verify our
lehmi commented on pull request #102:
URL: https://github.com/apache/pdfbox/pull/102#issuecomment-752068241
IMHO it doesn't make that much sense as we don't use github as primary
repository, but as readonly mirror. So that those github actions are just
another tool to verify our builds
THausherr commented on pull request #102:
URL: https://github.com/apache/pdfbox/pull/102#issuecomment-752057238
Does this mean that each commit will trigger 8 builds, besides the Jenkins
builds and the github travis builds? And same for everybody who has forked the
project?
asfgit closed pull request #82:
URL: https://github.com/apache/pdfbox/pull/82
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
THausherr commented on pull request #82:
URL: https://github.com/apache/pdfbox/pull/82#issuecomment-751362340
Thank you for taking the time to merge your changes into our code!
This is an automated message from the Apache
THausherr commented on pull request #82:
URL: https://github.com/apache/pdfbox/pull/82#issuecomment-751366280
I made some additional changes based on the Sonar report
- check the length of the read bytes. I'm wondering whether it might happen
that a valid image has less than 20 bytes,
THausherr edited a comment on pull request #82:
URL: https://github.com/apache/pdfbox/pull/82#issuecomment-751366280
I made some additional changes based on the Sonar report
- check the length of the read bytes. I'm wondering whether it might happen
that a valid image has less than 20
cwholmes opened a new pull request #92:
URL: https://github.com/apache/pdfbox/pull/92
Addresses issue https://issues.apache.org/jira/browse/PDFBOX-5026
Rebuilding the trailer when the pages item is missing can allow the building
of the PDF when lenient parsing is enabled.
cwholmes opened a new pull request #91:
URL: https://github.com/apache/pdfbox/pull/91
Addresses issue https://issues.apache.org/jira/browse/PDFBOX-5025
Unreading the trailing 'e' from the endobject string allows parsing to
continue and complete as expected.
IntraCherche opened a new pull request #93:
URL: https://github.com/apache/pdfbox/pull/93
Size image involves w * h * scale squared
This is an automated message from the Apache Git Service.
To respond to the message, please
NekoCaffeine opened a new pull request #94:
URL: https://github.com/apache/pdfbox/pull/94
`LANGUGAE` -> `LANGUAGE`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
msahyoun commented on pull request #94:
URL: https://github.com/apache/pdfbox/pull/94#issuecomment-743155948
See https://issues.apache.org/jira/browse/PDFBOX-5040
This is an automated message from the Apache Git Service.
To
arturobernalg commented on pull request #99:
URL: https://github.com/apache/pdfbox/pull/99#issuecomment-750413911
Merged in Fork
This is an automated message from the Apache Git Service.
To respond to the message, please log
arturobernalg closed pull request #99:
URL: https://github.com/apache/pdfbox/pull/99
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
arturobernalg opened a new pull request #98:
URL: https://github.com/apache/pdfbox/pull/98
* Add final variables
* Field may be 'final'
This is an automated message from the Apache Git Service.
To respond to the message,
arturobernalg opened a new pull request #96:
URL: https://github.com/apache/pdfbox/pull/96
* Redundant modifiers on interfaces or interface component
* Use StandardCharset
* Unnecessary semicolon
* Field may be 'final'
arturobernalg opened a new pull request #97:
URL: https://github.com/apache/pdfbox/pull/97
* Add final variables
* Field may be 'final'
This is an automated message from the Apache Git Service.
To respond to the message,
rototor commented on pull request #95:
URL: https://github.com/apache/pdfbox/pull/95#issuecomment-749498208
@arturobernalg I don't want to disappoint you, but this project does not use
the GitHub PullRequests (They are ignored). Instead you should open a JIRA
Ticket at
arturobernalg closed pull request #97:
URL: https://github.com/apache/pdfbox/pull/97
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
arturobernalg opened a new pull request #95:
URL: https://github.com/apache/pdfbox/pull/95
* Add final
* Unnecessary semicolon ';'
* Remove Unnecessary interface modifier
* Remove Unnecessary semicolon
* Remove Unused import
* Use Standard Charset Object
* Change License
THausherr commented on pull request #95:
URL: https://github.com/apache/pdfbox/pull/95#issuecomment-749575961
@rototor ICLA is for bigger changes (like the ones you thankfully did), not
for small bugfixes and cleanups and code quality improvements. In the meantime
I committed most of his
arturobernalg closed pull request #98:
URL: https://github.com/apache/pdfbox/pull/98
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
arturobernalg closed pull request #96:
URL: https://github.com/apache/pdfbox/pull/96
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
arturobernalg commented on pull request #96:
URL: https://github.com/apache/pdfbox/pull/96#issuecomment-749578938
Implemented in Trunk branch
This is an automated message from the Apache Git Service.
To respond to the
arturobernalg commented on pull request #95:
URL: https://github.com/apache/pdfbox/pull/95#issuecomment-749578625
Thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
arturobernalg closed pull request #95:
URL: https://github.com/apache/pdfbox/pull/95
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
arturobernalg opened a new pull request #99:
URL: https://github.com/apache/pdfbox/pull/99
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
arturobernalg opened a new pull request #100:
URL: https://github.com/apache/pdfbox/pull/100
* class-top "final"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
asfgit closed pull request #94:
URL: https://github.com/apache/pdfbox/pull/94
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
asfgit closed pull request #89:
URL: https://github.com/apache/pdfbox/pull/89
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mikekap opened a new pull request #90:
URL: https://github.com/apache/pdfbox/pull/90
Double checked locking is generally a scary practice, so I explicitly added
a new field in these cases. It might also help with some optimizations around
actually using the colorSpace object.
Deee92 opened a new pull request #88:
URL: https://github.com/apache/pdfbox/pull/88
Hello,
I noticed with mutation testing that the behavior of
asfgit closed pull request #90:
URL: https://github.com/apache/pdfbox/pull/90
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
koppor opened a new pull request #102:
URL: https://github.com/apache/pdfbox/pull/102
This PR adds a [GitHub workflow](https://github.com/features/actions) to
enable checks from all JDKs from version 8 to 15.
The output of GitHub actions is better integrated in GitHub. Furthermore,
koppor opened a new pull request #101:
URL: https://github.com/apache/pdfbox/pull/101
This fixes https://issues.apache.org/jira/browse/PDFBOX-5061
Jakarta EE 9 is finally there:
https://blogs.eclipse.org/post/mike-milinkovich/jakarta-ee-9-delivers-big-bang.
The package name
koppor opened a new pull request #4:
URL: https://github.com/apache/pdfbox-docs/pull/4
It seems that colons (`:`) are used to seperate the issue number from the
commit message. I added this to the howto.
This is an
asfgit closed pull request #4:
URL: https://github.com/apache/pdfbox-docs/pull/4
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
asfgit closed pull request #101:
URL: https://github.com/apache/pdfbox/pull/101
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
msahyoun commented on pull request #101:
URL: https://github.com/apache/pdfbox/pull/101#issuecomment-752510319
@koppor we are looking to replace with java.time instead of the suggested
jakarta.xml component.
This is an
asfgit closed pull request #93:
URL: https://github.com/apache/pdfbox/pull/93
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
THausherr closed pull request #103:
URL: https://github.com/apache/pdfbox/pull/103
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
THausherr commented on pull request #103:
URL: https://github.com/apache/pdfbox/pull/103#issuecomment-752918965
It's the missing ZapfDingbats font. I'll see whether it's possible to use
AFM instead. If not, then I'll abort with a more useful error message.
THausherr opened a new pull request #103:
URL: https://github.com/apache/pdfbox/pull/103
This is just to test on github. I'll create a JIRA issue if needed.
This is an automated message from the Apache Git Service.
To
IntraCherche edited a comment on pull request #93:
URL: https://github.com/apache/pdfbox/pull/93#issuecomment-752859592
Because the code checks `if ((long) widthPx * (long) heightPx >
Integer.MAX_VALUE)` and `widthPx` and `heightPx` are defined as
`int widthPx = (int)
IntraCherche commented on pull request #93:
URL: https://github.com/apache/pdfbox/pull/93#issuecomment-752859592
Because the code checks `if ((long) widthPx * (long) heightPx >
Integer.MAX_VALUE)` and `widthPx` and `heightPx` are defined as
`int widthPx = (int)
THausherr commented on pull request #93:
URL: https://github.com/apache/pdfbox/pull/93#issuecomment-752884006
Of course
Good observation!
This is an automated message from the Apache Git Service.
To respond to the
THausherr opened a new pull request #5:
URL: https://github.com/apache/pdfbox-docs/pull/5
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
koppor closed pull request #102:
URL: https://github.com/apache/pdfbox/pull/102
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
koppor commented on pull request #102:
URL: https://github.com/apache/pdfbox/pull/102#issuecomment-753023028
OK, got it. I just wanted to make an offer to replace Travis CI. I see ASF
having the same limitations as Eclipse Foundation, which I just forgot. Sorry
for the noise.
valerybokov commented on pull request #107:
URL: https://github.com/apache/pdfbox/pull/107#issuecomment-860922327
HorizontalMetricsTable. Line 56. Typo in the exception message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
THausherr commented on pull request #107:
URL: https://github.com/apache/pdfbox/pull/107#issuecomment-861149415
Thanks, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
valerybokov edited a comment on pull request #107:
URL: https://github.com/apache/pdfbox/pull/107#issuecomment-856119473
> Your code removes all after 0 and including this 0, but that is different
to what the current code does. We don't need this at this time.
Your code does the
THausherr commented on pull request #107:
URL: https://github.com/apache/pdfbox/pull/107#issuecomment-856120740
Oops, you're right. Gotta think about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
THausherr commented on pull request #107:
URL: https://github.com/apache/pdfbox/pull/107#issuecomment-856111219
Your code removes all after 0 and including this 0, but that is different to
what the current code does. We don't need this at this time.
--
This is an automated message from
valerybokov edited a comment on pull request #107:
URL: https://github.com/apache/pdfbox/pull/107#issuecomment-856119473
> Your code removes all after 0 and including this 0, but that is different
to what the current code does. We don't need this at this time.
Your code does the
valerybokov commented on pull request #107:
URL: https://github.com/apache/pdfbox/pull/107#issuecomment-856119473
> Your code removes all after 0 and including this 0, but that is different
to what the current code does. We don't need this at this time.
Your code does the same:
valerybokov commented on pull request #107:
URL: https://github.com/apache/pdfbox/pull/107#issuecomment-864370716
> Isn't the "put" line all that is needed? (and the "remove" line isn't?)
Yes. The "put" is all that needed.
--
This is an automated message from the Apache Git
1 - 100 of 762 matches
Mail list logo
