[GitHub] pdfbox-jbig2 pull request #1: fix a memory leak in the cache
Github user grigoriy closed the pull request at: https://github.com/apache/pdfbox-jbig2/pull/1 --- - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[GitHub] pdfbox-jbig2 pull request #1: fix a memory leak in the cache
Github user hennejg commented on a diff in the pull request: https://github.com/apache/pdfbox-jbig2/pull/1#discussion_r209574636 --- Diff: pom.xml --- @@ -220,14 +220,19 @@ https://git-wip-us.apache.org/repos/asf?p=pdfbox-jbig2.git HEAD - + - - junit - junit - 4.10 - test - + +junit +junit +4.10 +test + + +com.google.guava --- End diff -- I am not so sure that it is fine to just add a dependency on Guava here. Why nox fix the existing Implementation by adding weak keys? --- - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[GitHub] pdfbox-jbig2 pull request #1: fix a memory leak in the cache
GitHub user grigoriy opened a pull request: https://github.com/apache/pdfbox-jbig2/pull/1 fix a memory leak in the cache Please see https://github.com/levigo/jbig2-imageio/issues/53. I added a test which had been failing before this fix. You can merge this pull request into a Git repository by running: $ git pull https://github.com/grigoriy/pdfbox-jbig2 cache-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/pdfbox-jbig2/pull/1.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1 commit 1795ee9a91123506d05351b590f4ce117b2f17de Author: Grigoriy Alekseev Date: 2018-08-10T17:09:31Z fix a memory leak in the cache --- - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
