[jira] [Comment Edited] (PDFBOX-2852) Improve code quality (2)

2017-04-25 Thread simon steiner (JIRA) 

[ 
https://issues.apache.org/jira/browse/PDFBOX-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982930#comment-15982930
 ] 

simon steiner edited comment on PDFBOX-2852 at 4/25/17 2:56 PM:


Rather than changing the code manually to jdk7 syntax, why not use intellij 
inspect code to do it for you

https://www.jetbrains.com/help/idea/2017.1/running-inspections.html


was (Author: ssteiner1):
Rather than changing the code manually to jdk7 syntax, why not use intellij 
inspect code to do it for you

> Improve code quality (2)
> 
>
> Key: PDFBOX-2852
> URL: https://issues.apache.org/jira/browse/PDFBOX-2852
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.0
>Reporter: Tilman Hausherr
> Attachments: explicit_array_creation.patch, fix_javadoc.patch, 
> foreach2.patch, foreach.patch, generic_type_arguments.patch, noarray.patch, 
> PDNameTreeNode.java.patch, semicolon.patch, StringBuffer.patch, 
> stringbuilder.patch, unnecessary_type_casting.patch, unused_imports.patch, 
> usestatic.patch, winansiencoding2.patch, winansiencoding.patch, 
> XMPSchema.java.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2576, which was getting too long.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Comment Edited] (PDFBOX-2852) Improve code quality (2)

2016-09-16 Thread John Hewson (JIRA) 

[ 
https://issues.apache.org/jira/browse/PDFBOX-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15497163#comment-15497163
 ] 

John Hewson edited comment on PDFBOX-2852 at 9/16/16 7:30 PM:
--

Yeah, pretty much. We have more important things to be working on. The 
preference is definitely not to use COSArrayList, because it's very rarely used 
already.

As I said, it's not a good abstraction. The purpose of the PD model is to 
abstract over the COS model but by handing out lists that are directly backed 
by COS objects we fail to achieve that goal. Indeed, in many cases we might be 
better off not using lists at all.


was (Author: jahewson):
Yeah, pretty much. We have more important things to be working on. The 
preference is definitely not to use COSArrayList, because it's very rarely used 
already.

As I said, it's not a good abstraction. The purpose of the PD model is to 
abstract over the COS model but by handing out lists that are directly backed 
by COS objects we fail to achieve that goal.

> Improve code quality (2)
> 
>
> Key: PDFBOX-2852
> URL: https://issues.apache.org/jira/browse/PDFBOX-2852
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.0
>Reporter: Tilman Hausherr
> Attachments: PDNameTreeNode.java.patch, XMPSchema.java.patch, 
> explicit_array_creation.patch, fix_javadoc.patch, foreach.patch, 
> noarray.patch, semicolon.patch, stringbuilder.patch, 
> unnecessary_type_casting.patch, unused_imports.patch, usestatic.patch, 
> winansiencoding.patch, winansiencoding2.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2576, which was getting too long.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Comment Edited] (PDFBOX-2852) Improve code quality (2)

2016-09-11 Thread Lorenz Pahl (JIRA) 

[ 
https://issues.apache.org/jira/browse/PDFBOX-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15480324#comment-15480324
 ] 

Lorenz Pahl edited comment on PDFBOX-2852 at 9/11/16 10:12 AM:
---

remove unnecessary type casting and type arguments

Oh, I forgot to remove an import for org.apache.pdfbox.cos.COSDictionary in 
org.apache.pdfbox.preflight.font.TrueTypeFontValidator.java, sorry.


was (Author: lorenz pahl):
remove unnecessary type casting and type arguments

> Improve code quality (2)
> 
>
> Key: PDFBOX-2852
> URL: https://issues.apache.org/jira/browse/PDFBOX-2852
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.0
>Reporter: Tilman Hausherr
> Attachments: PDNameTreeNode.java.patch, XMPSchema.java.patch, 
> explicit_array_creation.patch, fix_javadoc.patch, foreach.patch, 
> semicolon.patch, stringbuilder.patch, unnecessary_type_casting.patch, 
> unused_imports.patch, winansiencoding.patch, winansiencoding2.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2576, which was getting too long.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Comment Edited] (PDFBOX-2852) Improve code quality (2)

2016-01-03 Thread John Hewson (JIRA) 

[ 
https://issues.apache.org/jira/browse/PDFBOX-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15080546#comment-15080546
 ] 

John Hewson edited comment on PDFBOX-2852 at 1/3/16 10:14 PM:
--

Do be aware that Java's {{Character}} class is a UTF-16 character, so it can 
only represent code points inside the BMP. A two-character String is necessary 
to represent all Unicode code points.


was (Author: jahewson):
Do be aware that Java's {{Character}} class is a UTF-16 character, so it can 
only represent code point inside the BMP. A two-character String is necessary 
to represent all Unicode code points.

> Improve code quality (2)
> 
>
> Key: PDFBOX-2852
> URL: https://issues.apache.org/jira/browse/PDFBOX-2852
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.0
>Reporter: Tilman Hausherr
> Attachments: winansiencoding.patch, winansiencoding2.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2576, which was getting too long.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org