[jira] [Commented] (PDFBOX-1990) Support creating PDF from lossless encoded images
[ https://issues.apache.org/jira/browse/PDFBOX-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944328#comment-13944328 ] Tilman Hausherr commented on PDFBOX-1990: - I enabled the grayscale part in rev. 1580443 thanks to the the fix of PDFBOX-1993 and PDFBOX-1955. Support creating PDF from lossless encoded images - Key: PDFBOX-1990 URL: https://issues.apache.org/jira/browse/PDFBOX-1990 Project: PDFBox Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Tilman Hausherr Priority: Minor Currently we support the insertion of TIFF and JPEG into a PDF, but not PNG. We can pass a BufferedImage, but this one will be JPEG compressed which is not a good thing for graphics with sharp edges. I suggest that we support PNG as well. It is possible because the Flate Filter supports both directions. My implementation (coming in a few minutes) is just an RGB based start that begs for improvement. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (PDFBOX-1990) Support creating PDF from lossless encoded images
[ https://issues.apache.org/jira/browse/PDFBOX-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13943292#comment-13943292 ] Tilman Hausherr commented on PDFBOX-1990: - I added writing bitonal and grayscale images as single color samples and improved the unit test in rev 1579990. I replaced the test image with one with some color. I had to disable the 256 grayscale part due to a bug for which I fill file a separate issue. Support creating PDF from lossless encoded images - Key: PDFBOX-1990 URL: https://issues.apache.org/jira/browse/PDFBOX-1990 Project: PDFBox Issue Type: Improvement Reporter: Tilman Hausherr Priority: Minor Currently we support the insertion of TIFF and JPEG into a PDF, but not PNG. We can pass a BufferedImage, but this one will be JPEG compressed which is not a good thing for graphics with sharp edges. I suggest that we support PNG as well. It is possible because the Flate Filter supports both directions. My implementation (coming in a few minutes) is just an RGB based start that begs for improvement. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (PDFBOX-1990) Support creating PDF from lossless encoded images
[ https://issues.apache.org/jira/browse/PDFBOX-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13942229#comment-13942229 ] Tilman Hausherr commented on PDFBOX-1990: - I added a solution for extracting the alpha part of ARGB image, improved tests, some refactoring per DRY, in rev 1579729. Support creating PDF from lossless encoded images - Key: PDFBOX-1990 URL: https://issues.apache.org/jira/browse/PDFBOX-1990 Project: PDFBox Issue Type: Improvement Reporter: Tilman Hausherr Priority: Minor Currently we support the insertion of TIFF and JPEG into a PDF, but not PNG. We can pass a BufferedImage, but this one will be JPEG compressed which is not a good thing for graphics with sharp edges. I suggest that we support PNG as well. It is possible because the Flate Filter supports both directions. My implementation (coming in a few minutes) is just an RGB based start that begs for improvement. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (PDFBOX-1990) Support creating PDF from lossless encoded images
[ https://issues.apache.org/jira/browse/PDFBOX-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13939325#comment-13939325 ] Tilman Hausherr commented on PDFBOX-1990: - NullOutputStream optimized for speed in rev 1578940. Support creating PDF from lossless encoded images - Key: PDFBOX-1990 URL: https://issues.apache.org/jira/browse/PDFBOX-1990 Project: PDFBox Issue Type: Improvement Reporter: Tilman Hausherr Priority: Minor Currently we support the insertion of TIFF and JPEG into a PDF, but not PNG. We can pass a BufferedImage, but this one will be JPEG compressed which is not a good thing for graphics with sharp edges. I suggest that we support PNG as well. It is possible because the Flate Filter supports both directions. My implementation (coming in a few minutes) is just an RGB based start that begs for improvement. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (PDFBOX-1990) Support creating PDF from lossless encoded images
[
https://issues.apache.org/jira/browse/PDFBOX-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13939626#comment-13939626
]
John Hewson commented on PDFBOX-1990:
-
This looks good, a couple of random thoughts:
1) The static factory method doesn't need the word Lossless in it, because
it's already in the factory name:
{code}
LosslessFactory.createLosslessFromImage(...)
{code}
vs.
{code}
LosslessFactory.createFromImage(...)
{code}
2) When naming variables for parameters in the public API, prefer short words
over abbreviations, e.g.
{code}
BufferedImage bim --- BufferedImage image
{code}
Also, if a local variable name is already a short word, prefer not abbreviating
it:
{code}
Color co --- Color color
{code}
:)
Support creating PDF from lossless encoded images
-
Key: PDFBOX-1990
URL: https://issues.apache.org/jira/browse/PDFBOX-1990
Project: PDFBox
Issue Type: Improvement
Reporter: Tilman Hausherr
Priority: Minor
Currently we support the insertion of TIFF and JPEG into a PDF, but not PNG.
We can pass a BufferedImage, but this one will be JPEG compressed which is
not a good thing for graphics with sharp edges. I suggest that we support PNG
as well. It is possible because the Flate Filter supports both directions.
My implementation (coming in a few minutes) is just an RGB based start that
begs for improvement.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (PDFBOX-1990) Support creating PDF from lossless encoded images
[ https://issues.apache.org/jira/browse/PDFBOX-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13939884#comment-13939884 ] Tilman Hausherr commented on PDFBOX-1990: - Done as suggested in rev 1579073 and 1579074. Support creating PDF from lossless encoded images - Key: PDFBOX-1990 URL: https://issues.apache.org/jira/browse/PDFBOX-1990 Project: PDFBox Issue Type: Improvement Reporter: Tilman Hausherr Priority: Minor Currently we support the insertion of TIFF and JPEG into a PDF, but not PNG. We can pass a BufferedImage, but this one will be JPEG compressed which is not a good thing for graphics with sharp edges. I suggest that we support PNG as well. It is possible because the Flate Filter supports both directions. My implementation (coming in a few minutes) is just an RGB based start that begs for improvement. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (PDFBOX-1990) Support creating PDF from lossless encoded images
[ https://issues.apache.org/jira/browse/PDFBOX-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13938188#comment-13938188 ] Tilman Hausherr commented on PDFBOX-1990: - Done in rev 1578489 and 1578492 and 1578503. I also added a NullOutputStream. Support creating PDF from lossless encoded images - Key: PDFBOX-1990 URL: https://issues.apache.org/jira/browse/PDFBOX-1990 Project: PDFBox Issue Type: Improvement Reporter: Tilman Hausherr Priority: Minor Currently we support the insertion of TIFF and JPEG into a PDF, but not PNG. We can pass a BufferedImage, but this one will be JPEG compressed which is not a good thing for graphics with sharp edges. I suggest that we support PNG as well. It is possible because the Flate Filter supports both directions. My implementation (coming in a few minutes) is just an RGB based start that begs for improvement. -- This message was sent by Atlassian JIRA (v6.2#6252)
