[jira] [Commented] (PDFBOX-4158) COSDocument and PDFMerger may not close all IO resources if closing of one fails

2018-04-09 Thread Gary Potagal (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430445#comment-16430445 ] Gary Potagal commented on PDFBOX-4158: -- Yes, we completed testing Friday and are no longer seeing a

[jira] [Commented] (PDFBOX-4158) COSDocument and PDFMerger may not close all IO resources if closing of one fails

2018-04-07 Thread Maruan Sahyoun (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429438#comment-16429438 ] Maruan Sahyoun commented on PDFBOX-4158: [~gary.potagal] did you find the time for further

[jira] [Commented] (PDFBOX-4158) COSDocument and PDFMerger may not close all IO resources if closing of one fails

2018-03-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418759#comment-16418759 ] ASF subversion and git services commented on PDFBOX-4158: - Commit 1827975 from

[jira] [Commented] (PDFBOX-4158) COSDocument and PDFMerger may not close all IO resources if closing of one fails

2018-03-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418760#comment-16418760 ] ASF subversion and git services commented on PDFBOX-4158: - Commit 1827976 from

[jira] [Commented] (PDFBOX-4158) COSDocument and PDFMerger may not close all IO resources if closing of one fails

2018-03-28 Thread Gary Potagal (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417321#comment-16417321 ] Gary Potagal commented on PDFBOX-4158: -- [~msahyoun] - what about not having a nested try\{ } on line

[jira] [Commented] (PDFBOX-4158) COSDocument and PDFMerger may not close all IO resources if closing of one fails

2018-03-28 Thread Maruan Sahyoun (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416992#comment-16416992 ] Maruan Sahyoun commented on PDFBOX-4158: I'll do another change later today or tomorrow which is

[jira] [Commented] (PDFBOX-4158) COSDocument and PDFMerger may not close all IO resources if closing of one fails

2018-03-27 Thread Gary Potagal (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416109#comment-16416109 ] Gary Potagal commented on PDFBOX-4158: -- [~msahyoun] - this is much cleaner - will copy your changes

[jira] [Commented] (PDFBOX-4158) COSDocument and PDFMerger may not close all IO resources if closing of one fails

2018-03-27 Thread Maruan Sahyoun (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416029#comment-16416029 ] Maruan Sahyoun commented on PDFBOX-4158: [~gary.potagal] with the refactoring avoiding double

[jira] [Commented] (PDFBOX-4158) COSDocument and PDFMerger may not close all IO resources if closing of one fails

2018-03-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416022#comment-16416022 ] ASF subversion and git services commented on PDFBOX-4158: - Commit 1827850 from

[jira] [Commented] (PDFBOX-4158) COSDocument and PDFMerger may not close all IO resources if closing of one fails

2018-03-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416023#comment-16416023 ] ASF subversion and git services commented on PDFBOX-4158: - Commit 1827851 from

[jira] [Commented] (PDFBOX-4158) COSDocument and PDFMerger may not close all IO resources if closing of one fails

2018-03-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415912#comment-16415912 ] ASF subversion and git services commented on PDFBOX-4158: - Commit 1827848 from

[jira] [Commented] (PDFBOX-4158) COSDocument and PDFMerger may not close all IO resources if closing of one fails

2018-03-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415913#comment-16415913 ] ASF subversion and git services commented on PDFBOX-4158: - Commit 1827849 from

[jira] [Commented] (PDFBOX-4158) COSDocument and PDFMerger may not close all IO resources if closing of one fails

2018-03-27 Thread Gary Potagal (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415831#comment-16415831 ] Gary Potagal commented on PDFBOX-4158: -- [~msahyoun] - I see that you also added more logging to the

[jira] [Commented] (PDFBOX-4158) COSDocument and PDFMerger may not close all IO resources if closing of one fails

2018-03-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415352#comment-16415352 ] ASF subversion and git services commented on PDFBOX-4158: - Commit 1827821 from

[jira] [Commented] (PDFBOX-4158) COSDocument and PDFMerger may not close all IO resources if closing of one fails

2018-03-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415353#comment-16415353 ] ASF subversion and git services commented on PDFBOX-4158: - Commit 1827822 from

[jira] [Commented] (PDFBOX-4158) COSDocument and PDFMerger may not close all IO resources if closing of one fails

2018-03-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415304#comment-16415304 ] ASF subversion and git services commented on PDFBOX-4158: - Commit 1827818 from

[jira] [Commented] (PDFBOX-4158) COSDocument and PDFMerger may not close all IO resources if closing of one fails

2018-03-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415302#comment-16415302 ] ASF subversion and git services commented on PDFBOX-4158: - Commit 1827817 from

[jira] [Commented] (PDFBOX-4158) COSDocument and PDFMerger may not close all IO resources if closing of one fails

2018-03-27 Thread Maruan Sahyoun (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415292#comment-16415292 ] Maruan Sahyoun commented on PDFBOX-4158: [~gary.potagal] thanks for the patch. I'll apply it

[jira] [Commented] (PDFBOX-4158) COSDocument and PDFMerger may not close all IO resources if closing of one fails

2018-03-26 Thread Gary Potagal (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414464#comment-16414464 ] Gary Potagal commented on PDFBOX-4158: -- [~msahyoun] - ended up following your first advice to keep

[jira] [Commented] (PDFBOX-4158) COSDocument and PDFMerger may not close all IO resources if closing of one fails

2018-03-19 Thread Maruan Sahyoun (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405171#comment-16405171 ] Maruan Sahyoun commented on PDFBOX-4158: Thanks for your help on that matter. # we try to avoid

[jira] [Commented] (PDFBOX-4158) COSDocument and PDFMerger may not close all IO resources if closing of one fails

2018-03-19 Thread Gary Potagal (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405110#comment-16405110 ] Gary Potagal commented on PDFBOX-4158: -- Hi, changed the attached image: 

[jira] [Commented] (PDFBOX-4158) COSDocument and PDFMerger may not close all IO resources if closing of one fails

2018-03-19 Thread Maruan Sahyoun (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405082#comment-16405082 ] Maruan Sahyoun commented on PDFBOX-4158: My proposal would be to capture the first exception, log

[jira] [Commented] (PDFBOX-4158) COSDocument and PDFMerger may not close all IO resources if closing of one fails

2018-03-19 Thread Maruan Sahyoun (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405075#comment-16405075 ] Maruan Sahyoun commented on PDFBOX-4158: Hi, what's the link going into the blue PDDocument box

[jira] [Commented] (PDFBOX-4158) COSDocument and PDFMerger may not close all IO resources if closing of one fails

2018-03-19 Thread Gary Potagal (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405071#comment-16405071 ] Gary Potagal commented on PDFBOX-4158: -- We tried using PDFBox 2.0.4 to merge PDF Documents, in order