[jira] [Commented] (PDFBOX-5127) Multithreading issue in JempBox's DateConverter
[ https://issues.apache.org/jira/browse/PDFBOX-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300787#comment-17300787 ] ASF subversion and git services commented on PDFBOX-5127: - Commit 1887575 from Tilman Hausherr in branch 'pdfbox/branches/1.8' [ https://svn.apache.org/r1887575 ] PDFBOX-5127: remove debug stuff > Multithreading issue in JempBox's DateConverter > --- > > Key: PDFBOX-5127 > URL: https://issues.apache.org/jira/browse/PDFBOX-5127 > Project: PDFBox > Issue Type: Bug >Reporter: Tim Allison >Priority: Major > > [~tilman] recently found an exception thrown from here > ([https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L186)] > in one run of tika-eval but not in another. > > This is a multithreading issue caused by > [https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L43] > SimpleDateFormat is not threadsafe. I'm surprised we haven't seen this > earlier, but so it goes. > > Many, many thanks to Tilman for finding this! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-5127) Multithreading issue in JempBox's DateConverter
[
https://issues.apache.org/jira/browse/PDFBOX-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300784#comment-17300784
]
Tilman Hausherr commented on PDFBOX-5127:
-
The test failures were because of {{SimpleDateFormat}}, which is dependent on
the local time zone.
> Multithreading issue in JempBox's DateConverter
> ---
>
> Key: PDFBOX-5127
> URL: https://issues.apache.org/jira/browse/PDFBOX-5127
> Project: PDFBox
> Issue Type: Bug
>Reporter: Tim Allison
>Priority: Major
>
> [~tilman] recently found an exception thrown from here
> ([https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L186)]
> in one run of tika-eval but not in another.
>
> This is a multithreading issue caused by
> [https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L43]
> SimpleDateFormat is not threadsafe. I'm surprised we haven't seen this
> earlier, but so it goes.
>
> Many, many thanks to Tilman for finding this!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-5127) Multithreading issue in JempBox's DateConverter
[ https://issues.apache.org/jira/browse/PDFBOX-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300783#comment-17300783 ] ASF subversion and git services commented on PDFBOX-5127: - Commit 1887574 from Tilman Hausherr in branch 'pdfbox/branches/1.8' [ https://svn.apache.org/r1887574 ] PDFBOX-5127: more debug stuff to find out what's going on; set timezone before setting SimpleDateFormat > Multithreading issue in JempBox's DateConverter > --- > > Key: PDFBOX-5127 > URL: https://issues.apache.org/jira/browse/PDFBOX-5127 > Project: PDFBox > Issue Type: Bug >Reporter: Tim Allison >Priority: Major > > [~tilman] recently found an exception thrown from here > ([https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L186)] > in one run of tika-eval but not in another. > > This is a multithreading issue caused by > [https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L43] > SimpleDateFormat is not threadsafe. I'm surprised we haven't seen this > earlier, but so it goes. > > Many, many thanks to Tilman for finding this! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-5127) Multithreading issue in JempBox's DateConverter
[ https://issues.apache.org/jira/browse/PDFBOX-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300779#comment-17300779 ] ASF subversion and git services commented on PDFBOX-5127: - Commit 1887571 from Tilman Hausherr in branch 'pdfbox/branches/1.8' [ https://svn.apache.org/r1887571 ] PDFBOX-5127: more debug stuff to find out what's going on; use Z instead of XXX which isn't supported on jdk6 > Multithreading issue in JempBox's DateConverter > --- > > Key: PDFBOX-5127 > URL: https://issues.apache.org/jira/browse/PDFBOX-5127 > Project: PDFBox > Issue Type: Bug >Reporter: Tim Allison >Priority: Major > > [~tilman] recently found an exception thrown from here > ([https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L186)] > in one run of tika-eval but not in another. > > This is a multithreading issue caused by > [https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L43] > SimpleDateFormat is not threadsafe. I'm surprised we haven't seen this > earlier, but so it goes. > > Many, many thanks to Tilman for finding this! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-5127) Multithreading issue in JempBox's DateConverter
[ https://issues.apache.org/jira/browse/PDFBOX-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300774#comment-17300774 ] ASF subversion and git services commented on PDFBOX-5127: - Commit 1887570 from Tilman Hausherr in branch 'pdfbox/branches/1.8' [ https://svn.apache.org/r1887570 ] PDFBOX-5127: add timezone and debug stuff to find out what's going on > Multithreading issue in JempBox's DateConverter > --- > > Key: PDFBOX-5127 > URL: https://issues.apache.org/jira/browse/PDFBOX-5127 > Project: PDFBox > Issue Type: Bug >Reporter: Tim Allison >Priority: Major > > [~tilman] recently found an exception thrown from here > ([https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L186)] > in one run of tika-eval but not in another. > > This is a multithreading issue caused by > [https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L43] > SimpleDateFormat is not threadsafe. I'm surprised we haven't seen this > earlier, but so it goes. > > Many, many thanks to Tilman for finding this! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-5127) Multithreading issue in JempBox's DateConverter
[ https://issues.apache.org/jira/browse/PDFBOX-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300769#comment-17300769 ] ASF subversion and git services commented on PDFBOX-5127: - Commit 1887569 from Tilman Hausherr in branch 'pdfbox/branches/1.8' [ https://svn.apache.org/r1887569 ] PDFBOX-5127: remove debug stuff > Multithreading issue in JempBox's DateConverter > --- > > Key: PDFBOX-5127 > URL: https://issues.apache.org/jira/browse/PDFBOX-5127 > Project: PDFBox > Issue Type: Bug >Reporter: Tim Allison >Priority: Major > > [~tilman] recently found an exception thrown from here > ([https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L186)] > in one run of tika-eval but not in another. > > This is a multithreading issue caused by > [https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L43] > SimpleDateFormat is not threadsafe. I'm surprised we haven't seen this > earlier, but so it goes. > > Many, many thanks to Tilman for finding this! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-5127) Multithreading issue in JempBox's DateConverter
[ https://issues.apache.org/jira/browse/PDFBOX-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300768#comment-17300768 ] ASF subversion and git services commented on PDFBOX-5127: - Commit 1887568 from Tilman Hausherr in branch 'pdfbox/branches/1.8' [ https://svn.apache.org/r1887568 ] PDFBOX-5127: cut off all after the date instead of bothering with timezone > Multithreading issue in JempBox's DateConverter > --- > > Key: PDFBOX-5127 > URL: https://issues.apache.org/jira/browse/PDFBOX-5127 > Project: PDFBox > Issue Type: Bug >Reporter: Tim Allison >Priority: Major > > [~tilman] recently found an exception thrown from here > ([https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L186)] > in one run of tika-eval but not in another. > > This is a multithreading issue caused by > [https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L43] > SimpleDateFormat is not threadsafe. I'm surprised we haven't seen this > earlier, but so it goes. > > Many, many thanks to Tilman for finding this! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-5127) Multithreading issue in JempBox's DateConverter
[ https://issues.apache.org/jira/browse/PDFBOX-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300750#comment-17300750 ] Tilman Hausherr commented on PDFBOX-5127: - Hmm, this timezone thing needs some more work. > Multithreading issue in JempBox's DateConverter > --- > > Key: PDFBOX-5127 > URL: https://issues.apache.org/jira/browse/PDFBOX-5127 > Project: PDFBox > Issue Type: Bug >Reporter: Tim Allison >Priority: Major > > [~tilman] recently found an exception thrown from here > ([https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L186)] > in one run of tika-eval but not in another. > > This is a multithreading issue caused by > [https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L43] > SimpleDateFormat is not threadsafe. I'm surprised we haven't seen this > earlier, but so it goes. > > Many, many thanks to Tilman for finding this! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-5127) Multithreading issue in JempBox's DateConverter
[ https://issues.apache.org/jira/browse/PDFBOX-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300748#comment-17300748 ] Tilman Hausherr commented on PDFBOX-5127: - [~tallison] you're right, I realize the multithreading is because these files both have date formats that are not supported. That's the reason it hasn't hit any users in the wild. > Multithreading issue in JempBox's DateConverter > --- > > Key: PDFBOX-5127 > URL: https://issues.apache.org/jira/browse/PDFBOX-5127 > Project: PDFBox > Issue Type: Bug >Reporter: Tim Allison >Priority: Major > > [~tilman] recently found an exception thrown from here > ([https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L186)] > in one run of tika-eval but not in another. > > This is a multithreading issue caused by > [https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L43] > SimpleDateFormat is not threadsafe. I'm surprised we haven't seen this > earlier, but so it goes. > > Many, many thanks to Tilman for finding this! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-5127) Multithreading issue in JempBox's DateConverter
[ https://issues.apache.org/jira/browse/PDFBOX-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300747#comment-17300747 ] ASF subversion and git services commented on PDFBOX-5127: - Commit 1887565 from Tilman Hausherr in branch 'pdfbox/branches/1.8' [ https://svn.apache.org/r1887565 ] PDFBOX-5127: set timezone due to failing build test on the ci server > Multithreading issue in JempBox's DateConverter > --- > > Key: PDFBOX-5127 > URL: https://issues.apache.org/jira/browse/PDFBOX-5127 > Project: PDFBox > Issue Type: Bug >Reporter: Tim Allison >Priority: Major > > [~tilman] recently found an exception thrown from here > ([https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L186)] > in one run of tika-eval but not in another. > > This is a multithreading issue caused by > [https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L43] > SimpleDateFormat is not threadsafe. I'm surprised we haven't seen this > earlier, but so it goes. > > Many, many thanks to Tilman for finding this! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-5127) Multithreading issue in JempBox's DateConverter
[ https://issues.apache.org/jira/browse/PDFBOX-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300746#comment-17300746 ] ASF subversion and git services commented on PDFBOX-5127: - Commit 1887564 from Tilman Hausherr in branch 'pdfbox/branches/1.8' [ https://svn.apache.org/r1887564 ] PDFBOX-5127: create SimpleDateFormat object every time because it isn't thread-safe > Multithreading issue in JempBox's DateConverter > --- > > Key: PDFBOX-5127 > URL: https://issues.apache.org/jira/browse/PDFBOX-5127 > Project: PDFBox > Issue Type: Bug >Reporter: Tim Allison >Priority: Major > > [~tilman] recently found an exception thrown from here > ([https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L186)] > in one run of tika-eval but not in another. > > This is a multithreading issue caused by > [https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L43] > SimpleDateFormat is not threadsafe. I'm surprised we haven't seen this > earlier, but so it goes. > > Many, many thanks to Tilman for finding this! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-5127) Multithreading issue in JempBox's DateConverter
[ https://issues.apache.org/jira/browse/PDFBOX-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300722#comment-17300722 ] Tilman Hausherr commented on PDFBOX-5127: - I added a minimal test because when I replaced POTENTIAL_FORMATS with an empty array the build passed without a single failure. > Multithreading issue in JempBox's DateConverter > --- > > Key: PDFBOX-5127 > URL: https://issues.apache.org/jira/browse/PDFBOX-5127 > Project: PDFBox > Issue Type: Bug >Reporter: Tim Allison >Priority: Major > > [~tilman] recently found an exception thrown from here > ([https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L186)] > in one run of tika-eval but not in another. > > This is a multithreading issue caused by > [https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L43] > SimpleDateFormat is not threadsafe. I'm surprised we haven't seen this > earlier, but so it goes. > > Many, many thanks to Tilman for finding this! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-5127) Multithreading issue in JempBox's DateConverter
[ https://issues.apache.org/jira/browse/PDFBOX-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300720#comment-17300720 ] ASF subversion and git services commented on PDFBOX-5127: - Commit 1887563 from Tilman Hausherr in branch 'pdfbox/branches/1.8' [ https://svn.apache.org/r1887563 ] PDFBOX-5127: add minimal test to test happy path, and to make sure that the NumberFormatException is hit too > Multithreading issue in JempBox's DateConverter > --- > > Key: PDFBOX-5127 > URL: https://issues.apache.org/jira/browse/PDFBOX-5127 > Project: PDFBox > Issue Type: Bug >Reporter: Tim Allison >Priority: Major > > [~tilman] recently found an exception thrown from here > ([https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L186)] > in one run of tika-eval but not in another. > > This is a multithreading issue caused by > [https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L43] > SimpleDateFormat is not threadsafe. I'm surprised we haven't seen this > earlier, but so it goes. > > Many, many thanks to Tilman for finding this! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-5127) Multithreading issue in JempBox's DateConverter
[ https://issues.apache.org/jira/browse/PDFBOX-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300589#comment-17300589 ] Tim Allison commented on PDFBOX-5127: - My personal pref would be to generate SimpleDateFormat objects as needed. The good news either way (maybe?) is that this is in an exception handling bit, and I don't think I've seen it before so it should be pretty rare??? > Multithreading issue in JempBox's DateConverter > --- > > Key: PDFBOX-5127 > URL: https://issues.apache.org/jira/browse/PDFBOX-5127 > Project: PDFBox > Issue Type: Bug >Reporter: Tim Allison >Priority: Major > > [~tilman] recently found an exception thrown from here > ([https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L186)] > in one run of tika-eval but not in another. > > This is a multithreading issue caused by > [https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L43] > SimpleDateFormat is not threadsafe. I'm surprised we haven't seen this > earlier, but so it goes. > > Many, many thanks to Tilman for finding this! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-5127) Multithreading issue in JempBox's DateConverter
[ https://issues.apache.org/jira/browse/PDFBOX-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300579#comment-17300579 ] Tilman Hausherr commented on PDFBOX-5127: - Thanks for the explanation! So either we synchronize access to this segment (which will make it slower), or we generate SimpleDateFormat objects when needed (which will make it slower). > Multithreading issue in JempBox's DateConverter > --- > > Key: PDFBOX-5127 > URL: https://issues.apache.org/jira/browse/PDFBOX-5127 > Project: PDFBox > Issue Type: Bug >Reporter: Tim Allison >Priority: Major > > [~tilman] recently found an exception thrown from here > ([https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L186)] > in one run of tika-eval but not in another. > > This is a multithreading issue caused by > [https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L43] > SimpleDateFormat is not threadsafe. I'm surprised we haven't seen this > earlier, but so it goes. > > Many, many thanks to Tilman for finding this! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
