[jira] [Updated] (PDFBOX-5725) CharStringCommand overly complex
[ https://issues.apache.org/jira/browse/PDFBOX-5725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Lehmkühler updated PDFBOX-5725: --- Affects Version/s: 3.0.1 PDFBox > CharStringCommand overly complex > > > Key: PDFBOX-5725 > URL: https://issues.apache.org/jira/browse/PDFBOX-5725 > Project: PDFBox > Issue Type: Improvement >Affects Versions: 3.0.1 PDFBox >Reporter: Axel Howind >Assignee: Andreas Lehmkühler >Priority: Minor > Fix For: 4.0.0 > > Attachments: coding_convention,_use_switch.patch, > refactor_CharStringCommand.patch > > > The CharStringCommand class is quite complex and difficult to understand what > it does in detail. I suggest a refactoring to make the code shorter and > easier to understand. It should also perform better after the refactoring. > I have prepared a patch that > * turns CharStringCommand into an enum > * removes the internal Key class > * removes the different maps used for lookup and replaces them with a single > array for faster lookup -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Updated] (PDFBOX-5725) CharStringCommand overly complex
[ https://issues.apache.org/jira/browse/PDFBOX-5725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Lehmkühler updated PDFBOX-5725: --- Component/s: FontBox > CharStringCommand overly complex > > > Key: PDFBOX-5725 > URL: https://issues.apache.org/jira/browse/PDFBOX-5725 > Project: PDFBox > Issue Type: Improvement > Components: FontBox >Affects Versions: 3.0.1 PDFBox >Reporter: Axel Howind >Assignee: Andreas Lehmkühler >Priority: Minor > Fix For: 4.0.0 > > Attachments: coding_convention,_use_switch.patch, > refactor_CharStringCommand.patch > > > The CharStringCommand class is quite complex and difficult to understand what > it does in detail. I suggest a refactoring to make the code shorter and > easier to understand. It should also perform better after the refactoring. > I have prepared a patch that > * turns CharStringCommand into an enum > * removes the internal Key class > * removes the different maps used for lookup and replaces them with a single > array for faster lookup -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Updated] (PDFBOX-5725) CharStringCommand overly complex
[ https://issues.apache.org/jira/browse/PDFBOX-5725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Lehmkühler updated PDFBOX-5725: --- Fix Version/s: 4.0.0 > CharStringCommand overly complex > > > Key: PDFBOX-5725 > URL: https://issues.apache.org/jira/browse/PDFBOX-5725 > Project: PDFBox > Issue Type: Improvement >Reporter: Axel Howind >Assignee: Andreas Lehmkühler >Priority: Minor > Fix For: 4.0.0 > > Attachments: coding_convention,_use_switch.patch, > refactor_CharStringCommand.patch > > > The CharStringCommand class is quite complex and difficult to understand what > it does in detail. I suggest a refactoring to make the code shorter and > easier to understand. It should also perform better after the refactoring. > I have prepared a patch that > * turns CharStringCommand into an enum > * removes the internal Key class > * removes the different maps used for lookup and replaces them with a single > array for faster lookup -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Updated] (PDFBOX-5725) CharStringCommand overly complex
[ https://issues.apache.org/jira/browse/PDFBOX-5725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Axel Howind updated PDFBOX-5725: Attachment: coding_convention,_use_switch.patch > CharStringCommand overly complex > > > Key: PDFBOX-5725 > URL: https://issues.apache.org/jira/browse/PDFBOX-5725 > Project: PDFBox > Issue Type: Improvement >Reporter: Axel Howind >Priority: Minor > Attachments: coding_convention,_use_switch.patch, > refactor_CharStringCommand.patch > > > The CharStringCommand class is quite complex and difficult to understand what > it does in detail. I suggest a refactoring to make the code shorter and > easier to understand. It should also perform better after the refactoring. > I have prepared a patch that > * turns CharStringCommand into an enum > * removes the internal Key class > * removes the different maps used for lookup and replaces them with a single > array for faster lookup -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Updated] (PDFBOX-5725) CharStringCommand overly complex
[ https://issues.apache.org/jira/browse/PDFBOX-5725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Axel Howind updated PDFBOX-5725: Attachment: refactor_CharStringCommand.patch > CharStringCommand overly complex > > > Key: PDFBOX-5725 > URL: https://issues.apache.org/jira/browse/PDFBOX-5725 > Project: PDFBox > Issue Type: Improvement >Reporter: Axel Howind >Priority: Minor > Attachments: refactor_CharStringCommand.patch > > > The CharStringCommand class is quite complex and difficult to understand what > it does in detail. I suggest a refactoring to make the code shorter and > easier to understand. It should also perform better after the refactoring. > I have prepared a patch that > * turns CharStringCommand into an enum > * removes the internal Key class > * removes the different maps used for lookup and replaces them with a single > array for faster lookup -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
