Re: apreq release

2016-11-17 Thread Issac Goldstand
That was my knee-jerk reaction, too, but after digging, I saw that win32
really shouldn't be affected.

On 11/16/2016 4:09 PM, Steve Hay wrote:
> On 15 November 2016 at 09:26, Issac Goldstand  wrote:
>> Hi all,
>>
>> Someone (finally) noticed that apreq's test suite isn't compatible with
>> Apache 2.4 and requested a change.  Given that we haven't released an
>> updated apreq in nearly 6 years, I'm inclined to make/test the changes
>> to the test suite and immediately go to a release cycle.
>>
>> Does anyone want time to add anything else to libapreq-2.14 before I
>> start tarring and voting (in the next few days, I hope)?
>>
> 
> All looks good here on Win32 - the current SVN version passes all
> tests using VC++ 2010, perl-5.25.3, mod_perl-2.0.10 and either
> httpd-2.2.31 or httpd-2.4.23. (Whatever the httpd-2.4 incompatibility
> was seems not to affect anything on Win32!)
> 


-
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org



Re: apreq release

2016-11-17 Thread Issac Goldstand
Yes, if we go through with this.  The mod_apreq2 stuff is in httpd.
However I just realized that although it's been in trunk for years now,
it's never been backported to the 2.4.x branch.  I'm not sure why, and
my google-fu isn't finding relevant discussion on dev@httpd.

When I initially took a look yesterday, I thought I'd looked at a 2.4
release.  Can someone from the mod_perl dev community tell me if new
releases (intended for httpd 2.4) come from trunk or from the httpd24
branch?  If it's from the branch, then the apreq stuff could be moved to
trunk (or a submodule, like Apache::Reload and friends if desired).  If
trunk, then until mod_apreq is backported to httpd 2.4 (or httpd bumps
versions and rebranches off of trunk)



On 11/16/2016 3:40 PM, Brian J. France wrote:
> This is just merging the perl stuff into mod_perl, right?
> 
> Not merging mod_apreq2 and all the request cache/re-play bucket, POST 
> reading, file uploading, etc stuff, right?
> 
> I really don't want to have to include mod_perl so my C modules can read POST 
> data and handle file uploads.
> 
> Cheers,
> 
> Brian
> 
> 
>> On Nov 16, 2016, at 4:42 AM, Issac Goldstand  wrote:
>>
>> Given that the C was (finally) merged into httpd years ago, and given
>> that there are no proposed code changes, I'd say that's not such a bad
>> idea...
>>
>> I've become a bit rusty in Perl (and even with apreq) over the years,
>> but IIRC, all of the Perl glue is in
>> http://svn.apache.org/repos/asf/httpd/apreq/trunk/glue/perl/
>>
>> I'll take a crack at seeing if I can fold it into mod_perl despite the rust.
>>
>>
>> On 11/15/2016 2:45 PM, Andres Thomas Stivalet wrote:
>>> Good news!! No idea why apreq hasn't just been merged into mod_perl
>>> after all these years.
>>>
>>> A+++
>>>
>>> On Nov 15, 2016 3:27 AM, "Issac Goldstand" >> > wrote:
>>>
>>>Hi all,
>>>
>>>Someone (finally) noticed that apreq's test suite isn't compatible with
>>>Apache 2.4 and requested a change.  Given that we haven't released an
>>>updated apreq in nearly 6 years, I'm inclined to make/test the changes
>>>to the test suite and immediately go to a release cycle.
>>>
>>>Does anyone want time to add anything else to libapreq-2.14 before I
>>>start tarring and voting (in the next few days, I hope)?
>>>
>>>
>>>-
>>>To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
>>>
>>>For additional commands, e-mail: dev-h...@perl.apache.org
>>>
>>>
>>
> 


-
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org



Re: apreq release

2016-11-16 Thread Steve Hay
On 15 November 2016 at 09:26, Issac Goldstand  wrote:
> Hi all,
>
> Someone (finally) noticed that apreq's test suite isn't compatible with
> Apache 2.4 and requested a change.  Given that we haven't released an
> updated apreq in nearly 6 years, I'm inclined to make/test the changes
> to the test suite and immediately go to a release cycle.
>
> Does anyone want time to add anything else to libapreq-2.14 before I
> start tarring and voting (in the next few days, I hope)?
>

All looks good here on Win32 - the current SVN version passes all
tests using VC++ 2010, perl-5.25.3, mod_perl-2.0.10 and either
httpd-2.2.31 or httpd-2.4.23. (Whatever the httpd-2.4 incompatibility
was seems not to affect anything on Win32!)

-
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org



Re: apreq release

2016-11-16 Thread Issac Goldstand
Given that the C was (finally) merged into httpd years ago, and given
that there are no proposed code changes, I'd say that's not such a bad
idea...

I've become a bit rusty in Perl (and even with apreq) over the years,
but IIRC, all of the Perl glue is in
http://svn.apache.org/repos/asf/httpd/apreq/trunk/glue/perl/

I'll take a crack at seeing if I can fold it into mod_perl despite the rust.


On 11/15/2016 2:45 PM, Andres Thomas Stivalet wrote:
> Good news!! No idea why apreq hasn't just been merged into mod_perl
> after all these years.
> 
> A+++
> 
> On Nov 15, 2016 3:27 AM, "Issac Goldstand"  > wrote:
> 
> Hi all,
> 
> Someone (finally) noticed that apreq's test suite isn't compatible with
> Apache 2.4 and requested a change.  Given that we haven't released an
> updated apreq in nearly 6 years, I'm inclined to make/test the changes
> to the test suite and immediately go to a release cycle.
> 
> Does anyone want time to add anything else to libapreq-2.14 before I
> start tarring and voting (in the next few days, I hope)?
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
> 
> For additional commands, e-mail: dev-h...@perl.apache.org
> 
> 


-
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org



Re: apreq release

2016-11-16 Thread Issac Goldstand
Honestly, I've no clue.  The plan is just to add a few checks with
mod_version (if available) to deal with the 2.2/2.4 config syntax
changes, and the changes so far seem to only be in the test suite.  I
haven't hit any changes in libapreq itself yet.

I don't have any connection with the Debian maintainers, but if someone
on these lists does and has interest, they're welcome to update
following the ANNOUNCE message post-release.

On 11/15/2016 9:17 PM, Mark Hedges wrote:
> Any chance this is what keeps me from running the Apache::Test tests for
> Apache2::Controller under Apache 2.4?
> 
> Will this be packaged and released to Debian Stretch before it goes
> stable, or can you advise the package maintainers to update?
> 
> Thanks.
> Mark
> 
> On Tue, Nov 15, 2016 at 1:26 AM, Issac Goldstand  > wrote:
> 
> Hi all,
> 
> Someone (finally) noticed that apreq's test suite isn't compatible with
> Apache 2.4 and requested a change.  Given that we haven't released an
> updated apreq in nearly 6 years, I'm inclined to make/test the changes
> to the test suite and immediately go to a release cycle.
> 
> Does anyone want time to add anything else to libapreq-2.14 before I
> start tarring and voting (in the next few days, I hope)?
> 
> 


-
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org



Re: apreq release

2016-11-15 Thread Andres Thomas Stivalet
Good news!! No idea why apreq hasn't just been merged into mod_perl after
all these years.

A+++
On Nov 15, 2016 3:27 AM, "Issac Goldstand"  wrote:

> Hi all,
>
> Someone (finally) noticed that apreq's test suite isn't compatible with
> Apache 2.4 and requested a change.  Given that we haven't released an
> updated apreq in nearly 6 years, I'm inclined to make/test the changes
> to the test suite and immediately go to a release cycle.
>
> Does anyone want time to add anything else to libapreq-2.14 before I
> start tarring and voting (in the next few days, I hope)?
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
> For additional commands, e-mail: dev-h...@perl.apache.org
>
>