Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC3

2019-10-03 Thread Steve Hay
On Thu, 3 Oct 2019 at 10:14, Pete Houston  wrote:
>
> On Wed, Oct 02, 2019 at 06:07:39PM +0100, Steve Hay wrote:
> >
> > I'm not sure about this area, but if it works for with your patch then
> > it's probably an improvement :-)
> >
> > Just out of interest, does the following alternative patch work?
> >
> > Index: lib/Apache2/Resource.pm
> > ===
> > --- lib/Apache2/Resource.pm (revision 1866274)
> > +++ lib/Apache2/Resource.pm (working copy)
> > @@ -115,8 +115,7 @@
> >"");
> >
> >  for my $res (keys %$lim) {
> > -my $val = eval "::Resource::${res}()";
> > -my ($soft, $hard) = getrlimit $val;
> > +my ($soft, $hard) = getrlimit($lim->{$res});
> >  (my $limit = $res) =~ s/^RLIMIT_//;
> >  ($soft, $hard) = ("$soft " . BM($soft), "$hard ". BM($hard))
> >  if $is_mb{$limit};
>
> Yes, that works just as well for me.
>
> > This avoids making the ::Resource::${res}() calls, which are what
> > is returning undef for you in some cases. Or does this fail just the
> > same because some of the values of %$lim are also undef anyway?
>
> The %$lim values are not undef. See the attached stand-alone test and
> output for the problematic values which I see and which also shows that
> the limits for those resources are still retrievable via getrlimit().
>

Great! Thanks for confirming. I've now committed that fix, and hope to
make the final release soon: I don't think this single change warrants
an RC4.

-
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org



Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC3

2019-10-03 Thread Pete Houston
On Wed, Oct 02, 2019 at 06:07:39PM +0100, Steve Hay wrote:
> 
> I'm not sure about this area, but if it works for with your patch then
> it's probably an improvement :-)
> 
> Just out of interest, does the following alternative patch work?
> 
> Index: lib/Apache2/Resource.pm
> ===
> --- lib/Apache2/Resource.pm (revision 1866274)
> +++ lib/Apache2/Resource.pm (working copy)
> @@ -115,8 +115,7 @@
>"");
> 
>  for my $res (keys %$lim) {
> -my $val = eval "::Resource::${res}()";
> -my ($soft, $hard) = getrlimit $val;
> +my ($soft, $hard) = getrlimit($lim->{$res});
>  (my $limit = $res) =~ s/^RLIMIT_//;
>  ($soft, $hard) = ("$soft " . BM($soft), "$hard ". BM($hard))
>  if $is_mb{$limit};

Yes, that works just as well for me.

> This avoids making the ::Resource::${res}() calls, which are what
> is returning undef for you in some cases. Or does this fail just the
> same because some of the values of %$lim are also undef anyway?

The %$lim values are not undef. See the attached stand-alone test and
output for the problematic values which I see and which also shows that
the limits for those resources are still retrievable via getrlimit().

HTH,

Pete
-- 
Openstrike - improving business through open source
https://www.openstrike.co.uk/ or call 01722 770036
use strict;
use warnings;

use Test::More;
use BSD::Resource qw/getrlimit get_rlimits/;

my $lim = get_rlimits ();
ok defined $lim, "get_rlimits returns defined value";
ok ref $lim, "get_rlimits returns reference";
is ref $lim, 'HASH', "get_rlimits returns hash reference";

for my $res (keys %$lim) {
	my $subval = eval "::Resource::${res}()";
	ok defined $subval, "BSD::Resource::${res}() gives defined result";
	is $subval, $lim->{$res}, 'Sub from resource matches hash value';
	my ($soft, $hard) = getrlimit $lim->{$res};
	ok defined $soft, "$res has soft limit $soft";
	ok defined $hard, "$res has hard limit $hard";
}

done_testing (3 + 4 * keys %$lim);
ok 1 - get_rlimits returns defined value
ok 2 - get_rlimits returns reference
ok 3 - get_rlimits returns hash reference
ok 4 - BSD::Resource::RLIMIT_STACK() gives defined result
ok 5 - Sub from resource matches hash value
ok 6 - RLIMIT_STACK has soft limit 8388608
ok 7 - RLIMIT_STACK has hard limit -1
ok 8 - BSD::Resource::RLIMIT_LOCKS() gives defined result
ok 9 - Sub from resource matches hash value
ok 10 - RLIMIT_LOCKS has soft limit -1
ok 11 - RLIMIT_LOCKS has hard limit -1
ok 12 - BSD::Resource::RLIMIT_CORE() gives defined result
ok 13 - Sub from resource matches hash value
ok 14 - RLIMIT_CORE has soft limit 0
ok 15 - RLIMIT_CORE has hard limit -1
ok 16 - BSD::Resource::RLIMIT_DATA() gives defined result
ok 17 - Sub from resource matches hash value
ok 18 - RLIMIT_DATA has soft limit -1
ok 19 - RLIMIT_DATA has hard limit -1
ok 20 - BSD::Resource::RLIMIT_AS() gives defined result
ok 21 - Sub from resource matches hash value
ok 22 - RLIMIT_AS has soft limit -1
ok 23 - RLIMIT_AS has hard limit -1
ok 24 - BSD::Resource::RLIMIT_CPU() gives defined result
ok 25 - Sub from resource matches hash value
ok 26 - RLIMIT_CPU has soft limit -1
ok 27 - RLIMIT_CPU has hard limit -1
ok 28 - BSD::Resource::RLIMIT_MEMLOCK() gives defined result
ok 29 - Sub from resource matches hash value
ok 30 - RLIMIT_MEMLOCK has soft limit 65536
ok 31 - RLIMIT_MEMLOCK has hard limit 65536
ok 32 - BSD::Resource::RLIMIT_OFILE() gives defined result
ok 33 - Sub from resource matches hash value
ok 34 - RLIMIT_OFILE has soft limit 1024
ok 35 - RLIMIT_OFILE has hard limit 4096
ok 36 - BSD::Resource::RLIMIT_FSIZE() gives defined result
ok 37 - Sub from resource matches hash value
ok 38 - RLIMIT_FSIZE has soft limit -1
ok 39 - RLIMIT_FSIZE has hard limit -1
ok 40 - BSD::Resource::RLIMIT_OPEN_MAX() gives defined result
ok 41 - Sub from resource matches hash value
ok 42 - RLIMIT_OPEN_MAX has soft limit 1024
ok 43 - RLIMIT_OPEN_MAX has hard limit 4096
ok 44 - BSD::Resource::RLIMIT_NPROC() gives defined result
ok 45 - Sub from resource matches hash value
ok 46 - RLIMIT_NPROC has soft limit 4096
ok 47 - RLIMIT_NPROC has hard limit 30837
not ok 48 - BSD::Resource::RLIMIT_MSGQUEUE() gives defined result
#   Failed test 'BSD::Resource::RLIMIT_MSGQUEUE() gives defined result'
#   at getrlimit.t line 14.
not ok 49 - Sub from resource matches hash value
#   Failed test 'Sub from resource matches hash value'
#   at getrlimit.t line 15.
#  got: undef
# expected: '12'
ok 50 - RLIMIT_MSGQUEUE has soft limit 819200
ok 51 - RLIMIT_MSGQUEUE has hard limit 819200
ok 52 - BSD::Resource::RLIMIT_NOFILE() gives defined result
ok 53 - Sub from resource matches hash value
ok 54 - RLIMIT_NOFILE has soft limit 1024
ok 55 - RLIMIT_NOFILE has hard limit 4096
not ok 56 - BSD::Resource::RLIMIT_NICE() gives defined result
#   Failed test 'BSD::Resource::RLIMIT_NICE() gives defined result'
#   at getrlimit.t line 14.
not ok 57 

Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC3

2019-10-02 Thread Steve Hay
On Wed, 2 Oct 2019 at 11:03, Pete Houston  wrote:
>
> On Wed, Oct 02, 2019 at 08:13:59AM +0100, Steve Hay wrote:
> >
> > I think the last line of the log extracts above is the clue, but I'm
> > not going to be able to fix this myself. Line 119 in
> > Apache2/Resource.pm is:
> >
> > my ($soft, $hard) = getrlimit $val;
> >
> > So it looks like $val is blank. That comes from line 118:
> >
> > my $val = eval "::Resource::${res}()";
> >
> > where $res is one of the keys of the $lim hashref, which comes from line 
> > 112:
> >
> > my $lim = get_rlimits();
> >
> > Both getrlimit() and get_rlimits() are further BSD::Resource
> > functions, which I see the error log also has further references to
> > above (several uninitialized value warnings), but is not a thing that
> > I have access to on Windows. Unless anyone else can help here then
> > we'll have to let this one go for now. Hopefully it's not a
> > showstopper.
>
> Thanks for this diagnosis. Going through the resources here I do see
> some which were undef and thus causing getrlimit to complain. Attached
> is the trivial patch which now makes the test pass for me. It seemed
> reasonable to simply omit undef resources but you might have a contrary
> view.
>
> For the record the undef resources I see are:
>
> RLIMIT_NICE
> RLIMIT_SIGPENDING
> RLIMIT_RTTIME
> RLIMIT_RTPRIO
> RLIMIT_MSGQUEUE
>

I'm not sure about this area, but if it works for with your patch then
it's probably an improvement :-)

Just out of interest, does the following alternative patch work?

Index: lib/Apache2/Resource.pm
===
--- lib/Apache2/Resource.pm (revision 1866274)
+++ lib/Apache2/Resource.pm (working copy)
@@ -115,8 +115,7 @@
   "");

 for my $res (keys %$lim) {
-my $val = eval "::Resource::${res}()";
-my ($soft, $hard) = getrlimit $val;
+my ($soft, $hard) = getrlimit($lim->{$res});
 (my $limit = $res) =~ s/^RLIMIT_//;
 ($soft, $hard) = ("$soft " . BM($soft), "$hard ". BM($hard))
 if $is_mb{$limit};

This avoids making the ::Resource::${res}() calls, which are what
is returning undef for you in some cases. Or does this fail just the
same because some of the values of %$lim are also undef anyway?


Resource-v2.patch
Description: Binary data

-
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org

Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC3

2019-10-02 Thread Pete Houston
On Wed, Oct 02, 2019 at 08:13:59AM +0100, Steve Hay wrote:
> 
> I think the last line of the log extracts above is the clue, but I'm
> not going to be able to fix this myself. Line 119 in
> Apache2/Resource.pm is:
> 
> my ($soft, $hard) = getrlimit $val;
> 
> So it looks like $val is blank. That comes from line 118:
> 
> my $val = eval "::Resource::${res}()";
> 
> where $res is one of the keys of the $lim hashref, which comes from line 112:
> 
> my $lim = get_rlimits();
> 
> Both getrlimit() and get_rlimits() are further BSD::Resource
> functions, which I see the error log also has further references to
> above (several uninitialized value warnings), but is not a thing that
> I have access to on Windows. Unless anyone else can help here then
> we'll have to let this one go for now. Hopefully it's not a
> showstopper.

Thanks for this diagnosis. Going through the resources here I do see
some which were undef and thus causing getrlimit to complain. Attached
is the trivial patch which now makes the test pass for me. It seemed
reasonable to simply omit undef resources but you might have a contrary
view.

For the record the undef resources I see are:

RLIMIT_NICE
RLIMIT_SIGPENDING
RLIMIT_RTTIME
RLIMIT_RTPRIO
RLIMIT_MSGQUEUE

HTH,

Pete
-- 
Openstrike - improving business through open source
https://www.openstrike.co.uk/ or call 01722 770036
--- lib/Apache2/Resource.pm.orig2019-09-26 18:10:15.0 +0100
+++ lib/Apache2/Resource.pm 2019-10-02 10:54:58.342756913 +0100
@@ -116,6 +116,7 @@
 
 for my $res (keys %$lim) {
 my $val = eval "::Resource::${res}()";
+next unless defined $val;
 my ($soft, $hard) = getrlimit $val;
 (my $limit = $res) =~ s/^RLIMIT_//;
 ($soft, $hard) = ("$soft " . BM($soft), "$hard ". BM($hard))


pgptA9yxo5gki.pgp
Description: PGP signature


Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC3

2019-10-02 Thread Steve Hay
On Fri, 27 Sep 2019 at 11:32, Pete Houston  wrote:
>
> On Fri, Sep 27, 2019 at 08:22:11AM +0100, Steve Hay wrote:
> > Can you give any more detail on the apache_resource.t failure? I've
> > not seen that reported anywhere else.
>
> $ t/TEST -verbose t/modules/apache_resource.t
> [warning] setting ulimit to allow core files
> ulimit -c unlimited; /usr/bin/perl /home/pete/src/mod_perl-2.0.11-rc3/t/TEST 
> -verbose 't/modules/apache_resource.t'
> /usr/local/httpd-2.4.41/bin/httpd  -d /home/pete/src/mod_perl-2.0.11-rc3/t -f 
> /home/pete/src/mod_perl-2.0.11-rc3/t/conf/httpd.conf -D APACHE2 -D APACHE2_4 
> -D PERL_USEITHREADS
> using Apache/2.4.41 (event MPM)
>
> waiting 300 seconds for server to start: .[Fri Sep 27 11:21:12.994001 2019] 
> [env:warn] [pid 4182:tid 139866432870272] AH01506: PassEnv variable 
> LD_LIBRARY_PATH was undefined
> [Fri Sep 27 11:21:13.154432 2019] [perl:info] [pid 4182:tid 139866432870272] 
> 6 Apache2:: modules loaded
> [Fri Sep 27 11:21:13.154642 2019] [perl:info] [pid 4182:tid 139866432870272] 
> 0 APR:: modules loaded
> [Fri Sep 27 11:21:13.154837 2019] [perl:info] [pid 4182:tid 139866432870272] 
> base server + 29 vhosts ready to run tests
> ...
> waiting 300 seconds for server to start: ok (waited 3 secs)
> server localhost.localdomain:8529 started
> server localhost.localdomain:8530 listening (filter_out_apache)
> server localhost.localdomain:8531 listening (perlsections)
> server localhost.localdomain:8532 listening (inherit)
> server localhost.localdomain:8533 listening (TestUser::rewrite)
> server localhost.localdomain:8534 listening (TestVhost::log)
> server localhost.localdomain:8535 listening (TestVhost::config)
> server localhost.localdomain:8536 listening (TestModperl::perl_options2)
> server localhost.localdomain:8537 listening (TestModperl::perl_options)
> server localhost.localdomain:8538 listening (TestModperl::merge)
> server localhost.localdomain:8539 listening (TestModperl::setupenv)
> server localhost.localdomain:8540 listening 
> (TestDirective::perlcleanuphandler)
> server localhost.localdomain:8541 listening (TestModules::proxy)
> server localhost.localdomain:8542 listening (TestProtocol::echo_block)
> server localhost.localdomain:8543 listening (TestProtocol::echo_bbs2)
> server localhost.localdomain:8544 listening (TestProtocol::pseudo_http)
> server localhost.localdomain:8545 listening (TestProtocol::echo_timeout)
> server localhost.localdomain:8546 listening (TestProtocol::echo_filter)
> server localhost.localdomain:8547 listening (TestProtocol::echo_nonblock)
> server localhost.localdomain:8548 listening (TestProtocol::echo_bbs)
> server localhost.localdomain:8549 listening (TestPreConnection::note)
> server localhost.localdomain:8550 listening (TestHooks::init)
> server localhost.localdomain:8551 listening (TestHooks::trans)
> server localhost.localdomain:8552 listening (TestHooks::hookrun)
> server localhost.localdomain:8553 listening (TestHooks::stacked_handlers2)
> server localhost.localdomain:8554 listening (TestHooks::startup)
> server localhost.localdomain:8555 listening (TestFilter::both_str_con_add)
> server localhost.localdomain:8556 listening (TestFilter::in_bbs_msg)
> server localhost.localdomain:8557 listening (TestFilter::in_str_msg)
> server localhost.localdomain:8558 listening (TestFilter::in_bbs_inject_header)
> server localhost.localdomain:8559 listening (TestDirective::perlmodule)
> server localhost.localdomain:8560 listening (TestDirective::perlrequire)
> server localhost.localdomain:8561 listening (TestDirective::perlloadmodule4)
> server localhost.localdomain:8562 listening (TestDirective::perlloadmodule5)
> server localhost.localdomain:8563 listening (TestDirective::perlloadmodule3)
> server localhost.localdomain:8564 listening (TestAPI::add_config)
> server localhost.localdomain:8565 listening (TestDirective::perlloadmodule6)
> server localhost.localdomain:8566 listening (TestHooks::push_handlers_anon)
> t/modules/apache_resource.t ..
> 1..1
> # Running under perl version 5.020003 for linux
> # Current time local: Fri Sep 27 11:21:16 2019
> # Current time GMT:   Fri Sep 27 10:21:16 2019
> # Using Test.pm version 1.26
> # Using Apache/Test.pm version 1.42
> not ok 1
> # Failed test 1 in t/modules/apache_resource.t at line 18
> Failed 1/1 subtests
>
> Test Summary Report
> ---
> t/modules/apache_resource.t (Wstat: 0 Tests: 1 Failed: 1)
>   Failed test:  1
> Files=1, Tests=1,  1 wallclock secs ( 0.05 usr  0.02 sys +  0.47 cusr  0.11 
> csys =  0.65 CPU)
> Result: FAIL
> Failed 1/1 test programs. 1/1 subtests failed.
> [warning] server localhost.localdomain:8529 shutdown
> [  error] error running tests (please examine t/logs/error_log)
>
>
> Some potentially relevant entries in t/logs/error_log:
>
> [Fri Sep 27 11:21:15.932361 2019] [cgid:error] [pid 4190:tid 139866432870272] 
> (2)No such file or directory: AH01243: Couldn't bind unix domain socket 
> /home/pete/src/mod_perl-2.0.11-rc3/t/logs/logs/cgisock.4186
> ...

Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC3

2019-10-01 Thread Adam Prime

+1 on gentoo with 2.4.41 prefork on perl 5.28.0

I still see the bbs tests failing as they have been.  I started to look 
into it a bit, and see what you're talking about with the ENV switch to 
'turn off LWP', but ran out of time. It kind of looked like when LWP was 
on, that the value of the header wasn't getting sent, but there seems to 
be a lot of magic going on in those tests in general, that i didn't have 
time to understand. It seemed like that test should be fixable though.


Adam

On 9/26/19 1:17 PM, Steve Hay wrote:

Please download, test, and report back on this mod_perl 2.0.11 release
candidate.

https://dist.apache.org/repos/dist/dev/perl/mod_perl-2.0.11-rc3.tar.gz

MD5  = dd6f7918fc492be21868a9774b2e58c5
SHA1 = e4af2eaabb40962cd7e5566e5ee3342090413b30

Changes since RC2 are as follows:

Fix t/api/request_rec.t failures [Steve Hay]



-
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org



Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC3

2019-09-28 Thread Damyan Ivanov
-=| Vincent Veyron, 26.09.2019 21:40:29 +0200 |=-
> On Thu, 26 Sep 2019 21:52:29 +0300
> Damyan Ivanov  wrote:
> > 
> > builds OK and tests pass on Debian/unstable amd64 and i386 with apache 
> > 2.4.41, apr 1.6.5, Perl 5.28.1, CGI 4.44
> 
> Would you mind explaining what steps you took to build on Debian? I'm on 
> Stretch (old stable), and can't build. 

I am building the Debian package, not the "naked" source.

> # make
> cd "src/modules/perl" && make
> …
> /usr/bin/ld : ne peut trouver -lperl
> collect2: error: ld returned 1 exit status

Seems you miss the Perl development files. Try installing libperl-dev.

You may prefer to stick with the pre-compiled package 
(libapache2-mod-perl2).


-- Damyan

-
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org



Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC3

2019-09-27 Thread Pete Houston
On Fri, Sep 27, 2019 at 08:22:11AM +0100, Steve Hay wrote:
> Can you give any more detail on the apache_resource.t failure? I've
> not seen that reported anywhere else.

$ t/TEST -verbose t/modules/apache_resource.t
[warning] setting ulimit to allow core files
ulimit -c unlimited; /usr/bin/perl /home/pete/src/mod_perl-2.0.11-rc3/t/TEST 
-verbose 't/modules/apache_resource.t'
/usr/local/httpd-2.4.41/bin/httpd  -d /home/pete/src/mod_perl-2.0.11-rc3/t -f 
/home/pete/src/mod_perl-2.0.11-rc3/t/conf/httpd.conf -D APACHE2 -D APACHE2_4 -D 
PERL_USEITHREADS
using Apache/2.4.41 (event MPM)

waiting 300 seconds for server to start: .[Fri Sep 27 11:21:12.994001 2019] 
[env:warn] [pid 4182:tid 139866432870272] AH01506: PassEnv variable 
LD_LIBRARY_PATH was undefined
[Fri Sep 27 11:21:13.154432 2019] [perl:info] [pid 4182:tid 139866432870272] 6 
Apache2:: modules loaded
[Fri Sep 27 11:21:13.154642 2019] [perl:info] [pid 4182:tid 139866432870272] 0 
APR:: modules loaded
[Fri Sep 27 11:21:13.154837 2019] [perl:info] [pid 4182:tid 139866432870272] 
base server + 29 vhosts ready to run tests
...
waiting 300 seconds for server to start: ok (waited 3 secs)
server localhost.localdomain:8529 started
server localhost.localdomain:8530 listening (filter_out_apache)
server localhost.localdomain:8531 listening (perlsections)
server localhost.localdomain:8532 listening (inherit)
server localhost.localdomain:8533 listening (TestUser::rewrite)
server localhost.localdomain:8534 listening (TestVhost::log)
server localhost.localdomain:8535 listening (TestVhost::config)
server localhost.localdomain:8536 listening (TestModperl::perl_options2)
server localhost.localdomain:8537 listening (TestModperl::perl_options)
server localhost.localdomain:8538 listening (TestModperl::merge)
server localhost.localdomain:8539 listening (TestModperl::setupenv)
server localhost.localdomain:8540 listening (TestDirective::perlcleanuphandler)
server localhost.localdomain:8541 listening (TestModules::proxy)
server localhost.localdomain:8542 listening (TestProtocol::echo_block)
server localhost.localdomain:8543 listening (TestProtocol::echo_bbs2)
server localhost.localdomain:8544 listening (TestProtocol::pseudo_http)
server localhost.localdomain:8545 listening (TestProtocol::echo_timeout)
server localhost.localdomain:8546 listening (TestProtocol::echo_filter)
server localhost.localdomain:8547 listening (TestProtocol::echo_nonblock)
server localhost.localdomain:8548 listening (TestProtocol::echo_bbs)
server localhost.localdomain:8549 listening (TestPreConnection::note)
server localhost.localdomain:8550 listening (TestHooks::init)
server localhost.localdomain:8551 listening (TestHooks::trans)
server localhost.localdomain:8552 listening (TestHooks::hookrun)
server localhost.localdomain:8553 listening (TestHooks::stacked_handlers2)
server localhost.localdomain:8554 listening (TestHooks::startup)
server localhost.localdomain:8555 listening (TestFilter::both_str_con_add)
server localhost.localdomain:8556 listening (TestFilter::in_bbs_msg)
server localhost.localdomain:8557 listening (TestFilter::in_str_msg)
server localhost.localdomain:8558 listening (TestFilter::in_bbs_inject_header)
server localhost.localdomain:8559 listening (TestDirective::perlmodule)
server localhost.localdomain:8560 listening (TestDirective::perlrequire)
server localhost.localdomain:8561 listening (TestDirective::perlloadmodule4)
server localhost.localdomain:8562 listening (TestDirective::perlloadmodule5)
server localhost.localdomain:8563 listening (TestDirective::perlloadmodule3)
server localhost.localdomain:8564 listening (TestAPI::add_config)
server localhost.localdomain:8565 listening (TestDirective::perlloadmodule6)
server localhost.localdomain:8566 listening (TestHooks::push_handlers_anon)
t/modules/apache_resource.t .. 
1..1
# Running under perl version 5.020003 for linux
# Current time local: Fri Sep 27 11:21:16 2019
# Current time GMT:   Fri Sep 27 10:21:16 2019
# Using Test.pm version 1.26
# Using Apache/Test.pm version 1.42
not ok 1
# Failed test 1 in t/modules/apache_resource.t at line 18
Failed 1/1 subtests 

Test Summary Report
---
t/modules/apache_resource.t (Wstat: 0 Tests: 1 Failed: 1)
  Failed test:  1
Files=1, Tests=1,  1 wallclock secs ( 0.05 usr  0.02 sys +  0.47 cusr  0.11 
csys =  0.65 CPU)
Result: FAIL
Failed 1/1 test programs. 1/1 subtests failed.
[warning] server localhost.localdomain:8529 shutdown
[  error] error running tests (please examine t/logs/error_log)


Some potentially relevant entries in t/logs/error_log:

[Fri Sep 27 11:21:15.932361 2019] [cgid:error] [pid 4190:tid 139866432870272] 
(2)No such file or directory: AH01243: Couldn't bind unix domain socket 
/home/pete/src/mod_perl-2.0.11-rc3/t/logs/logs/cgisock.4186
...
[Fri Sep 27 11:21:16.040150 2019] [cgid:crit] [pid 4186:tid 139866432870272] 
AH01238: cgid daemon failed to initialize
...
[Fri Sep 27 11:21:16.546874 2019] [authz_core:debug] [pid 4193:tid 
139866043488000] 

Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC3

2019-09-27 Thread Steve Hay
On Thu, 26 Sep 2019 at 23:05, Pete Houston  wrote:
>
> This RC fails for me:
>
> Test Summary Report
> ---
> t/filter/in_bbs_inject_header.t   (Wstat: 0 Tests: 36 Failed: 3)
>   Failed tests:  22, 26, 30
> t/modules/apache_resource.t   (Wstat: 0 Tests: 1 Failed: 1)
>   Failed test:  1
> Files=245, Tests=2607, 138 wallclock secs ( 2.26 usr  0.92 sys + 100.92 cusr 
> 19.69 csys = 123.79 CPU)
> Result: FAIL
> Failed 2/245 test programs. 4/2607 subtests failed.
>
> with apache 2.4.41 (event MPM), perl 5.20.3 on x86_64-linux-thread-multi.
> I did not test any of the previous RCs.
>

I've just updated the README with a note that the recurring
in_bbs_inject_header.t failure is a known problem.

Can you give any more detail on the apache_resource.t failure? I've
not seen that reported anywhere else.

-
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org



Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC3

2019-09-26 Thread Jie Gao
My test result as follows:


t/filter/in_bbs_inject_header.t . 1/? # Failed test 22 in 
t/filter/in_bbs_inject_header.t at line 58 fail #6
# Failed test 26 in t/filter/in_bbs_inject_header.t at line 58 fail #7
# Failed test 30 in t/filter/in_bbs_inject_header.t at line 58 fail #8

Test Summary Report
---
t/filter/in_bbs_inject_header.t   (Wstat: 0 Tests: 36 Failed: 3)
  Failed tests:  22, 26, 30
Files=245, Tests=2977, 125 wallclock secs ( 1.24 usr  0.53 sys + 81.62 cusr 
24.81 csys = 108.20 CPU)
Result: FAIL
Failed 1/245 test programs. 3/2977 subtests failed.

> t/TEST -verbose t/filter/in_bbs_inject_header.t
[warning] setting ulimit to allow core files
ulimit -c unlimited; /usr/local/bin/perl 
/usr/local/src/mod_perl-2.0.11-rc3/t/TEST -verbose 
't/filter/in_bbs_inject_header.t'
/usr/local/httpd-2.4.41/bin/httpd  -d /usr/local/src/mod_perl-2.0.11-rc3/t -f 
/usr/local/src/mod_perl-2.0.11-rc3/t/conf/httpd.conf -D APACHE2 -D APACHE2_4 -D 
PERL_USEITHREADS
using Apache/2.4.41 (worker MPM)

waiting 300 seconds for server to start: .[Fri Sep 27 10:30:29.336068 2019] 
[core:trace3] [pid 1229:tid 140710015452928] core.c(3355): Setting LogLevel for 
all modules to trace8
[Fri Sep 27 10:30:29.336224 2019] [env:warn] [pid 1229:tid 140710015452928] 
AH01506: PassEnv variable LD_LIBRARY_PATH was undefined
[Fri Sep 27 10:30:29.356678 2019] [perl:info] [pid 1229:tid 140710015452928] 6 
Apache2:: modules loaded
[Fri Sep 27 10:30:29.356710 2019] [perl:info] [pid 1229:tid 140710015452928] 0 
APR:: modules loaded
[Fri Sep 27 10:30:29.356747 2019] [perl:info] [pid 1229:tid 140710015452928] 
base server + 29 vhosts ready to run tests
..
waiting 300 seconds for server to start: ok (waited 1 secs)
server localhost:8529 started
server localhost:8530 listening (filter_out_apache)
server localhost:8531 listening (perlsections)
server localhost:8532 listening (inherit)
server localhost:8533 listening (TestModperl::perl_options2)
server localhost:8534 listening (TestModperl::perl_options)
server localhost:8535 listening (TestModperl::setupenv)
server localhost:8536 listening (TestModperl::merge)
server localhost:8537 listening (TestUser::rewrite)
server localhost:8538 listening (TestModules::proxy)
server localhost:8539 listening (TestVhost::config)
server localhost:8540 listening (TestVhost::log)
server localhost:8541 listening (TestDirective::perlcleanuphandler)
server localhost:8542 listening (TestProtocol::echo_nonblock)
server localhost:8543 listening (TestProtocol::echo_block)
server localhost:8544 listening (TestProtocol::echo_timeout)
server localhost:8545 listening (TestProtocol::echo_bbs2)
server localhost:8546 listening (TestProtocol::pseudo_http)
server localhost:8547 listening (TestProtocol::echo_filter)
server localhost:8548 listening (TestProtocol::echo_bbs)
server localhost:8549 listening (TestPreConnection::note)
server localhost:8550 listening (TestHooks::startup)
server localhost:8551 listening (TestHooks::hookrun)
server localhost:8552 listening (TestHooks::trans)
server localhost:8553 listening (TestHooks::stacked_handlers2)
server localhost:8554 listening (TestHooks::init)
server localhost:8555 listening (TestFilter::both_str_con_add)
server localhost:8556 listening (TestFilter::in_bbs_inject_header)
server localhost:8557 listening (TestFilter::in_str_msg)
server localhost:8558 listening (TestFilter::in_bbs_msg)
server localhost:8559 listening (TestDirective::perlrequire)
server localhost:8560 listening (TestDirective::perlmodule)
server localhost:8561 listening (TestDirective::perlloadmodule3)
server localhost:8562 listening (TestDirective::perlloadmodule5)
server localhost:8563 listening (TestDirective::perlloadmodule4)
server localhost:8564 listening (TestAPI::add_config)
server localhost:8565 listening (TestDirective::perlloadmodule6)
server localhost:8566 listening (TestHooks::push_handlers_anon)
t/filter/in_bbs_inject_header.t .. 
# connecting to localhost:8556
1..36
# Running under perl version 5.020002 for linux
# Current time local: Fri Sep 27 10:30:31 2019
# Current time GMT:   Fri Sep 27 00:30:31 2019
# Using Test.pm version 1.26
# Using Apache/Test.pm version 1.42
# testing : body
# expected: 'This body shouldn\'t be seen by the filter'
# received: 'This body shouldn\'t be seen by the filter'
ok 1
# testing : injected header X-My-Protocol
# expected: 'POST-IT'
# received: 'POST-IT'
ok 2
# testing : injected header X-Extra-Header2
# expected: 'Value 2'
# received: 'Value 2'
ok 3
# testing : injected header X-Extra-Header3
# expected: 'Value 3'
# received: 'Value 3'
ok 4
# testing : body
# expected: 'This body shouldn\'t be seen by the filter'
# received: 'This body shouldn\'t be seen by the filter'
ok 5
# testing : injected header X-My-Protocol
# expected: 'POST-IT'
# received: 'POST-IT'
ok 6
# testing : injected header X-Extra-Header2
# expected: 'Value 2'
# received: 'Value 2'
ok 7
# testing : injected header X-Extra-Header3
# expected: 'Value 3'
# received: 'Value 3'
ok 

Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC3

2019-09-26 Thread Pete Houston
This RC fails for me:

Test Summary Report
---
t/filter/in_bbs_inject_header.t   (Wstat: 0 Tests: 36 Failed: 3)
  Failed tests:  22, 26, 30
t/modules/apache_resource.t   (Wstat: 0 Tests: 1 Failed: 1)
  Failed test:  1
Files=245, Tests=2607, 138 wallclock secs ( 2.26 usr  0.92 sys + 100.92 cusr 
19.69 csys = 123.79 CPU)
Result: FAIL
Failed 2/245 test programs. 4/2607 subtests failed.

with apache 2.4.41 (event MPM), perl 5.20.3 on x86_64-linux-thread-multi.
I did not test any of the previous RCs.

Pete

On Thu, Sep 26, 2019 at 06:17:33PM +0100, Steve Hay wrote:
> Please download, test, and report back on this mod_perl 2.0.11 release
> candidate.
> 
> https://dist.apache.org/repos/dist/dev/perl/mod_perl-2.0.11-rc3.tar.gz
> 
> MD5  = dd6f7918fc492be21868a9774b2e58c5
> SHA1 = e4af2eaabb40962cd7e5566e5ee3342090413b30
> 
> Changes since RC2 are as follows:
> 
> Fix t/api/request_rec.t failures [Steve Hay]
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
> For additional commands, e-mail: dev-h...@perl.apache.org

-- 
Openstrike - improving business through open source
https://www.openstrike.co.uk/ or call 01722 770036


pgpzJzBYaniik.pgp
Description: PGP signature


Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC3

2019-09-26 Thread Damyan Ivanov
-=| Steve Hay, 26.09.2019 18:17:33 +0100 |=-
> Please download, test, and report back on this mod_perl 2.0.11 release
> candidate.
> 
> https://dist.apache.org/repos/dist/dev/perl/mod_perl-2.0.11-rc3.tar.gz

builds OK and tests pass on Debian/unstable amd64 and i386 with apache 
2.4.41, apr 1.6.5, Perl 5.28.1, CGI 4.44

-- Damyan

-
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org