Re: [RESULT: PASS] Re: [VOTE] Release libapreq2-2.17
On Thu, Sep 29, 2022 at 1:16 PM Steve Hay wrote: > > On Thu, 25 Aug 2022 at 09:58, Joe Orton wrote: > > > > Thanks for testing. The release is approved: > > > > PMC votes: +1 from ylavic, jfclere, jorton > > > > I will promote the release and announce it. > > > > Thanks for this release. I didn't get round to uploading it to CPAN > yet, but a bug report has come in for it anyway: > > https://rt.cpan.org/Public/Bug/Display.html?id=144470 Do we have an example of a payload/upload which does not pass apreq's multipart parsing in 2.17? Regards; Yann. - To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org For additional commands, e-mail: dev-h...@perl.apache.org
Re: [RESULT: PASS] Re: [VOTE] Release libapreq2-2.17
On Thu, 25 Aug 2022 at 09:58, Joe Orton wrote: > > Thanks for testing. The release is approved: > > PMC votes: +1 from ylavic, jfclere, jorton > > I will promote the release and announce it. > Thanks for this release. I didn't get round to uploading it to CPAN yet, but a bug report has come in for it anyway: https://rt.cpan.org/Public/Bug/Display.html?id=144470 - To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org For additional commands, e-mail: dev-h...@perl.apache.org
Re: [VOTE] Release libapreq2-2.17
On Aug 25, 2022, at 4:30 AM, Joe Orton wrote: > On Sun, Aug 21, 2022 at 04:28:25PM -0400, Edward J. Sabol wrote: >> "make test" reported no errors. However, the following tests were skipped: >> >> t/cgi.t .. skipped: cannot find one of cgi.c or cgid.c >> >> t/apreq/cgi.t skipped: cannot find one of cgi.c or cgid.c >> >> >> Any ideas as to why or what I should investigate or do to fix that, assuming >> it's indicative of a problem? > > Do you have mod_cgi or mod_cgid built and loaded in the httpd install > you are testing against? These tests should get skipped if not, which is > perfectly normal/expected. Thanks for your reply, Joe. That's reassuring. I see a mod_cgi.so in the same directory where mod_apreq.so is installed, but I guess Apache::Test isn't finding it or loading it for whatever reason. Cheers on the libapreq2-2.17 release! Regards, Ed - To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org For additional commands, e-mail: dev-h...@perl.apache.org
[RESULT: PASS] Re: [VOTE] Release libapreq2-2.17
Thanks for testing. The release is approved: PMC votes: +1 from ylavic, jfclere, jorton I will promote the release and announce it. Regards, Joe - To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org For additional commands, e-mail: dev-h...@perl.apache.org
Re: [VOTE] Release libapreq2-2.17
On Thu, Aug 18, 2022 at 12:31:56PM +0100, Joe Orton wrote: > Hi, I've prepared a candidate release tarball for libapreq2 v2.17 here: > > https://dist.apache.org/repos/dist/dev/httpd/libapreq/ > > I would like to call a VOTE over the next week to release this candidate > tarball as v2.17: > > [X] +1: It's not just good, it's good enough! > [ ] +0: Let's have a talk. > [ ] -1: There's trouble in paradise. Here's what's wrong. Adding my own +1, tests fine here on Fedora 36. Regards, Joe - To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org For additional commands, e-mail: dev-h...@perl.apache.org
Re: [VOTE] Release libapreq2-2.17
On Sun, Aug 21, 2022 at 04:28:25PM -0400, Edward J. Sabol wrote: > "make test" reported no errors. However, the following tests were skipped: > > t/cgi.t .. skipped: cannot find one of cgi.c or cgid.c > > t/apreq/cgi.t skipped: cannot find one of cgi.c or cgid.c > > > Any ideas as to why or what I should investigate or do to fix that, assuming > it's indicative of a problem? Hi Edward, Do you have mod_cgi or mod_cgid built and loaded in the httpd install you are testing against? These tests should get skipped if not, which is perfectly normal/expected. Regards, Joe - To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org For additional commands, e-mail: dev-h...@perl.apache.org
Re: [VOTE] Release libapreq2-2.17
On 8/18/22 13:31, Joe Orton wrote: [X] +1: It's not just good, it's good enough! Tested on fedora 36 -- Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org For additional commands, e-mail: dev-h...@perl.apache.org
Re: [VOTE] Release libapreq2-2.17
On Mon, Aug 22, 2022 at 11:32 AM Yann Ylavic wrote: > > On Thu, Aug 18, 2022 at 1:32 PM Joe Orton wrote: > > > > I would like to call a VOTE over the next week to release this candidate > > tarball as v2.17: > > +1 on Debian(s). Not really related to apreq, but somehow the perl test framework is now generating certificate key files in PKCS#8 format (for SSLProxyMachineCertificateFile), previously they were in PKCS#1 format. That's the case for the httpd test framework too. Any idea what happened there? As a result load_x509_info()::PEM_X509_INFO_read_bio() does not recognize them as private key files and httpd-2.4.x fails to load. httpd-trunk is loading still, thanks to r1884552, but this commit looks quite orthogonal/incidental per the commit message? Linking httpd-trunk with libapreq seems useless/hopeless though, since the apreq util/helper functions have been copied in server/apreq_*.c files with the exact same apreq_ prefix, httpd will always use its own ones.. Regards; Yann. - To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org For additional commands, e-mail: dev-h...@perl.apache.org
Re: [VOTE] Release libapreq2-2.17
On Thu, Aug 18, 2022 at 1:32 PM Joe Orton wrote: > > I would like to call a VOTE over the next week to release this candidate > tarball as v2.17: +1 on Debian(s). Thanks Joe for RMIng! - To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org For additional commands, e-mail: dev-h...@perl.apache.org
Re: [VOTE] Release libapreq2-2.17
Hi, Joe O.! On Aug 18, 2022, at 7:31 AM, Joe Orton wrote: > https://dist.apache.org/repos/dist/dev/httpd/libapreq/ I successfully configured and compiled using the following command: ./configure --enable-perl-glue --with-apache2-apxs=/path/to/my/apxs --with-perl=/path/to/some/perl "CFLAGS=-m32" "CXXFLAGS=-m32" "LDFLAGS=-m32" (Yeah, I'm compiling a 32-bit version because of institutional inertia and other esoteric reasons.) "make test" reported no errors. However, the following tests were skipped: t/cgi.t .. skipped: cannot find one of cgi.c or cgid.c t/apreq/cgi.t skipped: cannot find one of cgi.c or cgid.c Any ideas as to why or what I should investigate or do to fix that, assuming it's indicative of a problem? Thanks, Ed - To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org For additional commands, e-mail: dev-h...@perl.apache.org
