[jira] [Comment Edited] (PHOENIX-4319) Zookeeper connection should be closed immediately

2018-03-06 Thread Jepson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387124#comment-16387124 ] Jepson edited comment on PHOENIX-4319 at 3/6/18 8:32 AM: - *Reference:*

[jira] [Commented] (PHOENIX-4489) HBase Connection leak in Phoenix MR Jobs

2018-03-06 Thread Jepson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387441#comment-16387441 ] Jepson commented on PHOENIX-4489: - [~karanmehta93] Very nice, i have compiled, tested, and been ok. >

[jira] [Commented] (PHOENIX-4336) SELECT + ORDER BY performance much worse than self-join

2018-03-06 Thread Sokolov Yura (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387719#comment-16387719 ] Sokolov Yura commented on PHOENIX-4336: --- catched with same issue. > SELECT + ORDER BY performance

[jira] [Updated] (PHOENIX-4634) Looking up a parent index table of a tenant child view fails in BaseColumnResolver createTableRef()

2018-03-06 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas D'Silva updated PHOENIX-4634: Attachment: PHOENIX-4634-4.x-HBase-0.98.patch > Looking up a parent index table of a

[jira] [Commented] (PHOENIX-4643) Implement ARRAY_REMOVE built in function

2018-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388436#comment-16388436 ] ASF GitHub Bot commented on PHOENIX-4643: - Github user xjodoin commented on a diff in the pull

[GitHub] phoenix pull request #294: PHOENIX-4643 Implement ARRAY_REMOVE built in func...

2018-03-06 Thread xjodoin
Github user xjodoin commented on a diff in the pull request: https://github.com/apache/phoenix/pull/294#discussion_r172642442 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/ArrayRemoveFunction.java --- @@ -0,0 +1,102 @@ +/* + * Licensed to the

[GitHub] phoenix pull request #294: PHOENIX-4643 Implement ARRAY_REMOVE built in func...

2018-03-06 Thread xjodoin
Github user xjodoin commented on a diff in the pull request: https://github.com/apache/phoenix/pull/294#discussion_r172642518 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/ArrayRemoveFunction.java --- @@ -0,0 +1,102 @@ +/* + * Licensed to the

[jira] [Commented] (PHOENIX-4643) Implement ARRAY_REMOVE built in function

2018-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388439#comment-16388439 ] ASF GitHub Bot commented on PHOENIX-4643: - Github user xjodoin commented on a diff in the pull

[jira] [Commented] (PHOENIX-4643) Implement ARRAY_REMOVE built in function

2018-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388440#comment-16388440 ] ASF GitHub Bot commented on PHOENIX-4643: - Github user xjodoin commented on a diff in the pull

[GitHub] phoenix pull request #294: PHOENIX-4643 Implement ARRAY_REMOVE built in func...

2018-03-06 Thread xjodoin
Github user xjodoin commented on a diff in the pull request: https://github.com/apache/phoenix/pull/294#discussion_r172642555 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/ArrayRemoveFunction.java --- @@ -0,0 +1,102 @@ +/* + * Licensed to the

[jira] [Commented] (PHOENIX-4643) Implement ARRAY_REMOVE built in function

2018-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388438#comment-16388438 ] ASF GitHub Bot commented on PHOENIX-4643: - Github user xjodoin commented on a diff in the pull

[GitHub] phoenix pull request #294: PHOENIX-4643 Implement ARRAY_REMOVE built in func...

2018-03-06 Thread xjodoin
Github user xjodoin commented on a diff in the pull request: https://github.com/apache/phoenix/pull/294#discussion_r172642254 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/ArrayRemoveFunction.java --- @@ -0,0 +1,102 @@ +/* + * Licensed to the

[jira] [Commented] (PHOENIX-4641) Perform index maintenance on server-side for transactional local indexes

2018-03-06 Thread Ohad Shacham (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388464#comment-16388464 ] Ohad Shacham commented on PHOENIX-4641: ---   I can easily build such an API. I assume it will get a

[jira] [Assigned] (PHOENIX-4634) Looking up a parent index table of a tenant child view fails in BaseColumnResolver createTableRef()

2018-03-06 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas D'Silva reassigned PHOENIX-4634: --- Assignee: Thomas D'Silva > Looking up a parent index table of a tenant child view

[jira] [Commented] (PHOENIX-4643) Implement ARRAY_REMOVE built in function

2018-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388215#comment-16388215 ] ASF GitHub Bot commented on PHOENIX-4643: - Github user JamesRTaylor commented on a diff in the

[GitHub] phoenix pull request #294: PHOENIX-4643 Implement ARRAY_REMOVE built in func...

2018-03-06 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/294#discussion_r172603085 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/ArrayRemoveFunction.java --- @@ -0,0 +1,102 @@ +/* + * Licensed

[GitHub] phoenix pull request #294: PHOENIX-4643 Implement ARRAY_REMOVE built in func...

2018-03-06 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/294#discussion_r172604371 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/ArrayRemoveFunction.java --- @@ -0,0 +1,102 @@ +/* + * Licensed

[GitHub] phoenix pull request #294: PHOENIX-4643 Implement ARRAY_REMOVE built in func...

2018-03-06 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/294#discussion_r172607179 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/ArrayRemoveFunction.java --- @@ -0,0 +1,102 @@ +/* + * Licensed

[GitHub] phoenix issue #294: PHOENIX-4643 Implement ARRAY_REMOVE built in function

2018-03-06 Thread JamesRTaylor
Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/294 Thanks for the pull request, @xjodoin. Looks very good overall - I made a few specific comments on the implementation of the built-in function. ---

[GitHub] phoenix pull request #294: PHOENIX-4643 Implement ARRAY_REMOVE built in func...

2018-03-06 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/294#discussion_r172606335 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/ArrayRemoveFunction.java --- @@ -0,0 +1,102 @@ +/* + * Licensed

[jira] [Commented] (PHOENIX-4643) Implement ARRAY_REMOVE built in function

2018-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388210#comment-16388210 ] ASF GitHub Bot commented on PHOENIX-4643: - Github user JamesRTaylor commented on the issue:

[jira] [Commented] (PHOENIX-4643) Implement ARRAY_REMOVE built in function

2018-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388212#comment-16388212 ] ASF GitHub Bot commented on PHOENIX-4643: - Github user JamesRTaylor commented on a diff in the

[jira] [Commented] (PHOENIX-4643) Implement ARRAY_REMOVE built in function

2018-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388214#comment-16388214 ] ASF GitHub Bot commented on PHOENIX-4643: - Github user JamesRTaylor commented on a diff in the

[jira] [Commented] (PHOENIX-4643) Implement ARRAY_REMOVE built in function

2018-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388213#comment-16388213 ] ASF GitHub Bot commented on PHOENIX-4643: - Github user JamesRTaylor commented on a diff in the

[jira] [Commented] (PHOENIX-4418) UPPER() and LOWER() functions should be locale-aware

2018-03-06 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388534#comment-16388534 ] Thomas D'Silva commented on PHOENIX-4418: - [~shehzaadn] +1 LGTM, can you also please update the

[jira] [Commented] (PHOENIX-4643) Implement ARRAY_REMOVE built in function

2018-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388802#comment-16388802 ] ASF GitHub Bot commented on PHOENIX-4643: - Github user JamesRTaylor commented on a diff in the

[GitHub] phoenix pull request #294: PHOENIX-4643 Implement ARRAY_REMOVE built in func...

2018-03-06 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/294#discussion_r172711644 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/ArrayRemoveFunction.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to

[jira] [Commented] (PHOENIX-4418) UPPER() and LOWER() functions should be locale-aware

2018-03-06 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388593#comment-16388593 ] James Taylor commented on PHOENIX-4418: --- [~shehzaadn] - please follow up with a new JIRA on the

[jira] [Commented] (PHOENIX-4644) Array modification functions should require two arguments

2018-03-06 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388794#comment-16388794 ] James Taylor commented on PHOENIX-4644: --- Please review, [~tdsilva]. FYI, [~xjodoin] - you'll need

[jira] [Created] (PHOENIX-4644) Array modification functions should require two arguments

2018-03-06 Thread James Taylor (JIRA)
James Taylor created PHOENIX-4644: - Summary: Array modification functions should require two arguments Key: PHOENIX-4644 URL: https://issues.apache.org/jira/browse/PHOENIX-4644 Project: Phoenix

[jira] [Updated] (PHOENIX-4644) Array modification functions should require two arguments

2018-03-06 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-4644: -- Fix Version/s: 4.14.0 > Array modification functions should require two arguments >

[jira] [Updated] (PHOENIX-4644) Array modification functions should require two arguments

2018-03-06 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-4644: -- Attachment: PHOENIX-4644_v1.patch > Array modification functions should require two arguments

[jira] [Commented] (PHOENIX-4634) Looking up a parent index table of a tenant child view fails in BaseColumnResolver createTableRef()

2018-03-06 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388780#comment-16388780 ] Thomas D'Silva commented on PHOENIX-4634: - [~jamestaylor] Can you please review? > Looking up

[jira] [Updated] (PHOENIX-4634) Looking up a parent index table of a tenant child view fails in BaseColumnResolver createTableRef()

2018-03-06 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas D'Silva updated PHOENIX-4634: Attachment: PHOENIX-4634-v2.patch > Looking up a parent index table of a tenant child

[jira] [Commented] (PHOENIX-4640) Don't consider STATS_UPDATE_FREQ_MS_ATTRIB in TTL for server side cache

2018-03-06 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388548#comment-16388548 ] Hudson commented on PHOENIX-4640: - FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-1.3 #54 (See

[jira] [Commented] (PHOENIX-4624) COLLATION_KEY function cannot handle null values

2018-03-06 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388860#comment-16388860 ] Hudson commented on PHOENIX-4624: - ABORTED: Integrated in Jenkins build PreCommit-PHOENIX-Build #1785

[jira] [Commented] (PHOENIX-4644) Array modification functions should require two arguments

2018-03-06 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389001#comment-16389001 ] James Taylor commented on PHOENIX-4644: --- If first arg is null, then expression evaluates to null,

[jira] [Commented] (PHOENIX-4644) Array modification functions should require two arguments

2018-03-06 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388953#comment-16388953 ] Thomas D'Silva commented on PHOENIX-4644: - For ARRAY_PREPEND and ARRAY_CAT, if the first

[jira] [Commented] (PHOENIX-4423) Phoenix-hive compilation broken on >=Hive 2.3

2018-03-06 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388156#comment-16388156 ] Ankit Singhal commented on PHOENIX-4423: [~elserj], we need another fix

[jira] [Commented] (PHOENIX-4336) SELECT + ORDER BY performance much worse than self-join

2018-03-06 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388161#comment-16388161 ] James Taylor commented on PHOENIX-4336: --- The only difference in processing of these two queries is

[jira] [Updated] (PHOENIX-4423) Phoenix-hive compilation broken on >=Hive 2.3

2018-03-06 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Singhal updated PHOENIX-4423: --- Attachment: PHOENIX-4423_v1.patch > Phoenix-hive compilation broken on >=Hive 2.3 >

[jira] [Comment Edited] (PHOENIX-4423) Phoenix-hive compilation broken on >=Hive 2.3

2018-03-06 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388156#comment-16388156 ] Ankit Singhal edited comment on PHOENIX-4423 at 3/6/18 5:40 PM:

[jira] [Commented] (PHOENIX-4641) Perform index maintenance on server-side for transactional local indexes

2018-03-06 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388175#comment-16388175 ] James Taylor commented on PHOENIX-4641: --- FYI, [~ohads]. Will there be an API that will generate

[jira] [Created] (PHOENIX-4643) Implement ARRAY_REMOVE built in function

2018-03-06 Thread Xavier Jodoin (JIRA)
Xavier Jodoin created PHOENIX-4643: -- Summary: Implement ARRAY_REMOVE built in function Key: PHOENIX-4643 URL: https://issues.apache.org/jira/browse/PHOENIX-4643 Project: Phoenix Issue

[jira] [Commented] (PHOENIX-3860) Implement TAL functionality for Omid

2018-03-06 Thread Ohad Shacham (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387936#comment-16387936 ] Ohad Shacham commented on PHOENIX-3860: --- {quote}For the issue with the garbage collector, can we

[GitHub] phoenix pull request #294: PHOENIX-4643 Implement ARRAY_REMOVE built in func...

2018-03-06 Thread xjodoin
GitHub user xjodoin opened a pull request: https://github.com/apache/phoenix/pull/294 PHOENIX-4643 Implement ARRAY_REMOVE built in function You can merge this pull request into a Git repository by running: $ git pull https://github.com/xjodoin/phoenix PHOENIX-4643

[jira] [Commented] (PHOENIX-4643) Implement ARRAY_REMOVE built in function

2018-03-06 Thread Xavier Jodoin (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387994#comment-16387994 ] Xavier Jodoin commented on PHOENIX-4643: https://github.com/apache/phoenix/pull/294 >

[jira] [Commented] (PHOENIX-4643) Implement ARRAY_REMOVE built in function

2018-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387993#comment-16387993 ] ASF GitHub Bot commented on PHOENIX-4643: - GitHub user xjodoin opened a pull request:

[jira] [Issue Comment Deleted] (PHOENIX-4643) Implement ARRAY_REMOVE built in function

2018-03-06 Thread Xavier Jodoin (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xavier Jodoin updated PHOENIX-4643: --- Comment: was deleted (was: https://github.com/apache/phoenix/pull/294) > Implement

[jira] [Created] (PHOENIX-4642) Select from local index in backward direction returns only from last region.

2018-03-06 Thread Sokolov Yura (JIRA)
Sokolov Yura created PHOENIX-4642: - Summary: Select from local index in backward direction returns only from last region. Key: PHOENIX-4642 URL: https://issues.apache.org/jira/browse/PHOENIX-4642