[GitHub] phoenix issue #308: Client-side hash aggregation

2018-07-27 Thread geraldss
Github user geraldss commented on the issue: https://github.com/apache/phoenix/pull/308 @JamesRTaylor -- ok, I will submit a new PR. Can you comment on my last push and comments? ---

[GitHub] phoenix pull request #316: PHOENIX-3547 Supporting more number of indices pe...

2018-07-27 Thread m2je
Github user m2je closed the pull request at: https://github.com/apache/phoenix/pull/316 ---

[GitHub] phoenix issue #316: PHOENIX-3547 Supporting more number of indices per table...

2018-07-27 Thread m2je
Github user m2je commented on the issue: https://github.com/apache/phoenix/pull/316 I don't know what happened. Let me open a new pull request ---

[GitHub] phoenix issue #308: Client-side hash aggregation

2018-07-27 Thread JamesRTaylor
Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/308 Looks like the move of 5.x branch to become master messed up this PR. Can you please start a new pull request against the 4.x-HBase-1.4 branch (this is what was master before), @geraldss? FYI,

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2018-07-27 Thread maryannxue
Github user maryannxue closed the pull request at: https://github.com/apache/phoenix/pull/281 ---

[GitHub] phoenix pull request #278: PHOENIX-4322 DESC primary key column with variabl...

2018-07-27 Thread maryannxue
Github user maryannxue closed the pull request at: https://github.com/apache/phoenix/pull/278 ---

[GitHub] phoenix pull request #228: PHOENIX-3355 Register Phoenix built-in functions ...

2018-07-27 Thread maryannxue
Github user maryannxue closed the pull request at: https://github.com/apache/phoenix/pull/228 ---

[GitHub] phoenix issue #315: PHOENIX-3655 Global Phoenix Client Metrics for PQS

2018-07-27 Thread karanmehta93
Github user karanmehta93 commented on the issue: https://github.com/apache/phoenix/pull/315 The patch might be tricky to port to other branches. Will also look into that once the initial one gets in. ---

[GitHub] phoenix pull request #315: PHOENIX-3655 Global Phoenix Client Metrics for PQ...

2018-07-27 Thread karanmehta93
GitHub user karanmehta93 opened a pull request: https://github.com/apache/phoenix/pull/315 PHOENIX-3655 Global Phoenix Client Metrics for PQS @joshelser Please review. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Updated] (PHOENIX-3655) Global Phoenix Client Metrics for PQS

2018-07-27 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karan Mehta updated PHOENIX-3655: - Summary: Global Phoenix Client Metrics for PQS (was: Metrics for PQS) > Global Phoenix Client

[GitHub] phoenix issue #242: PQS metrics - https://issues.apache.org/jira/browse/PHOE...

2018-07-27 Thread karanmehta93
Github user karanmehta93 commented on the issue: https://github.com/apache/phoenix/pull/242 We decided not to follow this approach, Hence will be removing the reference to this PR from JIRA. ---

[jira] [Updated] (PHOENIX-3655) Global Phoenix Client Metrics for PQS

2018-07-27 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karan Mehta updated PHOENIX-3655: - Attachment: PHOENIX-3655.4.x-HBase-1.4.001.patch > Global Phoenix Client Metrics for PQS >

[jira] [Updated] (PHOENIX-3655) Global Phoenix Client Metrics for PQS

2018-07-27 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karan Mehta updated PHOENIX-3655: - Attachment: (was: PHOENIX-3655.001.patch) > Global Phoenix Client Metrics for PQS >

[jira] [Updated] (PHOENIX-3655) Global Phoenix Client Metrics for PQS

2018-07-27 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karan Mehta updated PHOENIX-3655: - Environment: (was: Linux 3.13.0-107-generic kernel, v4.9.0-HBase-0.98) > Global Phoenix

[jira] [Assigned] (PHOENIX-4815) support alter table modify column

2018-07-27 Thread Jaanai Zhang (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jaanai Zhang reassigned PHOENIX-4815: - Assignee: Jaanai Zhang > support alter table modify column >

[jira] [Updated] (PHOENIX-3655) Global Phoenix Client Metrics for PQS

2018-07-27 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karan Mehta updated PHOENIX-3655: - Attachment: PHOENIX-3655.001.patch > Global Phoenix Client Metrics for PQS >

[jira] [Updated] (PHOENIX-3655) Global Phoenix Client Metrics for PQS

2018-07-27 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karan Mehta updated PHOENIX-3655: - Attachment: (was: PHOENIX-3655.001.diff) > Global Phoenix Client Metrics for PQS >

[GitHub] phoenix pull request #316: PHOENIX-3547 Supporting more number of indices pe...

2018-07-27 Thread m2je
GitHub user m2je opened a pull request: https://github.com/apache/phoenix/pull/316 PHOENIX-3547 Supporting more number of indices per table. PHOENIX-3547 Supporting more number of indices per table. Currently the number of indices per Phoenix table is bound to maximum of

[GitHub] phoenix issue #316: PHOENIX-3547 Supporting more number of indices per table...

2018-07-27 Thread twdsilva
Github user twdsilva commented on the issue: https://github.com/apache/phoenix/pull/316 @m2je Thanks for the PR. Can you please update the PR so that it uses the correct branch, so that we can see only your changes? This PR currently has 250+ commits. ---

[GitHub] phoenix issue #316: PHOENIX-3547 Supporting more number of indices per table...

2018-07-27 Thread twdsilva
Github user twdsilva commented on the issue: https://github.com/apache/phoenix/pull/316 @m2je Thanks for the contribution. Can you please update the PR to use the correct branch. It currently has 250+ commits, so it hard to review your changes. ---

[jira] [Updated] (PHOENIX-4765) Add server side config property to disallow metadata changes that require being propagated to children

2018-07-27 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas D'Silva updated PHOENIX-4765: Description: After the server has been upgraded we will have a server side config

[jira] [Updated] (PHOENIX-4765) Add server side config property to disallow metadata changes that require being propagated to children

2018-07-27 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas D'Silva updated PHOENIX-4765: Summary: Add server side config property to disallow metadata changes that require being

[GitHub] phoenix issue #313: PHOENIX-4799 Write cells using checkAndMutate to prevent...

2018-07-27 Thread twdsilva
Github user twdsilva commented on the issue: https://github.com/apache/phoenix/pull/313 @ankitsinghal I filed PHOENIX-4765 to not allow metadata changes on a base table that has child views when the request is from an older client. This will also allow us to rollback the upgraded

[GitHub] phoenix pull request #315: PHOENIX-3655 Global Phoenix Client Metrics for PQ...

2018-07-27 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/315#discussion_r205899353 --- Diff: phoenix-core/src/test/resources/hadoop-metrics2.properties --- @@ -32,10 +32,9 @@ #[prefix].[source|sink].[instance].[options]

[GitHub] phoenix pull request #315: PHOENIX-3655 Global Phoenix Client Metrics for PQ...

2018-07-27 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/315#discussion_r205900530 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalClientMetrics.java --- @@ -108,40 +114,88 @@

[GitHub] phoenix pull request #315: PHOENIX-3655 Global Phoenix Client Metrics for PQ...

2018-07-27 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/315#discussion_r205901029 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java --- @@ -204,6 +219,39 @@ private static void

[GitHub] phoenix pull request #315: PHOENIX-3655 Global Phoenix Client Metrics for PQ...

2018-07-27 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/315#discussion_r205884048 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java --- @@ -204,6 +219,39 @@ private static void resetGlobalMetrics()

[GitHub] phoenix pull request #315: PHOENIX-3655 Global Phoenix Client Metrics for PQ...

2018-07-27 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/315#discussion_r205884792 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalClientMetrics.java --- @@ -108,40 +114,88 @@

[GitHub] phoenix pull request #315: PHOENIX-3655 Global Phoenix Client Metrics for PQ...

2018-07-27 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/315#discussion_r205884608 --- Diff: phoenix-core/src/test/resources/hadoop-metrics2.properties --- @@ -32,10 +32,9 @@ #[prefix].[source|sink].[instance].[options] #

[GitHub] phoenix pull request #315: PHOENIX-3655 Global Phoenix Client Metrics for PQ...

2018-07-27 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/315#discussion_r205884335 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java --- @@ -204,6 +219,39 @@ private static void resetGlobalMetrics()