Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206411967
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -3604,6 +3681,18 @@ public MutationState addColumn(PTable table,
[
https://issues.apache.org/jira/browse/PHOENIX-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jaanai Zhang updated PHOENIX-4822:
--
Attachment: PHOENIX-4822_master.patch
> The configuration "phoenix.query.dateFormatTimeZone"
[
https://issues.apache.org/jira/browse/PHOENIX-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jaanai Zhang updated PHOENIX-4822:
--
Attachment: PHOENIX-4822_5.x-HBase-2.0.patch
> The configuration
Github user jimmycasey commented on the issue:
https://github.com/apache/phoenix/pull/318
Done:
https://issues.apache.org/jira/browse/PHOENIX-4829
---
Jimmy Casey created PHOENIX-4829:
Summary: Fixed Spelling
Key: PHOENIX-4829
URL: https://issues.apache.org/jira/browse/PHOENIX-4829
Project: Phoenix
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/PHOENIX-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jaanai Zhang updated PHOENIX-4822:
--
Attachment: PHOENIX-4822_master.patch
PHOENIX-4822_4.14.0-HBase-1.4.patch
>
[
https://issues.apache.org/jira/browse/PHOENIX-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jaanai Zhang updated PHOENIX-4822:
--
Attachment: (was: PHOENIX-4822_master.patch)
> The configuration
GitHub user comnetwork opened a pull request:
https://github.com/apache/phoenix/pull/321
PHOENIX-4820 V3
This patch is mainly for :
1. remove CoerceExpression in
ExpressionUtil.IsColumnConstantExpressionVisitor,
conside following sql:
select a.av1
from
[
https://issues.apache.org/jira/browse/PHOENIX-4820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated PHOENIX-4820:
--
Attachment: PHOENIX-4820-4.x-HBase-1.4-v2.patch
> Optimize OrderBy for ClientAggregatePlan
>
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r206598832
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/monitoring/GlobalPhoenixMetricsTestSink.java
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r206595985
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java ---
@@ -204,6 +230,45 @@ private static void resetGlobalMetrics()
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r206598160
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalMetricRegistriesAdapter.java
---
@@ -0,0 +1,167 @@
+/*
+ * Licensed to
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r206597366
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java ---
@@ -204,6 +230,45 @@ private static void resetGlobalMetrics()
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r206598366
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalMetricRegistriesAdapter.java
---
@@ -0,0 +1,167 @@
+/*
+ * Licensed to
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r206598488
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java ---
@@ -204,6 +230,45 @@ private static void resetGlobalMetrics()
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r206616222
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalMetricRegistriesAdapter.java
---
@@ -0,0 +1,167 @@
+/*
+ * Licensed
Github user karanmehta93 commented on the issue:
https://github.com/apache/phoenix/pull/315
@joshelser I was trying out this patch with an internal PQS version. All
these metrics are pushed to JMX and we monitor those via OpenTSDB tcollectors.
I haven't done any perf-test here, but I
[
https://issues.apache.org/jira/browse/PHOENIX-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gerald Sangudi updated PHOENIX-4751:
Attachment: 0001-PHOENIX-4751-Implement-client-side-has.4.x-HBase-1.4.patch
> Support
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/315
> All these metrics are pushed to JMX and we monitor those via OpenTSDB
tcollectors.
Cool! I was just looking for a sanity check that you are seeing all of the
metrics you expect coming
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r206638567
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalMetricRegistriesAdapter.java
---
@@ -0,0 +1,167 @@
+/*
+ * Licensed to
Github user JamesRTaylor commented on the issue:
https://github.com/apache/phoenix/pull/298
Looks really good to me. Nice work, @ortutay! Any further comments,
@maryannxue?
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206687510
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java ---
@@ -16,8 +16,29 @@
*/
package
persistent cache key, and thus is a
way to force cache invalidation. You can do it on a daily basis, eg.
20180731=20180731, and this can also be used to pre-warm caches for upcoming
days as well. I'm planning to make a blog post explaining SQ cache + how to
rotate nonces once this change has been merged.
---
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/313
@karanmehta93 or @ankitsinghal Can you please review the updated PR,
thanks!
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206688033
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java ---
@@ -82,6 +82,10 @@
static final String
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206687937
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -2957,6 +3010,11 @@ MutationState dropTable(String schemaName,
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206687568
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -1913,6 +1940,21 @@ private PTable
Github user m2je commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/317#discussion_r206717705
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java ---
@@ -1223,7 +1225,9 @@ public void readFields(DataInput input) throws
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206737372
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2723,13 +2712,10 @@ private void
Ankit Singhal created PHOENIX-4831:
--
Summary: Move calls to SYSTEM.MUTEX on server
Key: PHOENIX-4831
URL: https://issues.apache.org/jira/browse/PHOENIX-4831
Project: Phoenix
Issue Type:
Github user m2je commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/317#discussion_r206715551
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/ExplainTable.java ---
@@ -204,14 +205,19 @@ private void appendPKColumnValue(StringBuilder
Github user m2je commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/317#discussion_r206715609
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -1431,11 +1438,42 @@ private PTable
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/320#discussion_r206715618
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java ---
@@ -2951,7 +2951,129 @@ public void
Github user m2je commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/317#discussion_r206715585
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -2185,7 +2223,7 @@ public void createTable(RpcController
Github user comnetwork commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/320#discussion_r206739045
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java ---
@@ -2951,7 +2951,129 @@ public void
Github user JamesRTaylor commented on the issue:
https://github.com/apache/phoenix/pull/320
Thanks for the earlier comment, @maryannxue. Do you think this approach is
a good first step? Can you think of any cases where this approach will be
problematic?
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206737818
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java ---
@@ -355,5 +355,19 @@
+ "," + COLUMN_NAME +
Github user ankitsinghal commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206738342
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java ---
@@ -355,5 +355,19 @@
+ "," + COLUMN_NAME
Github user ankitsinghal commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206738423
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2723,13 +2712,10 @@ private void
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/320#discussion_r206717157
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java ---
@@ -2951,7 +2951,129 @@ public void
JieChen created PHOENIX-4830:
Summary: order by primary key desc return wrong results
Key: PHOENIX-4830
URL: https://issues.apache.org/jira/browse/PHOENIX-4830
Project: Phoenix
Issue Type: Bug
Github user ankitsinghal commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206736061
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2723,13 +2712,10 @@ private void
Github user karanmehta93 commented on the issue:
https://github.com/apache/phoenix/pull/315
@joshelser I think the only question pending in this PR is if we want
JVMMetrics or not, which are crucial from PQS POV, otherwise not really for a
regular client. We can discuss what approach
Github user ankitsinghal commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206735726
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java ---
@@ -355,5 +355,19 @@
+ "," + COLUMN_NAME
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206737111
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java ---
@@ -355,5 +355,19 @@
+ "," + COLUMN_NAME +
[
https://issues.apache.org/jira/browse/PHOENIX-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankit Singhal updated PHOENIX-4765:
---
Priority: Blocker (was: Major)
> Add server side config property to disallow metadata
Github user ankitsinghal commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206741679
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java ---
@@ -355,5 +355,19 @@
+ "," + COLUMN_NAME
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206415547
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -1913,6 +1940,21 @@ private PTable
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206415970
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -2957,6 +3010,11 @@ MutationState dropTable(String
[
https://issues.apache.org/jira/browse/PHOENIX-4820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated PHOENIX-4820:
--
Attachment: PHOENIX-4820-4.x-HBase-1.4.patch
> Optimize OrderBy for ClientAggregatePlan
>
[
https://issues.apache.org/jira/browse/PHOENIX-4820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated PHOENIX-4820:
--
Attachment: (was: PHOENIX-4820_v1.patch)
> Optimize OrderBy for ClientAggregatePlan
>
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206414686
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -3410,17 +3405,10 @@ void
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206414419
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2723,6 +2712,9 @@ private void
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206416912
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java ---
@@ -16,8 +16,29 @@
*/
package
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206412733
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java ---
@@ -82,6 +82,10 @@
static final String
[
https://issues.apache.org/jira/browse/PHOENIX-4820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated PHOENIX-4820:
--
Attachment: (was: PHOENIX-4820_v2.patch)
> Optimize OrderBy for ClientAggregatePlan
>
56 matches
Mail list logo
