GitHub user lomoree opened a pull request:
https://github.com/apache/phoenix/pull/212
PHOENIX-3264 Allow TRUE and FALSE to be used as literal constants
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bloomberg/phoenix calcite
Github user lomoree commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/212#discussion_r81210455
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java ---
@@ -1036,4 +1048,40 @@ public Void visitCall(RexCall call
Github user lomoree commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/212#discussion_r81210093
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java ---
@@ -1036,4 +1048,40 @@ public Void visitCall(RexCall call
Github user lomoree commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/212#discussion_r81210767
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java ---
@@ -1036,4 +1048,40 @@ public Void visitCall(RexCall call
Github user lomoree commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/212#discussion_r81212299
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java ---
@@ -1036,4 +1048,40 @@ public Void visitCall(RexCall call
Github user lomoree commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/212#discussion_r81212263
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java ---
@@ -1036,4 +1048,40 @@ public Void visitCall(RexCall call
Github user lomoree commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/212#discussion_r81216671
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java ---
@@ -1036,4 +1048,40 @@ public Void visitCall(RexCall call
Github user lomoree closed the pull request at:
https://github.com/apache/phoenix/pull/213
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user lomoree closed the pull request at:
https://github.com/apache/phoenix/pull/214
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user lomoree commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/214#discussion_r82305850
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java ---
@@ -1453,7 +1453,7 @@ public void testInvalidPrimaryKeyDecl
GitHub user lomoree opened a pull request:
https://github.com/apache/phoenix/pull/216
PHOENIX-3265 Surround columns named date with double quotes
-- Only a few additional unit tests passed
-- Major impact on IT tests. Cherry-picked commit onto master to ensure no
glaring errors
GitHub user lomoree opened a pull request:
https://github.com/apache/phoenix/pull/215
PHOENIX-3345 SQLException code's not propagating as expected
-- Primarily impacts unit tests in QueryCompilerTest.java
You can merge this pull request into a Git repository by running:
$ git
GitHub user lomoree opened a pull request:
https://github.com/apache/phoenix/pull/214
PHOENIX-3298 Single column primary key may not be null
Note: This patch will not immediately resolve the
testInvalidPrimaryKeyDecl() test case due to another issue, PHOENIX-3345.
However
Github user lomoree commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/213#discussion_r81421343
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/ClientScanPlan.java ---
@@ -106,12 +106,18 @@ public ExplainPlan getExplainPlan() throws
GitHub user lomoree opened a pull request:
https://github.com/apache/phoenix/pull/213
PHOENIX-2827 Support OFFSET in Calcite-Phoenix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bloomberg/phoenix offset
Alternatively you can
Github user lomoree commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/213#discussion_r81431821
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/ClientScanPlan.java ---
@@ -106,12 +106,18 @@ public ExplainPlan getExplainPlan() throws
Github user lomoree commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/213#discussion_r81422631
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/calcite/rules/PhoenixConverterRules.java
---
@@ -232,8 +232,7 @@ public RelNode convert(RelNode rel
Github user lomoree closed the pull request at:
https://github.com/apache/phoenix/pull/219
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user lomoree closed the pull request at:
https://github.com/apache/phoenix/pull/220
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user lomoree opened a pull request:
https://github.com/apache/phoenix/pull/222
PHOENIX-3355 Register Phoenix built-in functions as Calcite functions
This patch works for nearly all built in functions. Aggregate functions are
not yet supported.
Ultimately we may want
Github user lomoree closed the pull request at:
https://github.com/apache/phoenix/pull/218
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user lomoree opened a pull request:
https://github.com/apache/phoenix/pull/219
PHOENIX-3267 Replace use of SELECT null with CAST(null AS )
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bloomberg/phoenix master
Github user lomoree closed the pull request at:
https://github.com/apache/phoenix/pull/215
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user lomoree opened a pull request:
https://github.com/apache/phoenix/pull/223
PHOENIX-3488 Support COUNT(DISTINCT x) in Phoenix-Calcite Integration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bloomberg/phoenix
GitHub user lomoree opened a pull request:
https://github.com/apache/phoenix/pull/220
PHOENIX-3394 Handle SequenceResolving through ConnectionQueryServices
interface
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bloomberg
Github user lomoree commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/220#discussion_r86365234
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/calcite/CalciteIT.java ---
@@ -1315,6 +1315,17 @@ public void initTable() throws Exception
Github user lomoree commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/220#discussion_r86365551
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/calcite/PhoenixSchema.java ---
@@ -329,24 +333,14 @@ private TableRef fixTableMultiTenancy(TableRef
Github user lomoree commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/215#discussion_r82853555
--- Diff:
phoenix-core/src/main/java/org/apache/calcite/jdbc/PhoenixCalciteFactory.java
---
@@ -161,6 +162,29 @@ public Object apply
Github user lomoree closed the pull request at:
https://github.com/apache/phoenix/pull/216
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user lomoree commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/215#discussion_r83024234
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java ---
@@ -1120,8 +1120,11 @@ public static SQLException
unwrapSqlException
Github user lomoree commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/215#discussion_r82688259
--- Diff:
phoenix-core/src/main/java/org/apache/calcite/jdbc/PhoenixCalciteFactory.java
---
@@ -161,6 +162,29 @@ public Object apply
GitHub user lomoree opened a pull request:
https://github.com/apache/phoenix/pull/218
PHOENIX-3265 Surround columns named date with double quotes
-- Intended to make phoenix compatible with calcite. Calcite has reserved
keywords such as date and dec which must be surrounded
Github user lomoree commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/224#discussion_r91162501
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/calcite/CalciteIT.java ---
@@ -1343,6 +1343,28 @@ public void initTable() throws Exception
Github user lomoree closed the pull request at:
https://github.com/apache/phoenix/pull/224
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user lomoree commented on the issue:
https://github.com/apache/phoenix/pull/224
After discussing options, we kept original design and merged as is. Closing
PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user lomoree commented on the issue:
https://github.com/apache/phoenix/pull/222
1. There are still a number of cases that don't pass. Many of them are due
to existing features not being supported, and many are due to other issues
within Calcite-Phoenix. I have compiled a list
Github user lomoree commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/223#discussion_r90563623
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/calcite/rules/PhoenixConverterRules.java
---
@@ -899,9 +899,6 @@ public static boolean
Github user lomoree commented on the issue:
https://github.com/apache/phoenix/pull/222
1. No differentiation between the regex functions (String based and Byte
based)
Yep I'll try some approaches to make this work.
2. Invert and MD5 Function don't work (phoenix doesn't
Github user lomoree closed the pull request at:
https://github.com/apache/phoenix/pull/223
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user lomoree opened a pull request:
https://github.com/apache/phoenix/pull/224
PHOENIX-3477 Support sequence arithmetic in Calcite-Phoenix
PhoenixConverterRules is meant to route any logical project through
PhoenixClientProject. Before, sequences were not properly being
Github user lomoree closed the pull request at:
https://github.com/apache/phoenix/pull/222
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
41 matches
Mail list logo
