[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-02-02 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23970428 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ExpressionIndexIT.java --- @@ -0,0 +1,774 @@ +/* + * Licensed to the Apache

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-02-02 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23971072 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -945,20 +960,40 @@ public MutationState createIndex

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-02-02 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23971043 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -945,20 +960,40 @@ public MutationState createIndex

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-02-02 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23971303 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java --- @@ -326,6 +326,49 @@ private IndexMaintainer(PTable dataTable, PTable

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-02-02 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23970708 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -945,55 +963,79 @@ public MutationState createIndex

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-02-02 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23970966 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/parse/ExpressionIndexParseNodeRewriter.java --- @@ -0,0 +1,77 @@ +/* + * Licensed

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-02-02 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23973403 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -630,6 +641,13 @@ private PTable getTable

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-02-02 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23971181 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/parse/LiteralParseNode.java --- @@ -80,4 +80,35 @@ public boolean isStateless() { public

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-02-02 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23971106 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -945,20 +960,40 @@ public MutationState createIndex

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-02-02 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23971147 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -945,20 +960,40 @@ public MutationState createIndex

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-02-06 Thread twdsilva
Github user twdsilva closed the pull request at: https://github.com/apache/phoenix/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-02-06 Thread twdsilva
Github user twdsilva commented on the pull request: https://github.com/apache/phoenix/pull/34#issuecomment-73304997 @JamesRTaylor Closing this pull request as it has been committed to master and 4.0 --- If your project is set up for it, you can reply to this email and have your

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-01-20 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23267987 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/IndexColumnExpressionCompiler.java --- @@ -0,0 +1,302 @@ +/* + * Licensed

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-01-20 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23268496 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java --- @@ -883,6 +903,14 @@ public void readFields(DataInput input) throws

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-01-20 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23270696 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java --- @@ -883,6 +903,14 @@ public void readFields(DataInput input) throws

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-01-20 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23268273 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -953,20 +973,39 @@ public MutationState createIndex

[GitHub] phoenix pull request: Function Index

2015-01-14 Thread twdsilva
GitHub user twdsilva opened a pull request: https://github.com/apache/phoenix/pull/34 Function Index This is my first cut at function based indexes. I need to add more tests and validate the expression that is supplied in the create index statement. Also

[GitHub] phoenix pull request: Function Index

2015-01-14 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r22988222 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java --- @@ -954,13 +981,14 @@ public int getEstimatedByteSize

[GitHub] phoenix pull request: Function Index

2015-01-14 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r22988250 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -953,20 +973,39 @@ public MutationState createIndex

[GitHub] phoenix pull request: Function Index

2015-01-14 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r22988189 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java --- @@ -892,6 +912,13 @@ public void readFields(DataInput input) throws

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-01-20 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23275475 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -953,20 +973,39 @@ public MutationState createIndex

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-01-20 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23275462 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -953,20 +973,39 @@ public MutationState createIndex

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-01-20 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23275488 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/FromCompiler.java --- @@ -184,7 +184,7 @@ public static ColumnResolver

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-01-20 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23275510 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java --- @@ -788,7 +788,7 @@ private void addProjectedColumn(ListPColumn

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-01-20 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23276893 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/IndexColumnExpressionCompiler.java --- @@ -0,0 +1,311 @@ +/* + * Licensed

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-01-20 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23275567 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java --- @@ -326,6 +322,48 @@ private IndexMaintainer(PTable dataTable, PTable

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-01-20 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23275602 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -953,20 +973,39 @@ public MutationState createIndex

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-01-20 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23275593 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java --- @@ -388,23 +426,21 @@ private IndexMaintainer(PTable dataTable

[GitHub] phoenix pull request: PHOENIX-1639 Enhance function/expression ind...

2015-02-17 Thread twdsilva
Github user twdsilva closed the pull request at: https://github.com/apache/phoenix/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] phoenix pull request: PHOENIX-1639 Enhance function/expression ind...

2015-02-17 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/36#discussion_r24837161 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexExpressionIT.java --- @@ -123,7 +126,7 @@ protected void helpTestCreateAndUpdate

[GitHub] phoenix pull request: PHOENIX-1639 Enhance function/expression ind...

2015-02-17 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/36#discussion_r24804592 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexExpressionIT.java --- @@ -809,58 +832,439 @@ public void helpTestDropIndexedColumn

[GitHub] phoenix pull request: PHOENIX-1639 Enhance function/expression ind...

2015-02-17 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/36#discussion_r24804626 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexExpressionIT.java --- @@ -809,58 +832,439 @@ public void helpTestDropIndexedColumn

[GitHub] phoenix pull request: PHOENIX-1639 Enhance function/expression ind...

2015-02-17 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/36#discussion_r24804498 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -433,14 +433,34 @@ private boolean addIndexesFromPhysicalTable

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-01-27 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23663726 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java --- @@ -881,7 +908,30 @@ public void readFields(DataInput input) throws

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-01-28 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23720074 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/Expression.java --- @@ -88,4 +88,9 @@ * @return */ boolean

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-01-27 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23664456 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/StatementContext.java --- @@ -98,11 +98,18 @@ public StatementContext(PhoenixStatement

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-01-27 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23663994 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/parse/TableName.java --- @@ -21,22 +21,33 @@ import org.apache.phoenix.util.SchemaUtil

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-01-28 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23717484 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java --- @@ -169,7 +169,7 @@ public void reset

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-01-28 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23717459 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ImmutableIndexIT.java --- @@ -50,23 +52,27 @@ private static void populateTestTable

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-01-28 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23718870 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java --- @@ -976,20 +1043,33 @@ private void initCachedState

[GitHub] phoenix pull request: PHOENIX-514 Support functional indexes

2015-01-28 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r23719273 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -2051,7 +2087,7 @@ public MutationState addColumn

[GitHub] phoenix pull request: PHOENIX-1639 Enhance function/expression ind...

2015-02-13 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/36#discussion_r24708974 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexExpressionIT.java --- @@ -737,7 +708,7 @@ protected void

[GitHub] phoenix pull request: PHOENIX-1639 Enhance function/expression ind...

2015-02-13 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/36#discussion_r24708956 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexExpressionIT.java --- @@ -193,52 +197,79 @@ protected void helpTestCreateAndUpdate

[GitHub] phoenix pull request: PHOENIX-1639 Enhance function/expression ind...

2015-02-13 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/36#discussion_r24708850 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java --- @@ -1493,5 +1493,77 @@ public void testMultiCFProjection() throws

[GitHub] phoenix pull request: PHOENIX-1639 Enhance function/expression ind...

2015-02-13 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/36#discussion_r24708828 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java --- @@ -154,8 +154,9 @@ public SQLException newException

[GitHub] phoenix pull request: PHOENIX-1639 Enhance function/expression ind...

2015-02-13 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/36#discussion_r24708905 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseViewIT.java --- @@ -130,7 +130,7 @@ protected void testUpdatableViewIndex(Integer

[GitHub] phoenix pull request: PHOENIX-1639 Enhance function/expression ind...

2015-02-13 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/36#discussion_r24708917 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java --- @@ -109,6 +109,11 @@ public void testNonSaltedUpdatableViewWithIndex() throws

[GitHub] phoenix pull request: PHOENIX-1639 Enhance function/expression ind...

2015-02-13 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/36#discussion_r24708879 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableIT.java --- @@ -346,16 +347,31 @@ public void testDropCoveredColumn() throws

[GitHub] phoenix pull request: PHOENIX-1639 Enhance function/expression ind...

2015-02-13 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/36#discussion_r24709007 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexExpressionIT.java --- @@ -809,58 +833,432 @@ public void helpTestDropIndexedColumn

[GitHub] phoenix pull request: PHOENIX-1639 Enhance function/expression ind...

2015-02-13 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/36#discussion_r24709209 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -435,6 +435,9 @@ private boolean addIndexesFromPhysicalTable

[GitHub] phoenix pull request: Index qos

2015-03-18 Thread twdsilva
GitHub user twdsilva opened a pull request: https://github.com/apache/phoenix/pull/49 Index qos You can merge this pull request into a Git repository by running: $ git pull https://github.com/twdsilva/phoenix index-qos Alternatively you can review and apply these changes

[GitHub] phoenix pull request: Index qos

2015-03-19 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/49#discussion_r26815625 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/hbase/index/table/CoprocessorHTableFactory.java --- @@ -42,19 +38,14 @@ public

[GitHub] phoenix pull request: Index qos

2015-03-19 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/49#discussion_r26815838 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexQosRpcControllerFactory.java --- @@ -60,27 +61,22 @@ public

[GitHub] phoenix pull request: PHOENIX-1684 Functional Index using REGEXP_S...

2015-03-24 Thread twdsilva
Github user twdsilva closed the pull request at: https://github.com/apache/phoenix/pull/54 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] phoenix pull request: PHOENIX-1457 Use high priority queue for met...

2015-03-24 Thread twdsilva
GitHub user twdsilva opened a pull request: https://github.com/apache/phoenix/pull/55 PHOENIX-1457 Use high priority queue for metadata endpoint calls You can merge this pull request into a Git repository by running: $ git pull https://github.com/twdsilva/phoenix metadata_qos

[GitHub] phoenix pull request: PHOENIX-1457 Use high priority queue for met...

2015-03-25 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/55#discussion_r27151905 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/hbase/index/PhoenixRpcControllerFactory.java --- @@ -26,52 +26,57 @@ import

[GitHub] phoenix pull request: PHOENIX-1457 Use high priority queue for met...

2015-03-27 Thread twdsilva
Github user twdsilva closed the pull request at: https://github.com/apache/phoenix/pull/55 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] phoenix pull request: PHOENIX-1457 Use high priority queue for met...

2015-03-26 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/55#discussion_r27269432 --- Diff: phoenix-core/src/main/java/org/apache/hadoop/hbase/ipc/PhoenixRpcScheduler.java --- @@ -40,28 +40,34 @@ private static final int

[GitHub] phoenix pull request: PHOENIX-1684 Functional Index using REGEXP_S...

2015-03-24 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/54#discussion_r27065708 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/parse/IndexExpressionParseNodeRewriter.java --- @@ -51,6 +51,12 @@ public Void visit

[GitHub] phoenix pull request: Index qos

2015-03-24 Thread twdsilva
Github user twdsilva closed the pull request at: https://github.com/apache/phoenix/pull/49 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] phoenix pull request: PHOENIX-1684 Functional Index using REGEXP_S...

2015-03-23 Thread twdsilva
GitHub user twdsilva opened a pull request: https://github.com/apache/phoenix/pull/54 PHOENIX-1684 Functional Index using REGEXP_SUBSTR doesn't work correctly You can merge this pull request into a Git repository by running: $ git pull https://github.com/twdsilva/phoenix

[GitHub] phoenix pull request: PHOENIX-628 Support native JSON data type

2015-04-24 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/76#discussion_r29096277 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/json/PhoenixJson.java --- @@ -0,0 +1,280 @@ +/* + * Licensed to the Apache Software

[GitHub] phoenix pull request: PHOENIX-628 Support native JSON data type

2015-04-24 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/76#discussion_r29096341 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/json/PhoenixJson.java --- @@ -0,0 +1,280 @@ +/* + * Licensed to the Apache Software

[GitHub] phoenix pull request: PHOENIX-628 Support native JSON data type

2015-04-24 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/76#discussion_r29096496 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/json/PhoenixJson.java --- @@ -0,0 +1,280 @@ +/* + * Licensed to the Apache Software

[GitHub] phoenix pull request: PHOENIX-628 Support native JSON data type

2015-04-24 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/76#discussion_r29096621 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDataType.java --- @@ -1144,17 +1144,18 @@ public static PDataType fromLiteral(Object

[GitHub] phoenix pull request: PHOENIX-2144 Implement JSON operators

2015-08-06 Thread twdsilva
Github user twdsilva commented on the pull request: https://github.com/apache/phoenix/pull/101#issuecomment-128525943 @petercdc Thanks for the updated pull request. @JamesRTaylor @AakashPradeep Do you have any additional feedback? --- If your project is set up for it, you can

[GitHub] phoenix pull request: PHOENIX-2144 Implement JSON operators

2015-08-06 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/101#discussion_r36479562 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java --- @@ -1339,4 +1362,193 @@ public Expression visit

[GitHub] phoenix pull request: PHOENIX-2144 Implement JSON operators

2015-08-06 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/101#discussion_r36478526 --- Diff: phoenix-core/src/main/antlr3/PhoenixSQL.g --- @@ -808,7 +808,14 @@ bind_expression returns [BindParseNode ret

[GitHub] phoenix pull request: PHOENIX-2144 Implement JSON operators

2015-08-06 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/101#discussion_r36479346 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java --- @@ -1339,4 +1362,193 @@ public Expression visit

[GitHub] phoenix pull request: PHOENIX-2144 Implement JSON operators

2015-08-06 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/101#discussion_r36482934 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/JsonPointAsTextExpression.java --- @@ -0,0 +1,80 @@ +/* + * Licensed

[GitHub] phoenix pull request: PHOENIX-2144 Implement JSON operators

2015-07-27 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/101#discussion_r35595085 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java --- @@ -200,12 +224,12 @@ public Expression visitLeave

[GitHub] phoenix pull request: PHOENIX-2144 Implement JSON operators

2015-07-27 Thread twdsilva
Github user twdsilva commented on the pull request: https://github.com/apache/phoenix/pull/101#issuecomment-125361795 @petercdc can you create a JIRA user, so you can be assigned to the issue? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] phoenix pull request: PHOENIX-2144 Implement JSON operators

2015-07-27 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/101#discussion_r35597656 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/BaseJSONExpression.java --- @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-23 Thread twdsilva
Github user twdsilva commented on the pull request: https://github.com/apache/phoenix/pull/93#issuecomment-124247112 @ictwanglei Can you please rebase and upload new patch, this one does not apply cleanly to the json branch? --- If your project is set up for it, you can reply

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-23 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/93#discussion_r35392010 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/json/PhoenixJson.java --- @@ -231,4 +236,197 @@ private PhoenixJson getPhoenixJsonInternal

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-23 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/93#discussion_r35394674 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/JsonEachFunction.java --- @@ -0,0 +1,96 @@ +/* + * Licensed

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-23 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/93#discussion_r35392777 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/JsonArrayElementsFunction.java --- @@ -0,0 +1,107 @@ +/* + * Licensed

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-23 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/93#discussion_r35388305 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/JsonArrayLengthFunctionIT.java --- @@ -0,0 +1,114 @@ +/** + * + */ +package

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-23 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/93#discussion_r35392706 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/json/PhoenixJson.java --- @@ -231,4 +236,197 @@ private PhoenixJson getPhoenixJsonInternal

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-23 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/93#discussion_r35394793 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/json/PhoenixJson.java --- @@ -231,4 +236,197 @@ private PhoenixJson getPhoenixJsonInternal

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-23 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/93#discussion_r35388212 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/JsonArrayLengthFunctionIT.java --- @@ -0,0 +1,114 @@ +/** + * + */ +package

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-23 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/93#discussion_r35388362 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/JsonArrayLengthFunctionIT.java --- @@ -0,0 +1,114 @@ +/** + * + */ +package

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-23 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/93#discussion_r35394937 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/expression/function/JsonFunctionTest.java --- @@ -0,0 +1,284 @@ +/* + * Licensed

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-23 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/93#discussion_r35394919 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/expression/function/JsonFunctionTest.java --- @@ -0,0 +1,284 @@ +/* + * Licensed

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-23 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/93#discussion_r35394623 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/ArrayToJsonFunction.java --- @@ -0,0 +1,105 @@ +/* + * Licensed

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-23 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/93#discussion_r35394964 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/expression/function/JsonFunctionTest.java --- @@ -0,0 +1,284 @@ +/* + * Licensed

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-24 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/101#discussion_r35461438 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/JSONOperationT.java --- @@ -0,0 +1,285 @@ +/* + * Licensed to the Apache Software

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-24 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/101#discussion_r35464834 --- Diff: phoenix-core/src/main/antlr3/PhoenixSQL.g --- @@ -1149,6 +1175,31 @@ PERCENT OUTER_JOIN

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-24 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/101#discussion_r35472793 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/JsonPointAsElementExpression.java --- @@ -0,0 +1,104 @@ +/* + * Licensed

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-24 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/101#discussion_r35474263 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java --- @@ -1339,4 +1363,188 @@ public Expression visit

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-24 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/101#discussion_r35472668 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/JsonPathAsTextExpression.java --- @@ -0,0 +1,82 @@ +/* + * Licensed

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-24 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/101#discussion_r35475066 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/JsonPathAsElementExpression.java --- @@ -0,0 +1,85 @@ +/* + * Licensed

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-24 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/101#discussion_r35473132 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/BaseJSONExpression.java --- @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-24 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/101#discussion_r35459730 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/JSONOperationT.java --- @@ -0,0 +1,285 @@ +/* + * Licensed to the Apache Software

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-24 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/101#discussion_r35459614 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/JSONOperationT.java --- @@ -0,0 +1,285 @@ +/* + * Licensed to the Apache Software

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-24 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/101#discussion_r35459640 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/JSONOperationT.java --- @@ -0,0 +1,285 @@ +/* + * Licensed to the Apache Software

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-24 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/101#discussion_r35459820 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/JSONOperationT.java --- @@ -0,0 +1,285 @@ +/* + * Licensed to the Apache Software

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-24 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/101#discussion_r35459677 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/JSONOperationT.java --- @@ -0,0 +1,285 @@ +/* + * Licensed to the Apache Software

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-24 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/101#discussion_r35471677 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/parse/JsonMultiKeySeatchAndParseNode.java --- @@ -0,0 +1,51 @@ +/* + * Licensed

[GitHub] phoenix pull request: PHOENIX-1661 Implement built-in functions fo...

2015-07-24 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/101#discussion_r35472618 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/JsonPathAsElementExpression.java --- @@ -0,0 +1,85 @@ +/* + * Licensed

  1   2   3   >